ceph-csi/vendor/k8s.io/kubernetes/pkg/kubectl/scale_test.go

684 lines
25 KiB
Go
Raw Normal View History

2018-01-09 18:57:14 +00:00
/*
Copyright 2014 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package kubectl
import (
2018-03-06 22:33:18 +00:00
"fmt"
2018-01-09 18:57:14 +00:00
"testing"
2018-03-06 22:33:18 +00:00
"time"
2018-01-09 18:57:14 +00:00
2018-07-18 14:47:22 +00:00
autoscalingv1 "k8s.io/api/autoscaling/v1"
2018-01-09 18:57:14 +00:00
kerrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2018-11-26 18:23:56 +00:00
api "k8s.io/apimachinery/pkg/apis/testapigroup/v1"
2018-03-06 22:33:18 +00:00
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/client-go/scale"
2018-07-18 14:47:22 +00:00
fakescale "k8s.io/client-go/scale/fake"
2018-01-09 18:57:14 +00:00
testcore "k8s.io/client-go/testing"
)
func TestReplicationControllerScaleRetry(t *testing.T) {
2018-07-18 14:47:22 +00:00
verbsOnError := map[string]*kerrors.StatusError{
"update": kerrors.NewConflict(api.Resource("Status"), "foo", nil),
}
scaleClientExpectedAction := []string{"get", "update", "get"}
scaleClient := createFakeScaleClient("replicationcontrollers", "foo-v1", 2, verbsOnError)
scaler := NewScaler(scaleClient)
2018-01-09 18:57:14 +00:00
preconditions := ScalePrecondition{-1, ""}
count := uint(3)
name := "foo-v1"
namespace := metav1.NamespaceDefault
2018-07-18 14:47:22 +00:00
scaleFunc := ScaleCondition(scaler, &preconditions, namespace, name, count, nil, schema.GroupResource{Group: "", Resource: "replicationcontrollers"})
2018-01-09 18:57:14 +00:00
pass, err := scaleFunc()
if pass {
t.Errorf("Expected an update failure to return pass = false, got pass = %v", pass)
}
if err != nil {
t.Errorf("Did not expect an error on update conflict failure, got %v", err)
}
preconditions = ScalePrecondition{3, ""}
2018-07-18 14:47:22 +00:00
scaleFunc = ScaleCondition(scaler, &preconditions, namespace, name, count, nil, schema.GroupResource{Group: "", Resource: "replicationcontrollers"})
2018-01-09 18:57:14 +00:00
pass, err = scaleFunc()
if err == nil {
t.Errorf("Expected error on precondition failure")
}
2018-07-18 14:47:22 +00:00
actions := scaleClient.Actions()
if len(actions) != len(scaleClientExpectedAction) {
t.Errorf("unexpected actions: %v, expected %d actions got %d", actions, len(scaleClientExpectedAction), len(actions))
}
for i, verb := range scaleClientExpectedAction {
if actions[i].GetVerb() != verb {
t.Errorf("unexpected action: %+v, expected %s", actions[i].GetVerb(), verb)
}
}
2018-01-09 18:57:14 +00:00
}
func TestReplicationControllerScaleInvalid(t *testing.T) {
2018-07-18 14:47:22 +00:00
verbsOnError := map[string]*kerrors.StatusError{
"update": kerrors.NewInvalid(api.Kind("Status"), "foo", nil),
}
scaleClientExpectedAction := []string{"get", "update"}
scaleClient := createFakeScaleClient("replicationcontrollers", "foo-v1", 1, verbsOnError)
scaler := NewScaler(scaleClient)
2018-01-09 18:57:14 +00:00
preconditions := ScalePrecondition{-1, ""}
count := uint(3)
name := "foo-v1"
namespace := "default"
2018-07-18 14:47:22 +00:00
scaleFunc := ScaleCondition(scaler, &preconditions, namespace, name, count, nil, schema.GroupResource{Group: "", Resource: "replicationcontrollers"})
2018-01-09 18:57:14 +00:00
pass, err := scaleFunc()
if pass {
t.Errorf("Expected an update failure to return pass = false, got pass = %v", pass)
}
2018-07-18 14:47:22 +00:00
if err == nil {
2018-01-09 18:57:14 +00:00
t.Errorf("Expected error on invalid update failure, got %v", err)
}
2018-07-18 14:47:22 +00:00
actions := scaleClient.Actions()
if len(actions) != len(scaleClientExpectedAction) {
t.Errorf("unexpected actions: %v, expected %d actions got %d", actions, len(scaleClientExpectedAction), len(actions))
2018-01-09 18:57:14 +00:00
}
2018-07-18 14:47:22 +00:00
for i, verb := range scaleClientExpectedAction {
if actions[i].GetVerb() != verb {
t.Errorf("unexpected action: %+v, expected %s", actions[i].GetVerb(), verb)
2018-01-09 18:57:14 +00:00
}
}
}
2018-07-18 14:47:22 +00:00
func TestReplicationControllerScale(t *testing.T) {
scaleClientExpectedAction := []string{"get", "update"}
scaleClient := createFakeScaleClient("replicationcontrollers", "foo-v1", 2, nil)
scaler := NewScaler(scaleClient)
2018-01-09 18:57:14 +00:00
preconditions := ScalePrecondition{-1, ""}
count := uint(3)
2018-07-18 14:47:22 +00:00
name := "foo-v1"
err := scaler.Scale("default", name, count, &preconditions, nil, nil, schema.GroupResource{Group: "", Resource: "replicationcontrollers"})
2018-01-09 18:57:14 +00:00
if err != nil {
2018-07-18 14:47:22 +00:00
t.Fatalf("unexpected error occurred = %v while scaling the resource", err)
2018-01-09 18:57:14 +00:00
}
2018-07-18 14:47:22 +00:00
actions := scaleClient.Actions()
if len(actions) != len(scaleClientExpectedAction) {
t.Errorf("unexpected actions: %v, expected %d actions got %d", actions, len(scaleClientExpectedAction), len(actions))
2018-01-09 18:57:14 +00:00
}
2018-07-18 14:47:22 +00:00
for i, verb := range scaleClientExpectedAction {
if actions[i].GetVerb() != verb {
t.Errorf("unexpected action: %+v, expected %s", actions[i].GetVerb(), verb)
}
2018-01-09 18:57:14 +00:00
}
}
2018-07-18 14:47:22 +00:00
func TestReplicationControllerScaleFailsPreconditions(t *testing.T) {
scaleClientExpectedAction := []string{"get"}
scaleClient := createFakeScaleClient("replicationcontrollers", "foo", 10, nil)
scaler := NewScaler(scaleClient)
2018-01-09 18:57:14 +00:00
preconditions := ScalePrecondition{2, ""}
count := uint(3)
name := "foo"
2018-07-18 14:47:22 +00:00
err := scaler.Scale("default", name, count, &preconditions, nil, nil, schema.GroupResource{Group: "", Resource: "replicationcontrollers"})
if err == nil {
t.Fatal("expected to get an error but none was returned")
2018-01-09 18:57:14 +00:00
}
2018-07-18 14:47:22 +00:00
actions := scaleClient.Actions()
if len(actions) != len(scaleClientExpectedAction) {
t.Errorf("unexpected actions: %v, expected %d actions got %d", actions, len(scaleClientExpectedAction), len(actions))
2018-01-09 18:57:14 +00:00
}
2018-07-18 14:47:22 +00:00
for i, verb := range scaleClientExpectedAction {
if actions[i].GetVerb() != verb {
t.Errorf("unexpected action: %+v, expected %s", actions[i].GetVerb(), verb)
2018-01-09 18:57:14 +00:00
}
}
}
func TestDeploymentScaleRetry(t *testing.T) {
2018-07-18 14:47:22 +00:00
verbsOnError := map[string]*kerrors.StatusError{
"update": kerrors.NewConflict(api.Resource("Status"), "foo", nil),
}
scaleClientExpectedAction := []string{"get", "update", "get"}
scaleClient := createFakeScaleClient("deployments", "foo", 2, verbsOnError)
scaler := NewScaler(scaleClient)
2018-01-09 18:57:14 +00:00
preconditions := &ScalePrecondition{-1, ""}
count := uint(3)
name := "foo"
namespace := "default"
2018-07-18 14:47:22 +00:00
scaleFunc := ScaleCondition(scaler, preconditions, namespace, name, count, nil, schema.GroupResource{Group: "apps", Resource: "deployments"})
2018-01-09 18:57:14 +00:00
pass, err := scaleFunc()
if pass != false {
t.Errorf("Expected an update failure to return pass = false, got pass = %v", pass)
}
if err != nil {
t.Errorf("Did not expect an error on update failure, got %v", err)
}
preconditions = &ScalePrecondition{3, ""}
2018-07-18 14:47:22 +00:00
scaleFunc = ScaleCondition(scaler, preconditions, namespace, name, count, nil, schema.GroupResource{Group: "apps", Resource: "deployments"})
2018-01-09 18:57:14 +00:00
pass, err = scaleFunc()
if err == nil {
2018-03-06 22:33:18 +00:00
t.Error("Expected error on precondition failure")
2018-01-09 18:57:14 +00:00
}
2018-07-18 14:47:22 +00:00
actions := scaleClient.Actions()
if len(actions) != len(scaleClientExpectedAction) {
t.Errorf("unexpected actions: %v, expected %d actions got %d", actions, len(scaleClientExpectedAction), len(actions))
}
for i, verb := range scaleClientExpectedAction {
if actions[i].GetVerb() != verb {
t.Errorf("unexpected action: %+v, expected %s", actions[i].GetVerb(), verb)
}
2018-01-09 18:57:14 +00:00
}
}
func TestDeploymentScale(t *testing.T) {
2018-07-18 14:47:22 +00:00
scaleClientExpectedAction := []string{"get", "update"}
scaleClient := createFakeScaleClient("deployments", "foo", 2, nil)
scaler := NewScaler(scaleClient)
2018-01-09 18:57:14 +00:00
preconditions := ScalePrecondition{-1, ""}
count := uint(3)
name := "foo"
2018-07-18 14:47:22 +00:00
err := scaler.Scale("default", name, count, &preconditions, nil, nil, schema.GroupResource{Group: "apps", Resource: "deployments"})
if err != nil {
t.Fatal(err)
2018-01-09 18:57:14 +00:00
}
2018-07-18 14:47:22 +00:00
actions := scaleClient.Actions()
if len(actions) != len(scaleClientExpectedAction) {
t.Errorf("unexpected actions: %v, expected %d actions got %d", actions, len(scaleClientExpectedAction), len(actions))
2018-01-09 18:57:14 +00:00
}
2018-07-18 14:47:22 +00:00
for i, verb := range scaleClientExpectedAction {
if actions[i].GetVerb() != verb {
t.Errorf("unexpected action: %+v, expected %s", actions[i].GetVerb(), verb)
}
2018-01-09 18:57:14 +00:00
}
}
func TestDeploymentScaleInvalid(t *testing.T) {
2018-07-18 14:47:22 +00:00
scaleClientExpectedAction := []string{"get", "update"}
verbsOnError := map[string]*kerrors.StatusError{
"update": kerrors.NewInvalid(api.Kind("Status"), "foo", nil),
}
scaleClient := createFakeScaleClient("deployments", "foo", 2, verbsOnError)
scaler := NewScaler(scaleClient)
2018-01-09 18:57:14 +00:00
preconditions := ScalePrecondition{-1, ""}
count := uint(3)
name := "foo"
namespace := "default"
2018-07-18 14:47:22 +00:00
scaleFunc := ScaleCondition(scaler, &preconditions, namespace, name, count, nil, schema.GroupResource{Group: "apps", Resource: "deployments"})
2018-01-09 18:57:14 +00:00
pass, err := scaleFunc()
if pass {
t.Errorf("Expected an update failure to return pass = false, got pass = %v", pass)
}
2018-07-18 14:47:22 +00:00
if err == nil {
2018-01-09 18:57:14 +00:00
t.Errorf("Expected error on invalid update failure, got %v", err)
}
2018-07-18 14:47:22 +00:00
actions := scaleClient.Actions()
if len(actions) != len(scaleClientExpectedAction) {
t.Errorf("unexpected actions: %v, expected %d actions got %d", actions, len(scaleClientExpectedAction), len(actions))
}
for i, verb := range scaleClientExpectedAction {
if actions[i].GetVerb() != verb {
t.Errorf("unexpected action: %+v, expected %s", actions[i].GetVerb(), verb)
}
}
2018-01-09 18:57:14 +00:00
}
func TestDeploymentScaleFailsPreconditions(t *testing.T) {
2018-07-18 14:47:22 +00:00
scaleClientExpectedAction := []string{"get"}
scaleClient := createFakeScaleClient("deployments", "foo", 10, nil)
scaler := NewScaler(scaleClient)
2018-01-09 18:57:14 +00:00
preconditions := ScalePrecondition{2, ""}
count := uint(3)
name := "foo"
2018-07-18 14:47:22 +00:00
err := scaler.Scale("default", name, count, &preconditions, nil, nil, schema.GroupResource{Group: "apps", Resource: "deployments"})
if err == nil {
t.Fatal("exptected to get an error but none was returned")
2018-01-09 18:57:14 +00:00
}
2018-07-18 14:47:22 +00:00
actions := scaleClient.Actions()
if len(actions) != len(scaleClientExpectedAction) {
t.Errorf("unexpected actions: %v, expected %d actions got %d", actions, len(scaleClientExpectedAction), len(actions))
2018-01-09 18:57:14 +00:00
}
2018-07-18 14:47:22 +00:00
for i, verb := range scaleClientExpectedAction {
if actions[i].GetVerb() != verb {
t.Errorf("unexpected action: %+v, expected %s", actions[i].GetVerb(), verb)
2018-01-09 18:57:14 +00:00
}
2018-03-06 22:33:18 +00:00
}
}
func TestStatefulSetScale(t *testing.T) {
2018-07-18 14:47:22 +00:00
scaleClientExpectedAction := []string{"get", "update"}
scaleClient := createFakeScaleClient("statefulsets", "foo", 2, nil)
scaler := NewScaler(scaleClient)
2018-03-06 22:33:18 +00:00
preconditions := ScalePrecondition{-1, ""}
count := uint(3)
name := "foo"
2018-11-26 18:23:56 +00:00
err := scaler.Scale("default", name, count, &preconditions, nil, nil, schema.GroupResource{Group: "apps", Resource: "statefulset"})
2018-07-18 14:47:22 +00:00
if err != nil {
t.Fatal(err)
2018-03-06 22:33:18 +00:00
}
2018-07-18 14:47:22 +00:00
actions := scaleClient.Actions()
if len(actions) != len(scaleClientExpectedAction) {
t.Errorf("unexpected actions: %v, expected %d actions got %d", actions, len(scaleClientExpectedAction), len(actions))
2018-03-06 22:33:18 +00:00
}
2018-07-18 14:47:22 +00:00
for i, verb := range scaleClientExpectedAction {
if actions[i].GetVerb() != verb {
t.Errorf("unexpected action: %+v, expected %s", actions[i].GetVerb(), verb)
}
2018-03-06 22:33:18 +00:00
}
}
func TestStatefulSetScaleRetry(t *testing.T) {
2018-07-18 14:47:22 +00:00
scaleClientExpectedAction := []string{"get", "update", "get"}
verbsOnError := map[string]*kerrors.StatusError{
"update": kerrors.NewConflict(api.Resource("Status"), "foo", nil),
}
scaleClient := createFakeScaleClient("statefulsets", "foo", 2, verbsOnError)
scaler := NewScaler(scaleClient)
2018-03-06 22:33:18 +00:00
preconditions := &ScalePrecondition{-1, ""}
count := uint(3)
name := "foo"
namespace := "default"
2018-07-18 14:47:22 +00:00
scaleFunc := ScaleCondition(scaler, preconditions, namespace, name, count, nil, schema.GroupResource{Group: "apps", Resource: "statefulsets"})
2018-03-06 22:33:18 +00:00
pass, err := scaleFunc()
if pass != false {
t.Errorf("Expected an update failure to return pass = false, got pass = %v", pass)
}
if err != nil {
t.Errorf("Did not expect an error on update failure, got %v", err)
}
preconditions = &ScalePrecondition{3, ""}
2018-07-18 14:47:22 +00:00
scaleFunc = ScaleCondition(scaler, preconditions, namespace, name, count, nil, schema.GroupResource{Group: "apps", Resource: "statefulsets"})
2018-03-06 22:33:18 +00:00
pass, err = scaleFunc()
if err == nil {
t.Error("Expected error on precondition failure")
}
2018-07-18 14:47:22 +00:00
actions := scaleClient.Actions()
if len(actions) != len(scaleClientExpectedAction) {
t.Errorf("unexpected actions: %v, expected %d actions got %d", actions, len(scaleClientExpectedAction), len(actions))
}
for i, verb := range scaleClientExpectedAction {
if actions[i].GetVerb() != verb {
t.Errorf("unexpected action: %+v, expected %s", actions[i].GetVerb(), verb)
}
}
2018-03-06 22:33:18 +00:00
}
func TestStatefulSetScaleInvalid(t *testing.T) {
2018-07-18 14:47:22 +00:00
scaleClientExpectedAction := []string{"get", "update"}
verbsOnError := map[string]*kerrors.StatusError{
"update": kerrors.NewInvalid(api.Kind("Status"), "foo", nil),
}
scaleClient := createFakeScaleClient("statefulsets", "foo", 2, verbsOnError)
scaler := NewScaler(scaleClient)
2018-03-06 22:33:18 +00:00
preconditions := ScalePrecondition{-1, ""}
count := uint(3)
name := "foo"
namespace := "default"
2018-07-18 14:47:22 +00:00
scaleFunc := ScaleCondition(scaler, &preconditions, namespace, name, count, nil, schema.GroupResource{Group: "apps", Resource: "statefulsets"})
2018-03-06 22:33:18 +00:00
pass, err := scaleFunc()
if pass {
t.Errorf("Expected an update failure to return pass = false, got pass = %v", pass)
}
2018-07-18 14:47:22 +00:00
if err == nil {
2018-03-06 22:33:18 +00:00
t.Errorf("Expected error on invalid update failure, got %v", err)
}
2018-07-18 14:47:22 +00:00
actions := scaleClient.Actions()
if len(actions) != len(scaleClientExpectedAction) {
t.Errorf("unexpected actions: %v, expected %d actions got %d", actions, len(scaleClientExpectedAction), len(actions))
}
for i, verb := range scaleClientExpectedAction {
if actions[i].GetVerb() != verb {
t.Errorf("unexpected action: %+v, expected %s", actions[i].GetVerb(), verb)
}
}
2018-03-06 22:33:18 +00:00
}
func TestStatefulSetScaleFailsPreconditions(t *testing.T) {
2018-07-18 14:47:22 +00:00
scaleClientExpectedAction := []string{"get"}
scaleClient := createFakeScaleClient("statefulsets", "foo", 10, nil)
scaler := NewScaler(scaleClient)
2018-03-06 22:33:18 +00:00
preconditions := ScalePrecondition{2, ""}
count := uint(3)
name := "foo"
2018-07-18 14:47:22 +00:00
err := scaler.Scale("default", name, count, &preconditions, nil, nil, schema.GroupResource{Group: "apps", Resource: "statefulsets"})
if err == nil {
t.Fatal("expected to get an error but none was returned")
2018-03-06 22:33:18 +00:00
}
2018-07-18 14:47:22 +00:00
actions := scaleClient.Actions()
if len(actions) != len(scaleClientExpectedAction) {
t.Errorf("unexpected actions: %v, expected %d actions got %d", actions, len(scaleClientExpectedAction), len(actions))
2018-03-06 22:33:18 +00:00
}
2018-07-18 14:47:22 +00:00
for i, verb := range scaleClientExpectedAction {
if actions[i].GetVerb() != verb {
t.Errorf("unexpected action: %+v, expected %s", actions[i].GetVerb(), verb)
2018-03-06 22:33:18 +00:00
}
}
}
func TestReplicaSetScale(t *testing.T) {
2018-07-18 14:47:22 +00:00
scaleClientExpectedAction := []string{"get", "update"}
scaleClient := createFakeScaleClient("replicasets", "foo", 10, nil)
scaler := NewScaler(scaleClient)
2018-03-06 22:33:18 +00:00
preconditions := ScalePrecondition{-1, ""}
count := uint(3)
name := "foo"
2018-07-18 14:47:22 +00:00
err := scaler.Scale("default", name, count, &preconditions, nil, nil, schema.GroupResource{Group: "extensions", Resource: "replicasets"})
if err != nil {
t.Fatal(err)
2018-03-06 22:33:18 +00:00
}
2018-07-18 14:47:22 +00:00
actions := scaleClient.Actions()
if len(actions) != len(scaleClientExpectedAction) {
t.Errorf("unexpected actions: %v, expected %d actions got %d", actions, len(scaleClientExpectedAction), len(actions))
2018-03-06 22:33:18 +00:00
}
2018-07-18 14:47:22 +00:00
for i, verb := range scaleClientExpectedAction {
if actions[i].GetVerb() != verb {
t.Errorf("unexpected action: %+v, expected %s", actions[i].GetVerb(), verb)
}
2018-03-06 22:33:18 +00:00
}
}
func TestReplicaSetScaleRetry(t *testing.T) {
2018-07-18 14:47:22 +00:00
verbsOnError := map[string]*kerrors.StatusError{
"update": kerrors.NewConflict(api.Resource("Status"), "foo", nil),
}
scaleClientExpectedAction := []string{"get", "update", "get"}
scaleClient := createFakeScaleClient("replicasets", "foo", 2, verbsOnError)
scaler := NewScaler(scaleClient)
2018-03-06 22:33:18 +00:00
preconditions := &ScalePrecondition{-1, ""}
count := uint(3)
name := "foo"
namespace := "default"
2018-07-18 14:47:22 +00:00
scaleFunc := ScaleCondition(scaler, preconditions, namespace, name, count, nil, schema.GroupResource{Group: "extensions", Resource: "replicasets"})
2018-03-06 22:33:18 +00:00
pass, err := scaleFunc()
if pass != false {
t.Errorf("Expected an update failure to return pass = false, got pass = %v", pass)
}
if err != nil {
t.Errorf("Did not expect an error on update failure, got %v", err)
}
preconditions = &ScalePrecondition{3, ""}
2018-07-18 14:47:22 +00:00
scaleFunc = ScaleCondition(scaler, preconditions, namespace, name, count, nil, schema.GroupResource{Group: "extensions", Resource: "replicasets"})
2018-03-06 22:33:18 +00:00
pass, err = scaleFunc()
if err == nil {
t.Error("Expected error on precondition failure")
}
2018-07-18 14:47:22 +00:00
actions := scaleClient.Actions()
if len(actions) != len(scaleClientExpectedAction) {
t.Errorf("unexpected actions: %v, expected %d actions got %d", actions, len(scaleClientExpectedAction), len(actions))
}
for i, verb := range scaleClientExpectedAction {
if actions[i].GetVerb() != verb {
t.Errorf("unexpected action: %+v, expected %s", actions[i].GetVerb(), verb)
}
}
2018-03-06 22:33:18 +00:00
}
func TestReplicaSetScaleInvalid(t *testing.T) {
2018-07-18 14:47:22 +00:00
verbsOnError := map[string]*kerrors.StatusError{
"update": kerrors.NewInvalid(api.Kind("Status"), "foo", nil),
}
scaleClientExpectedAction := []string{"get", "update"}
scaleClient := createFakeScaleClient("replicasets", "foo", 2, verbsOnError)
scaler := NewScaler(scaleClient)
2018-03-06 22:33:18 +00:00
preconditions := ScalePrecondition{-1, ""}
count := uint(3)
name := "foo"
namespace := "default"
2018-07-18 14:47:22 +00:00
scaleFunc := ScaleCondition(scaler, &preconditions, namespace, name, count, nil, schema.GroupResource{Group: "extensions", Resource: "replicasets"})
2018-03-06 22:33:18 +00:00
pass, err := scaleFunc()
if pass {
t.Errorf("Expected an update failure to return pass = false, got pass = %v", pass)
}
2018-07-18 14:47:22 +00:00
if err == nil {
2018-03-06 22:33:18 +00:00
t.Errorf("Expected error on invalid update failure, got %v", err)
}
2018-07-18 14:47:22 +00:00
actions := scaleClient.Actions()
if len(actions) != len(scaleClientExpectedAction) {
t.Errorf("unexpected actions: %v, expected %d actions got %d", actions, len(scaleClientExpectedAction), len(actions))
}
for i, verb := range scaleClientExpectedAction {
if actions[i].GetVerb() != verb {
t.Errorf("unexpected action: %+v, expected %s", actions[i].GetVerb(), verb)
}
}
2018-03-06 22:33:18 +00:00
}
func TestReplicaSetsGetterFailsPreconditions(t *testing.T) {
2018-07-18 14:47:22 +00:00
scaleClientExpectedAction := []string{"get"}
scaleClient := createFakeScaleClient("replicasets", "foo", 10, nil)
scaler := NewScaler(scaleClient)
2018-03-06 22:33:18 +00:00
preconditions := ScalePrecondition{2, ""}
count := uint(3)
name := "foo"
2018-07-18 14:47:22 +00:00
err := scaler.Scale("default", name, count, &preconditions, nil, nil, schema.GroupResource{Group: "extensions", Resource: "replicasets"})
if err == nil {
t.Fatal("expected to get an error but non was returned")
2018-03-06 22:33:18 +00:00
}
2018-07-18 14:47:22 +00:00
actions := scaleClient.Actions()
if len(actions) != len(scaleClientExpectedAction) {
t.Errorf("unexpected actions: %v, expected %d actions got %d", actions, len(scaleClientExpectedAction), len(actions))
2018-03-06 22:33:18 +00:00
}
2018-07-18 14:47:22 +00:00
for i, verb := range scaleClientExpectedAction {
if actions[i].GetVerb() != verb {
t.Errorf("unexpected action: %+v, expected %s", actions[i].GetVerb(), verb)
2018-03-06 22:33:18 +00:00
}
}
}
// TestGenericScaleSimple exercises GenericScaler.ScaleSimple method
func TestGenericScaleSimple(t *testing.T) {
// test data
2018-07-18 14:47:22 +00:00
scaleClient := createFakeScaleClient("deployments", "abc", 10, nil)
2018-03-06 22:33:18 +00:00
// test scenarios
scenarios := []struct {
name string
precondition ScalePrecondition
newSize int
targetGR schema.GroupResource
resName string
scaleGetter scale.ScalesGetter
expectError bool
}{
// scenario 1: scale up the "abc" deployment
{
name: "scale up the \"abc\" deployment",
precondition: ScalePrecondition{10, ""},
newSize: 20,
2018-07-18 14:47:22 +00:00
targetGR: schema.GroupResource{Group: "apps", Resource: "deployments"},
2018-03-06 22:33:18 +00:00
resName: "abc",
scaleGetter: scaleClient,
},
// scenario 2: scale down the "abc" deployment
{
2018-07-18 14:47:22 +00:00
name: "scale down the \"abs\" deployment",
2018-03-06 22:33:18 +00:00
precondition: ScalePrecondition{20, ""},
newSize: 5,
2018-07-18 14:47:22 +00:00
targetGR: schema.GroupResource{Group: "apps", Resource: "deployments"},
2018-03-06 22:33:18 +00:00
resName: "abc",
scaleGetter: scaleClient,
},
// scenario 3: precondition error, expected size is 1,
// note that the previous scenario (2) set the size to 5
{
name: "precondition error, expected size is 1",
precondition: ScalePrecondition{1, ""},
newSize: 5,
2018-07-18 14:47:22 +00:00
targetGR: schema.GroupResource{Group: "apps", Resource: "deployments"},
2018-03-06 22:33:18 +00:00
resName: "abc",
scaleGetter: scaleClient,
expectError: true,
},
// scenario 4: precondition is not validated when the precondition size is set to -1
{
name: "precondition is not validated when the size is set to -1",
precondition: ScalePrecondition{-1, ""},
newSize: 5,
2018-07-18 14:47:22 +00:00
targetGR: schema.GroupResource{Group: "apps", Resource: "deployments"},
2018-03-06 22:33:18 +00:00
resName: "abc",
scaleGetter: scaleClient,
},
// scenario 5: precondition error, resource version mismatch
{
name: "precondition error, resource version mismatch",
precondition: ScalePrecondition{5, "v1"},
newSize: 5,
2018-07-18 14:47:22 +00:00
targetGR: schema.GroupResource{Group: "apps", Resource: "deployments"},
2018-03-06 22:33:18 +00:00
resName: "abc",
scaleGetter: scaleClient,
expectError: true,
},
}
// act
for index, scenario := range scenarios {
t.Run(fmt.Sprintf("running scenario %d: %s", index+1, scenario.name), func(t *testing.T) {
2018-07-18 14:47:22 +00:00
target := NewScaler(scenario.scaleGetter)
2018-03-06 22:33:18 +00:00
2018-07-18 14:47:22 +00:00
resVersion, err := target.ScaleSimple("default", scenario.resName, &scenario.precondition, uint(scenario.newSize), scenario.targetGR)
2018-03-06 22:33:18 +00:00
if scenario.expectError && err == nil {
t.Fatal("expected an error but was not returned")
}
if !scenario.expectError && err != nil {
t.Fatalf("unexpected error: %v", err)
}
if resVersion != "" {
t.Fatalf("unexpected resource version returned = %s, wanted = %s", resVersion, "")
}
})
}
}
// TestGenericScale exercises GenericScaler.Scale method
func TestGenericScale(t *testing.T) {
// test data
2018-07-18 14:47:22 +00:00
scaleClient := createFakeScaleClient("deployments", "abc", 10, nil)
2018-03-06 22:33:18 +00:00
// test scenarios
scenarios := []struct {
name string
precondition ScalePrecondition
newSize int
targetGR schema.GroupResource
resName string
scaleGetter scale.ScalesGetter
waitForReplicas *RetryParams
expectError bool
}{
// scenario 1: scale up the "abc" deployment
{
name: "scale up the \"abc\" deployment",
precondition: ScalePrecondition{10, ""},
newSize: 20,
2018-07-18 14:47:22 +00:00
targetGR: schema.GroupResource{Group: "apps", Resource: "deployments"},
2018-03-06 22:33:18 +00:00
resName: "abc",
scaleGetter: scaleClient,
},
2018-07-18 14:47:22 +00:00
//scenario 2: a resource name cannot be empty
2018-03-06 22:33:18 +00:00
{
name: "a resource name cannot be empty",
precondition: ScalePrecondition{10, ""},
newSize: 20,
2018-07-18 14:47:22 +00:00
targetGR: schema.GroupResource{Group: "apps", Resource: "deployments"},
2018-03-06 22:33:18 +00:00
resName: "",
scaleGetter: scaleClient,
expectError: true,
},
// scenario 3: wait for replicas error due to status.Replicas != spec.Replicas
{
name: "wait for replicas error due to status.Replicas != spec.Replicas",
precondition: ScalePrecondition{10, ""},
newSize: 20,
2018-07-18 14:47:22 +00:00
targetGR: schema.GroupResource{Group: "apps", Resource: "deployments"},
2018-03-06 22:33:18 +00:00
resName: "abc",
scaleGetter: scaleClient,
waitForReplicas: &RetryParams{time.Duration(5 * time.Second), time.Duration(5 * time.Second)},
expectError: true,
},
}
// act
2018-07-18 14:47:22 +00:00
for _, scenario := range scenarios {
t.Run(scenario.name, func(t *testing.T) {
target := NewScaler(scenario.scaleGetter)
2018-03-06 22:33:18 +00:00
2018-07-18 14:47:22 +00:00
err := target.Scale("default", scenario.resName, uint(scenario.newSize), &scenario.precondition, nil, scenario.waitForReplicas, scenario.targetGR)
2018-03-06 22:33:18 +00:00
if scenario.expectError && err == nil {
t.Fatal("expected an error but was not returned")
}
if !scenario.expectError && err != nil {
t.Fatalf("unexpected error: %v", err)
}
})
}
}
2018-07-18 14:47:22 +00:00
func createFakeScaleClient(resource string, resourceName string, replicas int, errorsOnVerb map[string]*kerrors.StatusError) *fakescale.FakeScaleClient {
shouldReturnAnError := func(verb string) (*kerrors.StatusError, bool) {
if anError, anErrorExists := errorsOnVerb[verb]; anErrorExists {
return anError, true
2018-03-06 22:33:18 +00:00
}
2018-07-18 14:47:22 +00:00
return &kerrors.StatusError{}, false
}
newReplicas := int32(replicas)
scaleClient := &fakescale.FakeScaleClient{}
scaleClient.AddReactor("get", resource, func(rawAction testcore.Action) (handled bool, ret runtime.Object, err error) {
action := rawAction.(testcore.GetAction)
if action.GetName() != resourceName {
return true, nil, fmt.Errorf("expected = %s, got = %s", resourceName, action.GetName())
2018-03-06 22:33:18 +00:00
}
2018-07-18 14:47:22 +00:00
if anError, should := shouldReturnAnError("get"); should {
return true, nil, anError
}
obj := &autoscalingv1.Scale{
ObjectMeta: metav1.ObjectMeta{
Name: action.GetName(),
Namespace: action.GetNamespace(),
},
Spec: autoscalingv1.ScaleSpec{
Replicas: newReplicas,
},
}
return true, obj, nil
})
scaleClient.AddReactor("update", resource, func(rawAction testcore.Action) (handled bool, ret runtime.Object, err error) {
action := rawAction.(testcore.UpdateAction)
obj := action.GetObject().(*autoscalingv1.Scale)
if obj.Name != resourceName {
return true, nil, fmt.Errorf("expected = %s, got = %s", resourceName, obj.Name)
}
if anError, should := shouldReturnAnError("update"); should {
return true, nil, anError
}
newReplicas = obj.Spec.Replicas
return true, &autoscalingv1.Scale{
ObjectMeta: metav1.ObjectMeta{
Name: obj.Name,
Namespace: action.GetNamespace(),
},
Spec: autoscalingv1.ScaleSpec{
Replicas: newReplicas,
},
}, nil
})
return scaleClient
2018-03-06 22:33:18 +00:00
}