2018-01-09 18:57:14 +00:00
|
|
|
/*
|
|
|
|
Copyright 2014 The Kubernetes Authors.
|
|
|
|
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
you may not use this file except in compliance with the License.
|
|
|
|
You may obtain a copy of the License at
|
|
|
|
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
See the License for the specific language governing permissions and
|
|
|
|
limitations under the License.
|
|
|
|
*/
|
|
|
|
|
|
|
|
package kubectl
|
|
|
|
|
|
|
|
import (
|
|
|
|
"fmt"
|
|
|
|
"strconv"
|
|
|
|
"time"
|
|
|
|
|
2018-03-06 22:33:18 +00:00
|
|
|
autoscalingapi "k8s.io/api/autoscaling/v1"
|
2018-01-09 18:57:14 +00:00
|
|
|
"k8s.io/apimachinery/pkg/api/errors"
|
|
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
|
|
"k8s.io/apimachinery/pkg/runtime/schema"
|
|
|
|
"k8s.io/apimachinery/pkg/util/wait"
|
|
|
|
"k8s.io/kubernetes/pkg/apis/apps"
|
|
|
|
"k8s.io/kubernetes/pkg/apis/batch"
|
|
|
|
api "k8s.io/kubernetes/pkg/apis/core"
|
|
|
|
"k8s.io/kubernetes/pkg/apis/extensions"
|
2018-03-06 22:33:18 +00:00
|
|
|
|
|
|
|
scaleclient "k8s.io/client-go/scale"
|
2018-01-09 18:57:14 +00:00
|
|
|
appsclient "k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/typed/apps/internalversion"
|
|
|
|
batchclient "k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/typed/batch/internalversion"
|
|
|
|
coreclient "k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/typed/core/internalversion"
|
|
|
|
extensionsclient "k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/typed/extensions/internalversion"
|
|
|
|
)
|
|
|
|
|
2018-03-06 22:33:18 +00:00
|
|
|
// TODO: Figure out if we should be waiting on initializers in the Scale() functions below.
|
|
|
|
|
2018-01-09 18:57:14 +00:00
|
|
|
// Scaler provides an interface for resources that can be scaled.
|
|
|
|
type Scaler interface {
|
|
|
|
// Scale scales the named resource after checking preconditions. It optionally
|
|
|
|
// retries in the event of resource version mismatch (if retry is not nil),
|
|
|
|
// and optionally waits until the status of the resource matches newSize (if wait is not nil)
|
2018-03-06 22:33:18 +00:00
|
|
|
// TODO: Make the implementation of this watch-based (#56075) once #31345 is fixed.
|
2018-01-09 18:57:14 +00:00
|
|
|
Scale(namespace, name string, newSize uint, preconditions *ScalePrecondition, retry, wait *RetryParams) error
|
|
|
|
// ScaleSimple does a simple one-shot attempt at scaling - not useful on its own, but
|
|
|
|
// a necessary building block for Scale
|
|
|
|
ScaleSimple(namespace, name string, preconditions *ScalePrecondition, newSize uint) (updatedResourceVersion string, err error)
|
|
|
|
}
|
|
|
|
|
2018-03-06 22:33:18 +00:00
|
|
|
// ScalerFor gets a scaler for a given resource
|
|
|
|
func ScalerFor(kind schema.GroupKind, jobsClient batchclient.JobsGetter, scalesGetter scaleclient.ScalesGetter, gr schema.GroupResource) Scaler {
|
|
|
|
// it seems like jobs dont't follow "normal" scale semantics.
|
|
|
|
// For example it is not clear whether HPA could make use of it or not.
|
|
|
|
// For more details see: https://github.com/kubernetes/kubernetes/pull/58468
|
2018-01-09 18:57:14 +00:00
|
|
|
switch kind {
|
|
|
|
case batch.Kind("Job"):
|
2018-03-06 22:33:18 +00:00
|
|
|
return &jobScaler{jobsClient} // Either kind of job can be scaled with Batch interface.
|
|
|
|
default:
|
|
|
|
return &genericScaler{scalesGetter, gr}
|
2018-01-09 18:57:14 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// ScalePrecondition describes a condition that must be true for the scale to take place
|
|
|
|
// If CurrentSize == -1, it is ignored.
|
|
|
|
// If CurrentResourceVersion is the empty string, it is ignored.
|
|
|
|
// Otherwise they must equal the values in the resource for it to be valid.
|
|
|
|
type ScalePrecondition struct {
|
|
|
|
Size int
|
|
|
|
ResourceVersion string
|
|
|
|
}
|
|
|
|
|
|
|
|
// A PreconditionError is returned when a resource fails to match
|
|
|
|
// the scale preconditions passed to kubectl.
|
|
|
|
type PreconditionError struct {
|
|
|
|
Precondition string
|
|
|
|
ExpectedValue string
|
|
|
|
ActualValue string
|
|
|
|
}
|
|
|
|
|
|
|
|
func (pe PreconditionError) Error() string {
|
|
|
|
return fmt.Sprintf("Expected %s to be %s, was %s", pe.Precondition, pe.ExpectedValue, pe.ActualValue)
|
|
|
|
}
|
|
|
|
|
|
|
|
type ScaleErrorType int
|
|
|
|
|
|
|
|
const (
|
|
|
|
ScaleGetFailure ScaleErrorType = iota
|
|
|
|
ScaleUpdateFailure
|
|
|
|
ScaleUpdateConflictFailure
|
|
|
|
)
|
|
|
|
|
|
|
|
// A ScaleError is returned when a scale request passes
|
|
|
|
// preconditions but fails to actually scale the controller.
|
|
|
|
type ScaleError struct {
|
|
|
|
FailureType ScaleErrorType
|
|
|
|
ResourceVersion string
|
|
|
|
ActualError error
|
|
|
|
}
|
|
|
|
|
|
|
|
func (c ScaleError) Error() string {
|
|
|
|
msg := fmt.Sprintf("Scaling the resource failed with: %v", c.ActualError)
|
|
|
|
if len(c.ResourceVersion) > 0 {
|
|
|
|
msg += fmt.Sprintf("; Current resource version %s", c.ResourceVersion)
|
|
|
|
}
|
|
|
|
return msg
|
|
|
|
}
|
|
|
|
|
|
|
|
// RetryParams encapsulates the retry parameters used by kubectl's scaler.
|
|
|
|
type RetryParams struct {
|
|
|
|
Interval, Timeout time.Duration
|
|
|
|
}
|
|
|
|
|
|
|
|
func NewRetryParams(interval, timeout time.Duration) *RetryParams {
|
|
|
|
return &RetryParams{interval, timeout}
|
|
|
|
}
|
|
|
|
|
|
|
|
// ScaleCondition is a closure around Scale that facilitates retries via util.wait
|
|
|
|
func ScaleCondition(r Scaler, precondition *ScalePrecondition, namespace, name string, count uint, updatedResourceVersion *string) wait.ConditionFunc {
|
|
|
|
return func() (bool, error) {
|
|
|
|
rv, err := r.ScaleSimple(namespace, name, precondition, count)
|
|
|
|
if updatedResourceVersion != nil {
|
|
|
|
*updatedResourceVersion = rv
|
|
|
|
}
|
|
|
|
switch e, _ := err.(ScaleError); err.(type) {
|
|
|
|
case nil:
|
|
|
|
return true, nil
|
|
|
|
case ScaleError:
|
|
|
|
// Retry only on update conflicts.
|
|
|
|
if e.FailureType == ScaleUpdateConflictFailure {
|
|
|
|
return false, nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return false, err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// ValidateStatefulSet ensures that the preconditions match. Returns nil if they are valid, an error otherwise.
|
|
|
|
func (precondition *ScalePrecondition) ValidateStatefulSet(ps *apps.StatefulSet) error {
|
|
|
|
if precondition.Size != -1 && int(ps.Spec.Replicas) != precondition.Size {
|
|
|
|
return PreconditionError{"replicas", strconv.Itoa(precondition.Size), strconv.Itoa(int(ps.Spec.Replicas))}
|
|
|
|
}
|
|
|
|
if len(precondition.ResourceVersion) != 0 && ps.ResourceVersion != precondition.ResourceVersion {
|
|
|
|
return PreconditionError{"resource version", precondition.ResourceVersion, ps.ResourceVersion}
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// ValidateReplicationController ensures that the preconditions match. Returns nil if they are valid, an error otherwise
|
|
|
|
func (precondition *ScalePrecondition) ValidateReplicationController(controller *api.ReplicationController) error {
|
|
|
|
if precondition.Size != -1 && int(controller.Spec.Replicas) != precondition.Size {
|
|
|
|
return PreconditionError{"replicas", strconv.Itoa(precondition.Size), strconv.Itoa(int(controller.Spec.Replicas))}
|
|
|
|
}
|
|
|
|
if len(precondition.ResourceVersion) != 0 && controller.ResourceVersion != precondition.ResourceVersion {
|
|
|
|
return PreconditionError{"resource version", precondition.ResourceVersion, controller.ResourceVersion}
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2018-03-06 22:33:18 +00:00
|
|
|
// TODO(p0lyn0mial): remove ReplicationControllerScaler
|
2018-01-09 18:57:14 +00:00
|
|
|
type ReplicationControllerScaler struct {
|
|
|
|
c coreclient.ReplicationControllersGetter
|
|
|
|
}
|
|
|
|
|
|
|
|
// ScaleSimple does a simple one-shot attempt at scaling. It returns the
|
|
|
|
// resourceVersion of the replication controller if the update is successful.
|
|
|
|
func (scaler *ReplicationControllerScaler) ScaleSimple(namespace, name string, preconditions *ScalePrecondition, newSize uint) (string, error) {
|
|
|
|
controller, err := scaler.c.ReplicationControllers(namespace).Get(name, metav1.GetOptions{})
|
|
|
|
if err != nil {
|
|
|
|
return "", ScaleError{ScaleGetFailure, "", err}
|
|
|
|
}
|
|
|
|
if preconditions != nil {
|
|
|
|
if err := preconditions.ValidateReplicationController(controller); err != nil {
|
|
|
|
return "", err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
controller.Spec.Replicas = int32(newSize)
|
|
|
|
updatedRC, err := scaler.c.ReplicationControllers(namespace).Update(controller)
|
|
|
|
if err != nil {
|
|
|
|
if errors.IsConflict(err) {
|
|
|
|
return "", ScaleError{ScaleUpdateConflictFailure, controller.ResourceVersion, err}
|
|
|
|
}
|
|
|
|
return "", ScaleError{ScaleUpdateFailure, controller.ResourceVersion, err}
|
|
|
|
}
|
|
|
|
return updatedRC.ObjectMeta.ResourceVersion, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// Scale updates a ReplicationController to a new size, with optional precondition check (if preconditions is not nil),
|
|
|
|
// optional retries (if retry is not nil), and then optionally waits for it's replica count to reach the new value
|
|
|
|
// (if wait is not nil).
|
|
|
|
func (scaler *ReplicationControllerScaler) Scale(namespace, name string, newSize uint, preconditions *ScalePrecondition, retry, waitForReplicas *RetryParams) error {
|
|
|
|
if preconditions == nil {
|
|
|
|
preconditions = &ScalePrecondition{-1, ""}
|
|
|
|
}
|
|
|
|
if retry == nil {
|
|
|
|
// Make it try only once, immediately
|
|
|
|
retry = &RetryParams{Interval: time.Millisecond, Timeout: time.Millisecond}
|
|
|
|
}
|
2018-03-06 22:33:18 +00:00
|
|
|
cond := ScaleCondition(scaler, preconditions, namespace, name, newSize, nil)
|
2018-01-09 18:57:14 +00:00
|
|
|
if err := wait.PollImmediate(retry.Interval, retry.Timeout, cond); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
if waitForReplicas != nil {
|
2018-03-06 22:33:18 +00:00
|
|
|
rc, err := scaler.c.ReplicationControllers(namespace).Get(name, metav1.GetOptions{})
|
2018-01-09 18:57:14 +00:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
2018-03-06 22:33:18 +00:00
|
|
|
if rc.Initializers != nil {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
err = wait.PollImmediate(waitForReplicas.Interval, waitForReplicas.Timeout, ControllerHasDesiredReplicas(scaler.c, rc))
|
|
|
|
if err == wait.ErrWaitTimeout {
|
|
|
|
return fmt.Errorf("timed out waiting for %q to be synced", name)
|
2018-01-09 18:57:14 +00:00
|
|
|
}
|
2018-03-06 22:33:18 +00:00
|
|
|
return err
|
2018-01-09 18:57:14 +00:00
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// ValidateReplicaSet ensures that the preconditions match. Returns nil if they are valid, an error otherwise
|
|
|
|
func (precondition *ScalePrecondition) ValidateReplicaSet(replicaSet *extensions.ReplicaSet) error {
|
|
|
|
if precondition.Size != -1 && int(replicaSet.Spec.Replicas) != precondition.Size {
|
|
|
|
return PreconditionError{"replicas", strconv.Itoa(precondition.Size), strconv.Itoa(int(replicaSet.Spec.Replicas))}
|
|
|
|
}
|
|
|
|
if len(precondition.ResourceVersion) != 0 && replicaSet.ResourceVersion != precondition.ResourceVersion {
|
|
|
|
return PreconditionError{"resource version", precondition.ResourceVersion, replicaSet.ResourceVersion}
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2018-03-06 22:33:18 +00:00
|
|
|
// TODO(p0lyn0mial): remove ReplicaSetScaler
|
2018-01-09 18:57:14 +00:00
|
|
|
type ReplicaSetScaler struct {
|
|
|
|
c extensionsclient.ReplicaSetsGetter
|
|
|
|
}
|
|
|
|
|
|
|
|
// ScaleSimple does a simple one-shot attempt at scaling. It returns the
|
|
|
|
// resourceVersion of the replicaset if the update is successful.
|
|
|
|
func (scaler *ReplicaSetScaler) ScaleSimple(namespace, name string, preconditions *ScalePrecondition, newSize uint) (string, error) {
|
|
|
|
rs, err := scaler.c.ReplicaSets(namespace).Get(name, metav1.GetOptions{})
|
|
|
|
if err != nil {
|
|
|
|
return "", ScaleError{ScaleGetFailure, "", err}
|
|
|
|
}
|
|
|
|
if preconditions != nil {
|
|
|
|
if err := preconditions.ValidateReplicaSet(rs); err != nil {
|
|
|
|
return "", err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
rs.Spec.Replicas = int32(newSize)
|
|
|
|
updatedRS, err := scaler.c.ReplicaSets(namespace).Update(rs)
|
|
|
|
if err != nil {
|
|
|
|
if errors.IsConflict(err) {
|
|
|
|
return "", ScaleError{ScaleUpdateConflictFailure, rs.ResourceVersion, err}
|
|
|
|
}
|
|
|
|
return "", ScaleError{ScaleUpdateFailure, rs.ResourceVersion, err}
|
|
|
|
}
|
|
|
|
return updatedRS.ObjectMeta.ResourceVersion, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// Scale updates a ReplicaSet to a new size, with optional precondition check (if preconditions is
|
|
|
|
// not nil), optional retries (if retry is not nil), and then optionally waits for it's replica
|
|
|
|
// count to reach the new value (if wait is not nil).
|
|
|
|
func (scaler *ReplicaSetScaler) Scale(namespace, name string, newSize uint, preconditions *ScalePrecondition, retry, waitForReplicas *RetryParams) error {
|
|
|
|
if preconditions == nil {
|
|
|
|
preconditions = &ScalePrecondition{-1, ""}
|
|
|
|
}
|
|
|
|
if retry == nil {
|
|
|
|
// Make it try only once, immediately
|
|
|
|
retry = &RetryParams{Interval: time.Millisecond, Timeout: time.Millisecond}
|
|
|
|
}
|
|
|
|
cond := ScaleCondition(scaler, preconditions, namespace, name, newSize, nil)
|
2018-03-06 22:33:18 +00:00
|
|
|
if err := wait.PollImmediate(retry.Interval, retry.Timeout, cond); err != nil {
|
2018-01-09 18:57:14 +00:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
if waitForReplicas != nil {
|
|
|
|
rs, err := scaler.c.ReplicaSets(namespace).Get(name, metav1.GetOptions{})
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
if rs.Initializers != nil {
|
|
|
|
return nil
|
|
|
|
}
|
2018-03-06 22:33:18 +00:00
|
|
|
err = wait.PollImmediate(waitForReplicas.Interval, waitForReplicas.Timeout, ReplicaSetHasDesiredReplicas(scaler.c, rs))
|
2018-01-09 18:57:14 +00:00
|
|
|
|
|
|
|
if err == wait.ErrWaitTimeout {
|
|
|
|
return fmt.Errorf("timed out waiting for %q to be synced", name)
|
|
|
|
}
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// ValidateJob ensures that the preconditions match. Returns nil if they are valid, an error otherwise.
|
|
|
|
func (precondition *ScalePrecondition) ValidateJob(job *batch.Job) error {
|
|
|
|
if precondition.Size != -1 && job.Spec.Parallelism == nil {
|
|
|
|
return PreconditionError{"parallelism", strconv.Itoa(precondition.Size), "nil"}
|
|
|
|
}
|
|
|
|
if precondition.Size != -1 && int(*job.Spec.Parallelism) != precondition.Size {
|
|
|
|
return PreconditionError{"parallelism", strconv.Itoa(precondition.Size), strconv.Itoa(int(*job.Spec.Parallelism))}
|
|
|
|
}
|
|
|
|
if len(precondition.ResourceVersion) != 0 && job.ResourceVersion != precondition.ResourceVersion {
|
|
|
|
return PreconditionError{"resource version", precondition.ResourceVersion, job.ResourceVersion}
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2018-03-06 22:33:18 +00:00
|
|
|
// TODO(p0lyn0mial): remove StatefulSetsGetter
|
2018-01-09 18:57:14 +00:00
|
|
|
type StatefulSetScaler struct {
|
|
|
|
c appsclient.StatefulSetsGetter
|
|
|
|
}
|
|
|
|
|
|
|
|
// ScaleSimple does a simple one-shot attempt at scaling. It returns the
|
|
|
|
// resourceVersion of the statefulset if the update is successful.
|
|
|
|
func (scaler *StatefulSetScaler) ScaleSimple(namespace, name string, preconditions *ScalePrecondition, newSize uint) (string, error) {
|
|
|
|
ss, err := scaler.c.StatefulSets(namespace).Get(name, metav1.GetOptions{})
|
|
|
|
if err != nil {
|
|
|
|
return "", ScaleError{ScaleGetFailure, "", err}
|
|
|
|
}
|
|
|
|
if preconditions != nil {
|
|
|
|
if err := preconditions.ValidateStatefulSet(ss); err != nil {
|
|
|
|
return "", err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
ss.Spec.Replicas = int32(newSize)
|
|
|
|
updatedStatefulSet, err := scaler.c.StatefulSets(namespace).Update(ss)
|
|
|
|
if err != nil {
|
|
|
|
if errors.IsConflict(err) {
|
|
|
|
return "", ScaleError{ScaleUpdateConflictFailure, ss.ResourceVersion, err}
|
|
|
|
}
|
|
|
|
return "", ScaleError{ScaleUpdateFailure, ss.ResourceVersion, err}
|
|
|
|
}
|
|
|
|
return updatedStatefulSet.ResourceVersion, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (scaler *StatefulSetScaler) Scale(namespace, name string, newSize uint, preconditions *ScalePrecondition, retry, waitForReplicas *RetryParams) error {
|
|
|
|
if preconditions == nil {
|
|
|
|
preconditions = &ScalePrecondition{-1, ""}
|
|
|
|
}
|
|
|
|
if retry == nil {
|
|
|
|
// Make it try only once, immediately
|
|
|
|
retry = &RetryParams{Interval: time.Millisecond, Timeout: time.Millisecond}
|
|
|
|
}
|
|
|
|
cond := ScaleCondition(scaler, preconditions, namespace, name, newSize, nil)
|
2018-03-06 22:33:18 +00:00
|
|
|
if err := wait.PollImmediate(retry.Interval, retry.Timeout, cond); err != nil {
|
2018-01-09 18:57:14 +00:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
if waitForReplicas != nil {
|
|
|
|
job, err := scaler.c.StatefulSets(namespace).Get(name, metav1.GetOptions{})
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
if job.Initializers != nil {
|
|
|
|
return nil
|
|
|
|
}
|
2018-03-06 22:33:18 +00:00
|
|
|
err = wait.PollImmediate(waitForReplicas.Interval, waitForReplicas.Timeout, StatefulSetHasDesiredReplicas(scaler.c, job))
|
2018-01-09 18:57:14 +00:00
|
|
|
if err == wait.ErrWaitTimeout {
|
|
|
|
return fmt.Errorf("timed out waiting for %q to be synced", name)
|
|
|
|
}
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2018-03-06 22:33:18 +00:00
|
|
|
type jobScaler struct {
|
2018-01-09 18:57:14 +00:00
|
|
|
c batchclient.JobsGetter
|
|
|
|
}
|
|
|
|
|
|
|
|
// ScaleSimple is responsible for updating job's parallelism. It returns the
|
|
|
|
// resourceVersion of the job if the update is successful.
|
2018-03-06 22:33:18 +00:00
|
|
|
func (scaler *jobScaler) ScaleSimple(namespace, name string, preconditions *ScalePrecondition, newSize uint) (string, error) {
|
2018-01-09 18:57:14 +00:00
|
|
|
job, err := scaler.c.Jobs(namespace).Get(name, metav1.GetOptions{})
|
|
|
|
if err != nil {
|
|
|
|
return "", ScaleError{ScaleGetFailure, "", err}
|
|
|
|
}
|
|
|
|
if preconditions != nil {
|
|
|
|
if err := preconditions.ValidateJob(job); err != nil {
|
|
|
|
return "", err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
parallelism := int32(newSize)
|
|
|
|
job.Spec.Parallelism = ¶llelism
|
|
|
|
updatedJob, err := scaler.c.Jobs(namespace).Update(job)
|
|
|
|
if err != nil {
|
|
|
|
if errors.IsConflict(err) {
|
|
|
|
return "", ScaleError{ScaleUpdateConflictFailure, job.ResourceVersion, err}
|
|
|
|
}
|
|
|
|
return "", ScaleError{ScaleUpdateFailure, job.ResourceVersion, err}
|
|
|
|
}
|
|
|
|
return updatedJob.ObjectMeta.ResourceVersion, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// Scale updates a Job to a new size, with optional precondition check (if preconditions is not nil),
|
|
|
|
// optional retries (if retry is not nil), and then optionally waits for parallelism to reach desired
|
|
|
|
// number, which can be less than requested based on job's current progress.
|
2018-03-06 22:33:18 +00:00
|
|
|
func (scaler *jobScaler) Scale(namespace, name string, newSize uint, preconditions *ScalePrecondition, retry, waitForReplicas *RetryParams) error {
|
2018-01-09 18:57:14 +00:00
|
|
|
if preconditions == nil {
|
|
|
|
preconditions = &ScalePrecondition{-1, ""}
|
|
|
|
}
|
|
|
|
if retry == nil {
|
|
|
|
// Make it try only once, immediately
|
|
|
|
retry = &RetryParams{Interval: time.Millisecond, Timeout: time.Millisecond}
|
|
|
|
}
|
|
|
|
cond := ScaleCondition(scaler, preconditions, namespace, name, newSize, nil)
|
2018-03-06 22:33:18 +00:00
|
|
|
if err := wait.PollImmediate(retry.Interval, retry.Timeout, cond); err != nil {
|
2018-01-09 18:57:14 +00:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
if waitForReplicas != nil {
|
|
|
|
job, err := scaler.c.Jobs(namespace).Get(name, metav1.GetOptions{})
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
2018-03-06 22:33:18 +00:00
|
|
|
err = wait.PollImmediate(waitForReplicas.Interval, waitForReplicas.Timeout, JobHasDesiredParallelism(scaler.c, job))
|
2018-01-09 18:57:14 +00:00
|
|
|
if err == wait.ErrWaitTimeout {
|
|
|
|
return fmt.Errorf("timed out waiting for %q to be synced", name)
|
|
|
|
}
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// ValidateDeployment ensures that the preconditions match. Returns nil if they are valid, an error otherwise.
|
|
|
|
func (precondition *ScalePrecondition) ValidateDeployment(deployment *extensions.Deployment) error {
|
|
|
|
if precondition.Size != -1 && int(deployment.Spec.Replicas) != precondition.Size {
|
|
|
|
return PreconditionError{"replicas", strconv.Itoa(precondition.Size), strconv.Itoa(int(deployment.Spec.Replicas))}
|
|
|
|
}
|
|
|
|
if len(precondition.ResourceVersion) != 0 && deployment.ResourceVersion != precondition.ResourceVersion {
|
|
|
|
return PreconditionError{"resource version", precondition.ResourceVersion, deployment.ResourceVersion}
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2018-03-06 22:33:18 +00:00
|
|
|
// TODO(p0lyn0mial): remove DeploymentScaler
|
2018-01-09 18:57:14 +00:00
|
|
|
type DeploymentScaler struct {
|
|
|
|
c extensionsclient.DeploymentsGetter
|
|
|
|
}
|
|
|
|
|
|
|
|
// ScaleSimple is responsible for updating a deployment's desired replicas
|
|
|
|
// count. It returns the resourceVersion of the deployment if the update is
|
|
|
|
// successful.
|
|
|
|
func (scaler *DeploymentScaler) ScaleSimple(namespace, name string, preconditions *ScalePrecondition, newSize uint) (string, error) {
|
|
|
|
deployment, err := scaler.c.Deployments(namespace).Get(name, metav1.GetOptions{})
|
|
|
|
if err != nil {
|
|
|
|
return "", ScaleError{ScaleGetFailure, "", err}
|
|
|
|
}
|
|
|
|
if preconditions != nil {
|
|
|
|
if err := preconditions.ValidateDeployment(deployment); err != nil {
|
|
|
|
return "", err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// TODO(madhusudancs): Fix this when Scale group issues are resolved (see issue #18528).
|
|
|
|
// For now I'm falling back to regular Deployment update operation.
|
|
|
|
deployment.Spec.Replicas = int32(newSize)
|
|
|
|
updatedDeployment, err := scaler.c.Deployments(namespace).Update(deployment)
|
|
|
|
if err != nil {
|
|
|
|
if errors.IsConflict(err) {
|
|
|
|
return "", ScaleError{ScaleUpdateConflictFailure, deployment.ResourceVersion, err}
|
|
|
|
}
|
|
|
|
return "", ScaleError{ScaleUpdateFailure, deployment.ResourceVersion, err}
|
|
|
|
}
|
|
|
|
return updatedDeployment.ObjectMeta.ResourceVersion, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// Scale updates a deployment to a new size, with optional precondition check (if preconditions is not nil),
|
|
|
|
// optional retries (if retry is not nil), and then optionally waits for the status to reach desired count.
|
|
|
|
func (scaler *DeploymentScaler) Scale(namespace, name string, newSize uint, preconditions *ScalePrecondition, retry, waitForReplicas *RetryParams) error {
|
|
|
|
if preconditions == nil {
|
|
|
|
preconditions = &ScalePrecondition{-1, ""}
|
|
|
|
}
|
|
|
|
if retry == nil {
|
|
|
|
// Make it try only once, immediately
|
|
|
|
retry = &RetryParams{Interval: time.Millisecond, Timeout: time.Millisecond}
|
|
|
|
}
|
|
|
|
cond := ScaleCondition(scaler, preconditions, namespace, name, newSize, nil)
|
2018-03-06 22:33:18 +00:00
|
|
|
if err := wait.PollImmediate(retry.Interval, retry.Timeout, cond); err != nil {
|
2018-01-09 18:57:14 +00:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
if waitForReplicas != nil {
|
|
|
|
deployment, err := scaler.c.Deployments(namespace).Get(name, metav1.GetOptions{})
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
2018-03-06 22:33:18 +00:00
|
|
|
err = wait.PollImmediate(waitForReplicas.Interval, waitForReplicas.Timeout, DeploymentHasDesiredReplicas(scaler.c, deployment))
|
2018-01-09 18:57:14 +00:00
|
|
|
if err == wait.ErrWaitTimeout {
|
|
|
|
return fmt.Errorf("timed out waiting for %q to be synced", name)
|
|
|
|
}
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
2018-03-06 22:33:18 +00:00
|
|
|
|
|
|
|
// validateGeneric ensures that the preconditions match. Returns nil if they are valid, otherwise an error
|
|
|
|
// TODO(p0lyn0mial): when the work on GenericScaler is done, rename validateGeneric to validate
|
|
|
|
func (precondition *ScalePrecondition) validateGeneric(scale *autoscalingapi.Scale) error {
|
|
|
|
if precondition.Size != -1 && int(scale.Spec.Replicas) != precondition.Size {
|
|
|
|
return PreconditionError{"replicas", strconv.Itoa(precondition.Size), strconv.Itoa(int(scale.Spec.Replicas))}
|
|
|
|
}
|
|
|
|
if len(precondition.ResourceVersion) > 0 && scale.ResourceVersion != precondition.ResourceVersion {
|
|
|
|
return PreconditionError{"resource version", precondition.ResourceVersion, scale.ResourceVersion}
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// genericScaler can update scales for resources in a particular namespace
|
|
|
|
type genericScaler struct {
|
|
|
|
scaleNamespacer scaleclient.ScalesGetter
|
|
|
|
targetGR schema.GroupResource
|
|
|
|
}
|
|
|
|
|
|
|
|
var _ Scaler = &genericScaler{}
|
|
|
|
|
|
|
|
// ScaleSimple updates a scale of a given resource. It returns the resourceVersion of the scale if the update was successful.
|
|
|
|
func (s *genericScaler) ScaleSimple(namespace, name string, preconditions *ScalePrecondition, newSize uint) (updatedResourceVersion string, err error) {
|
|
|
|
scale, err := s.scaleNamespacer.Scales(namespace).Get(s.targetGR, name)
|
|
|
|
if err != nil {
|
|
|
|
return "", ScaleError{ScaleGetFailure, "", err}
|
|
|
|
}
|
|
|
|
if preconditions != nil {
|
|
|
|
if err := preconditions.validateGeneric(scale); err != nil {
|
|
|
|
return "", err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
scale.Spec.Replicas = int32(newSize)
|
|
|
|
updatedScale, err := s.scaleNamespacer.Scales(namespace).Update(s.targetGR, scale)
|
|
|
|
if err != nil {
|
|
|
|
if errors.IsConflict(err) {
|
|
|
|
return "", ScaleError{ScaleUpdateConflictFailure, scale.ResourceVersion, err}
|
|
|
|
}
|
|
|
|
return "", ScaleError{ScaleUpdateFailure, scale.ResourceVersion, err}
|
|
|
|
}
|
|
|
|
return updatedScale.ResourceVersion, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// Scale updates a scale of a given resource to a new size, with optional precondition check (if preconditions is not nil),
|
|
|
|
// optional retries (if retry is not nil), and then optionally waits for the status to reach desired count.
|
|
|
|
func (s *genericScaler) Scale(namespace, resourceName string, newSize uint, preconditions *ScalePrecondition, retry, waitForReplicas *RetryParams) error {
|
|
|
|
if preconditions == nil {
|
|
|
|
preconditions = &ScalePrecondition{-1, ""}
|
|
|
|
}
|
|
|
|
if retry == nil {
|
|
|
|
// make it try only once, immediately
|
|
|
|
retry = &RetryParams{Interval: time.Millisecond, Timeout: time.Millisecond}
|
|
|
|
}
|
|
|
|
cond := ScaleCondition(s, preconditions, namespace, resourceName, newSize, nil)
|
|
|
|
if err := wait.PollImmediate(retry.Interval, retry.Timeout, cond); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
if waitForReplicas != nil {
|
|
|
|
err := wait.PollImmediate(
|
|
|
|
waitForReplicas.Interval,
|
|
|
|
waitForReplicas.Timeout,
|
|
|
|
scaleHasDesiredReplicas(s.scaleNamespacer, s.targetGR, resourceName, namespace, int32(newSize)))
|
|
|
|
if err == wait.ErrWaitTimeout {
|
|
|
|
return fmt.Errorf("timed out waiting for %q to be synced", resourceName)
|
|
|
|
}
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// scaleHasDesiredReplicas returns a condition that will be true if and only if the desired replica
|
|
|
|
// count for a scale (Spec) equals its updated replicas count (Status)
|
|
|
|
func scaleHasDesiredReplicas(sClient scaleclient.ScalesGetter, gr schema.GroupResource, resourceName string, namespace string, desiredReplicas int32) wait.ConditionFunc {
|
|
|
|
return func() (bool, error) {
|
|
|
|
actualScale, err := sClient.Scales(namespace).Get(gr, resourceName)
|
|
|
|
if err != nil {
|
|
|
|
return false, err
|
|
|
|
}
|
|
|
|
// this means the desired scale target has been reset by something else
|
|
|
|
if actualScale.Spec.Replicas != desiredReplicas {
|
|
|
|
return true, nil
|
|
|
|
}
|
|
|
|
return actualScale.Spec.Replicas == actualScale.Status.Replicas &&
|
|
|
|
desiredReplicas == actualScale.Status.Replicas, nil
|
|
|
|
}
|
|
|
|
}
|