mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2024-11-22 14:20:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

util: returns actual error instead of ErrPoolNotFound

Browse Source 
This commit returns actual error returned by the go-ceph API
to the function GetPoolName(..) instead of just returning
ErrPoolNotFound everytime there is error getting the pool id.
There is a issue reported in which the snapshot creation
takes much more time to reach True state
(i.e., between 2-7 mins) and keeps trying to create with
below error though pool is present:
rpc error: code = NotFound desc = pool not found: pool ID (21)
not found in Ceph cluster.

Since we cannot interpret the actual error for the delay in
snapshot creation, it is required to return the actual error
as well so that we can uderstand the reason.

Signed-off-by: Yati Padia <ypadia@redhat.com>
This commit is contained in:
Yati Padia 2021-06-14 16:10:57 +05:30 committed by mergify[bot]
parent 5b7b5f1e3a
commit 095a82f37d
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
internal/util/cephcmds.go
View File

@ -92,9 +92,11 @@ func GetPoolName(monitors string, cr *Credentials, poolID int64) (string, error)
defer connPool.Put(conn) defer connPool.Put(conn)
name, err := conn.GetPoolByID(poolID) name, err := conn.GetPoolByID(poolID)
if err != nil { if errors.Is(err, rados.ErrNotFound) {
return "", fmt.Errorf("%w: pool ID (%d) not found in Ceph cluster", return "", fmt.Errorf("%w: pool ID(%d) not found in Ceph cluster",
ErrPoolNotFound, poolID) ErrPoolNotFound, poolID)
} else if err != nil {
return "", fmt.Errorf("failed to get pool ID %d: %w", poolID, err)
} }
return name, nil return name, nil
} }