mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2024-11-17 20:00:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup: rename newVolumeOptionsFromVersion1Context for more clarity

Browse Source 
rename newVolumeOptionsFromVersion1Context to newVolumeOptionsFromMonitorList
to provide more clarity to the function readers and also fixed comments.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
This commit is contained in:
Madhu Rajanna 2020-07-12 10:25:14 +05:30 committed by mergify[bot]
parent d15ded88f5
commit 09ffaee7c3
2 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
internal/cephfs/nodeserver.go
View File

@ -94,7 +94,7 @@ func (ns *NodeServer) NodeStageVolume(ctx context.Context, req *csi.NodeStageVol
return nil, status.Error(codes.Internal, err.Error()) return nil, status.Error(codes.Internal, err.Error())
} }
// check for pre-provisioned volumes (plugin versions > 1.0.0) // gets mon IPs from the supplied cluster info
volOptions, _, err = newVolumeOptionsFromStaticVolume(string(volID), req.GetVolumeContext()) volOptions, _, err = newVolumeOptionsFromStaticVolume(string(volID), req.GetVolumeContext())
if err != nil { if err != nil {
var ensv ErrNonStaticVolume var ensv ErrNonStaticVolume
@ -102,8 +102,8 @@ func (ns *NodeServer) NodeStageVolume(ctx context.Context, req *csi.NodeStageVol
return nil, status.Error(codes.Internal, err.Error()) return nil, status.Error(codes.Internal, err.Error())
} }
// check for volumes from plugin versions <= 1.0.0 // get mon IPs from the volume context
volOptions, _, err = newVolumeOptionsFromVersion1Context(string(volID), req.GetVolumeContext(), volOptions, _, err = newVolumeOptionsFromMonitorList(string(volID), req.GetVolumeContext(),
req.GetSecrets()) req.GetSecrets())
if err != nil { if err != nil {
return nil, status.Error(codes.Internal, err.Error()) return nil, status.Error(codes.Internal, err.Error())

9
internal/cephfs/volumeoptions.go
View File

@ -307,10 +307,9 @@ func newVolumeOptionsFromVolID(ctx context.Context, volID string, volOpt, secret
return &volOptions, &vid, nil return &volOptions, &vid, nil
} }
// newVolumeOptionsFromVersion1Context generates a new instance of volumeOptions and // newVolumeOptionsFromMonitorList generates a new instance of volumeOptions and
// volumeIdentifier from the provided CSI volume context, if the provided context was // volumeIdentifier from the provided CSI volume context
// for a volume created by version 1.0.0 (or prior) of the CSI plugin func newVolumeOptionsFromMonitorList(volID string, options, secrets map[string]string) (*volumeOptions, *volumeIdentifier, error) {
func newVolumeOptionsFromVersion1Context(volID string, options, secrets map[string]string) (*volumeOptions, *volumeIdentifier, error) {
var ( var (
opts volumeOptions opts volumeOptions
vid volumeIdentifier vid volumeIdentifier
@ -318,7 +317,7 @@ func newVolumeOptionsFromVersion1Context(volID string, options, secrets map[stri
err error err error
) )
// Check if monitors is part of the options, that is an indicator this is an 1.0.0 volume // Check if monitors is part of the options
if err = extractOption(&opts.Monitors, "monitors", options); err != nil { if err = extractOption(&opts.Monitors, "monitors", options); err != nil {
return nil, nil, err return nil, nil, err
} }