From 0c6d8fbd80e34dc2a70b3bf983cfc3bacc09c5a9 Mon Sep 17 00:00:00 2001 From: Prasanna Kumar Kalever Date: Wed, 23 Sep 2020 13:59:17 +0530 Subject: [PATCH] deploy: let the pool/fs name be required Obviously expecting a pool with name `rbd` or CephFS name `myfs` will be a limitation, as the pool/fs is created by admin manually, let them choose the name that suits their requirement and come back edit it in the storage class. Making the pool/fs name as required field will give more attention, else with new users it will be mostly left unedited until one hit the errors saying no pool/fs exists. This patch clips-off the default pool/fs name and make it a mandatory field. Signed-off-by: Prasanna Kumar Kalever --- examples/cephfs/storageclass.yaml | 7 ++++--- examples/rbd/storageclass.yaml | 12 ++++++++---- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/examples/cephfs/storageclass.yaml b/examples/cephfs/storageclass.yaml index 965c8ce8e..782fa48e2 100644 --- a/examples/cephfs/storageclass.yaml +++ b/examples/cephfs/storageclass.yaml @@ -14,11 +14,12 @@ parameters: # represent the Ceph cluster in clusterID below clusterID: - # CephFS filesystem name into which the volume shall be created - fsName: myfs + # (required) CephFS filesystem name into which the volume shall be created + # eg: fsName: myfs + fsName: # (optional) Ceph pool into which volume data shall be stored - # pool: cephfs_data + # pool: # (optional) Comma separated string of Ceph-fuse mount options. # For eg: diff --git a/examples/rbd/storageclass.yaml b/examples/rbd/storageclass.yaml index 76a7573ef..9baf7e8f3 100644 --- a/examples/rbd/storageclass.yaml +++ b/examples/rbd/storageclass.yaml @@ -17,13 +17,17 @@ parameters: # csi-config-map-sample.yaml, to accompany the string chosen to # represent the Ceph cluster in clusterID below clusterID: - # If you want to use erasure coded pool with RBD, you need to create - # two pools. one erasure coded and one replicated. + + # (optional) If you want to use erasure coded pool with RBD, you need to + # create two pools. one erasure coded and one replicated. # You need to specify the replicated pool here in the `pool` parameter, it is # used for the metadata of the images. # The erasure coded pool must be set as the `dataPool` parameter below. - # dataPool: ec-data-pool - pool: rbd + # dataPool: + + # (required) Ceph pool into which the RBD image shall be created + # eg: pool: rbdpool + pool: # RBD image features, CSI creates image with image-format 2 # CSI RBD currently supports only `layering` feature.