mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2024-11-22 22:30:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

util: log error when closing temp fail fails in GetOMapValue()

Browse Source 
gosec-2.3.0 complains about the following:

    [/go/src/github.com/ceph/ceph-csi/internal/util/cephcmds.go:146] - G307 (CWE-): Deferring unsafe method "*os.File" on type "Close" (Confidence: HIGH, Severity: MEDIUM)
      > defer tmpFile.Close()

By logging the error from Close(), the warning is gone.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
This commit is contained in:
Niels de Vos 2020-06-30 11:31:47 +02:00 committed by mergify[bot]
parent 21bd26ebc4
commit 16c4e33b09
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
internal/util/cephcmds.go
View File

@ -142,7 +142,12 @@ func GetOMapValue(ctx context.Context, monitors string, cr *Credentials, poolNam
klog.Errorf(Log(ctx, "failed creating a temporary file for key contents")) klog.Errorf(Log(ctx, "failed creating a temporary file for key contents"))
return "", err return "", err
} }
defer tmpFile.Close() defer func() {
ce := tmpFile.Close()
if ce != nil {
klog.Warningf(Log(ctx, "failed closing temporary file: %s"), ce)
}
}()
defer os.Remove(tmpFile.Name()) defer os.Remove(tmpFile.Name())
args := []string{ args := []string{