mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2024-09-19 15:09:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup: do not panic on invalid drivername

Browse Source 
When the cephcsi executable receives an error when calling
util.ValidateDriverName(), it panics due to klog.Fatalln(). The error
that util.ValidateDriverName() returns should be understandable enough,
so that users know what to investigate. A Go panic on a user error is
not very userfriendly, and does not provide any additional usefil
information.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
This commit is contained in:
Niels de Vos 2020-10-26 14:18:48 +01:00 committed by mergify[bot]
parent 79e91fa894
commit 23817c1a83
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/cephcsi.go
View File

@ -129,7 +129,7 @@ func main() {
dname := getDriverName() dname := getDriverName()
err := util.ValidateDriverName(dname) err := util.ValidateDriverName(dname)
if err != nil { if err != nil {
klog.Fatalln(err) // calls exit logAndExit(err.Error())
} }
// the driver may need a higher PID limit for handling all concurrent requests // the driver may need a higher PID limit for handling all concurrent requests