mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2025-01-05 19:49:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

cephfs: remove extraneous creation of credentials

Browse Source 
`ControllerExpandVolume` creates the credentials from
secrets but never actually uses it for anything.

The secrets map is passed on to `NewVolumeOptionsFromVolID`
which does the same check again. This patch removes the
extraneous step.

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
This commit is contained in:
Niraj Yadav 2024-11-27 15:33:07 +05:30 committed by mergify[bot]
parent b6031dad48
commit 2801f153d2
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
internal/cephfs/controllerserver.go
View File

@ -717,12 +717,6 @@ func (cs *ControllerServer) ControllerExpandVolume(
}
defer cs.OperationLocks.ReleaseExpandLock(volID)
cr, err := util.NewAdminCredentials(secret)
if err != nil {
return nil, status.Error(codes.InvalidArgument, err.Error())
}
defer cr.DeleteCredentials()
volOptions, volIdentifier, err := store.NewVolumeOptionsFromVolID(ctx, volID, nil, secret,
cs.ClusterName, cs.SetMetadata)
if err != nil {