diff --git a/e2e/rbd.go b/e2e/rbd.go index 40edbce7b..29a75ba82 100644 --- a/e2e/rbd.go +++ b/e2e/rbd.go @@ -182,7 +182,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to create configmap with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -330,7 +330,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, map[string]string{"csi.storage.k8s.io/fstype": "ext4"}, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, map[string]string{"csi.storage.k8s.io/fstype": "ext4"}, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -344,7 +344,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -355,7 +355,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, map[string]string{"mounter": "rbd-nbd"}, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, map[string]string{"mounter": "rbd-nbd"}, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -369,7 +369,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -381,7 +381,7 @@ var _ = Describe("RBD", func() { e2elog.Failf("failed to delete storageclass with error %v", err) } // Storage class with rbd-nbd mounter - err = createRBDStorageClass(f.ClientSet, f, nil, map[string]string{"mounter": "rbd-nbd"}, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, map[string]string{"mounter": "rbd-nbd"}, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -455,7 +455,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -471,7 +471,7 @@ var _ = Describe("RBD", func() { "mounter": "rbd-nbd", "mapOptions": "try-netlink,reattach-timeout=180", } - err = createRBDStorageClass(f.ClientSet, f, nil, scOpts, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, scOpts, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -588,7 +588,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -599,7 +599,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, map[string]string{"encrypted": "true"}, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, map[string]string{"encrypted": "true"}, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -613,7 +613,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -628,7 +628,7 @@ var _ = Describe("RBD", func() { "encrypted": "true", "encryptionKMSID": "vault-test", } - err = createRBDStorageClass(f.ClientSet, f, nil, scOpts, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, scOpts, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -642,7 +642,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -657,7 +657,7 @@ var _ = Describe("RBD", func() { "encrypted": "true", "encryptionKMSID": "vault-tokens-test", } - err = createRBDStorageClass(f.ClientSet, f, nil, scOpts, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, scOpts, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -692,7 +692,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -707,7 +707,7 @@ var _ = Describe("RBD", func() { "encrypted": "true", "encryptionKMSID": "secrets-metadata-test", } - err = createRBDStorageClass(f.ClientSet, f, nil, scOpts, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, scOpts, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -721,7 +721,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -732,7 +732,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, map[string]string{"imageFeatures": "layering,journaling,exclusive-lock", "mounter": "rbd-nbd"}, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, map[string]string{"imageFeatures": "layering,journaling,exclusive-lock", "mounter": "rbd-nbd"}, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -744,7 +744,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -777,7 +777,7 @@ var _ = Describe("RBD", func() { "encrypted": "true", "encryptionKMSID": "vault-test", } - err = createRBDStorageClass(f.ClientSet, f, nil, scOpts, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, scOpts, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -788,7 +788,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -807,7 +807,7 @@ var _ = Describe("RBD", func() { "encrypted": "true", "encryptionKMSID": "secrets-metadata-test", } - err = createRBDStorageClass(f.ClientSet, f, nil, scOpts, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, scOpts, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -818,7 +818,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -899,7 +899,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, map[string]string{"csi.storage.k8s.io/fstype": "xfs"}, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, map[string]string{"csi.storage.k8s.io/fstype": "xfs"}, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -969,7 +969,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, map[string]string{"volumeNamePrefix": volumeNamePrefix}, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, map[string]string{"volumeNamePrefix": volumeNamePrefix}, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -1012,7 +1012,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -1069,7 +1069,7 @@ var _ = Describe("RBD", func() { topologyConstraint := "[{\"poolName\":\"" + rbdTopologyPool + "\",\"domainSegments\":" + "[{\"domainLabel\":\"region\",\"value\":\"" + regionValue + "\"}," + "{\"domainLabel\":\"zone\",\"value\":\"" + zoneValue + "\"}]}]" - err = createRBDStorageClass(f.ClientSet, f, + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, map[string]string{"volumeBindingMode": "WaitForFirstConsumer"}, map[string]string{"topologyConstrainedPools": topologyConstraint}, deletePolicy) if err != nil { @@ -1118,7 +1118,7 @@ var _ = Describe("RBD", func() { "\",\"domainSegments\":" + "[{\"domainLabel\":\"region\",\"value\":\"" + regionValue + "\"}," + "{\"domainLabel\":\"zone\",\"value\":\"" + zoneValue + "\"}]}]" - err = createRBDStorageClass(f.ClientSet, f, + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, map[string]string{"volumeBindingMode": "WaitForFirstConsumer"}, map[string]string{"topologyConstrainedPools": topologyConstraint}, deletePolicy) if err != nil { @@ -1154,7 +1154,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -1167,7 +1167,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, map[string]string{rbdmountOptions: "debug,invalidOption"}, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, map[string]string{rbdmountOptions: "debug,invalidOption"}, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -1205,7 +1205,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -1515,7 +1515,7 @@ var _ = Describe("RBD", func() { param["csi.storage.k8s.io/node-stage-secret-namespace"] = cephCSINamespace param["csi.storage.k8s.io/node-stage-secret-name"] = rbdNodePluginSecretName - err = createRBDStorageClass(f.ClientSet, f, nil, param, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, param, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -1628,7 +1628,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -1688,7 +1688,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, map[string]string{ + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, map[string]string{ "thickProvision": "true"}, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) @@ -1717,7 +1717,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -1728,7 +1728,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, map[string]string{ + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, map[string]string{ "mapOptions": "lock_on_read,queue_depth=1024", "unmapOptions": "force"}, deletePolicy) if err != nil { @@ -1742,7 +1742,7 @@ var _ = Describe("RBD", func() { if err != nil { e2elog.Failf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } @@ -1759,7 +1759,7 @@ var _ = Describe("RBD", func() { } // validate created backend rbd images validateRBDImageCount(f, 0, defaultRBDPool) - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } diff --git a/e2e/rbd_helper.go b/e2e/rbd_helper.go index 60fdeb5b6..3c577a529 100644 --- a/e2e/rbd_helper.go +++ b/e2e/rbd_helper.go @@ -30,12 +30,15 @@ func rbdOptions(pool string) string { return "--pool=" + pool } -func createRBDStorageClass(c kubernetes.Interface, f *framework.Framework, scOptions, parameters map[string]string, policy v1.PersistentVolumeReclaimPolicy) error { +func createRBDStorageClass(c kubernetes.Interface, f *framework.Framework, name string, scOptions, parameters map[string]string, policy v1.PersistentVolumeReclaimPolicy) error { scPath := fmt.Sprintf("%s/%s", rbdExamplePath, "storageclass.yaml") sc, err := getStorageClass(scPath) if err != nil { return nil } + if name != "" { + sc.Name = name + } sc.Parameters["pool"] = defaultRBDPool sc.Parameters["csi.storage.k8s.io/provisioner-secret-namespace"] = cephCSINamespace sc.Parameters["csi.storage.k8s.io/provisioner-secret-name"] = rbdProvisionerSecretName diff --git a/e2e/upgrade-rbd.go b/e2e/upgrade-rbd.go index a73a58d9a..afa8806ae 100644 --- a/e2e/upgrade-rbd.go +++ b/e2e/upgrade-rbd.go @@ -63,7 +63,7 @@ var _ = Describe("RBD Upgrade Testing", func() { if err != nil { e2elog.Failf("failed to create configmap with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { e2elog.Failf("failed to create storageclass with error %v", err) } diff --git a/e2e/utils.go b/e2e/utils.go index 129c3adb4..0fe7aedc0 100644 --- a/e2e/utils.go +++ b/e2e/utils.go @@ -26,8 +26,8 @@ import ( /* #nosec:G101, values not credententials, just a reference to the location.*/ const ( - defaultNs = "default" - + defaultNs = "default" + defaultSCName = "" // vaultBackendPath is the default VAULT_BACKEND_PATH for secrets vaultBackendPath = "secret/" // vaultPassphrasePath is an advanced configuration option, only @@ -975,7 +975,7 @@ func validateController(f *framework.Framework, pvcPath, appPath, scPath string) expandSize := "10Gi" var err error // create storageclass with retain - err = createRBDStorageClass(f.ClientSet, f, nil, nil, retainPolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, retainPolicy) if err != nil { return fmt.Errorf("failed to create storageclass with error %v", err) } @@ -1007,7 +1007,7 @@ func validateController(f *framework.Framework, pvcPath, appPath, scPath string) if err != nil { return fmt.Errorf("failed to delete storageclass with error %v", err) } - err = createRBDStorageClass(f.ClientSet, f, nil, nil, deletePolicy) + err = createRBDStorageClass(f.ClientSet, f, defaultSCName, nil, nil, deletePolicy) if err != nil { return fmt.Errorf("failed to create storageclass with error %v", err) }