From 360df61eb0f00c5ddfb4415b363e91c4fbab6e52 Mon Sep 17 00:00:00 2001 From: Niels de Vos Date: Wed, 31 May 2023 10:27:43 +0200 Subject: [PATCH] ci: `github.event.pull_request.merged` is a boolean, not a string With the updates to the pull-request-commenter, all strings were placed within `'` to prevent syntax issues. It seems that `github.event.pull_request.merged` really is a boolean (or `null`), and not a string. Doc: https://docs.github.com/en/webhooks-and-events/ ("payloads" section) Signed-off-by: Niels de Vos --- .github/workflows/pull-request-commentor.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request-commentor.yaml b/.github/workflows/pull-request-commentor.yaml index 85aed5dad..2eefd445d 100644 --- a/.github/workflows/pull-request-commentor.yaml +++ b/.github/workflows/pull-request-commentor.yaml @@ -13,7 +13,7 @@ jobs: add-comment: if: > (github.event.pull_request.label == 'ok-to-test' && - github.event.pull_request.merged != 'true') || + github.event.pull_request.merged != true) || (github.event.pull_request.action == 'opened' && contains(github.event.pull_request.labels.*.name,'ok-to-test')) runs-on: ubuntu-latest