mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2024-11-10 00:10:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

util: fix golint warnings in csiconfig, volid

Browse Source 
golint warns about the following statements:

ceph-csi/internal/util/csiconfig.go
Line 49: warning: exported function Mons should have comment or be unexported (golint)

ceph-csi/pkg/util/volid.go :
Line 72: warning: exported method CSIIdentifier.ComposeCSIID should have comment
or be unexported (golint)

Reported-by: https://goreportcard.com/report/github.com/ceph/ceph-csi
Updates: #975

Signed-off-by: Yug Gupta <ygupta@redhat.com>
This commit is contained in:
Yug Gupta 2020-04-28 20:52:24 +05:30 committed by mergify[bot]
parent b6ea4ecdf0
commit 47226ccdf7
2 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
internal/util/csiconfig.go
View File

@ -23,6 +23,14 @@ import (
"strings" "strings"
) )
// clusterInfo strongly typed JSON spec for the below JSON structure
type clusterInfo struct {
// ClusterID is used for unique identification
ClusterID string `json:"clusterID"`
// Monitors is monitor list for corresponding cluster ID
Monitors []string `json:"monitors"`
}
/* /*
Mons returns a comma separated MON list from the csi config for the given clusterID Mons returns a comma separated MON list from the csi config for the given clusterID
Expected JSON structure in the passed in config file is, Expected JSON structure in the passed in config file is,
@ -39,13 +47,6 @@ Expected JSON structure in the passed in config file is,
... ...
] ]
*/ */
// clusterInfo strongly typed JSON spec for the above JSON structure
type clusterInfo struct {
ClusterID string `json:"clusterID"`
Monitors []string `json:"monitors"`
}
func Mons(pathToConfig, clusterID string) (string, error) { func Mons(pathToConfig, clusterID string) (string, error) {
var config []clusterInfo var config []clusterInfo

10
internal/util/volid.go
View File

@ -52,6 +52,11 @@ type CSIIdentifier struct {
// This maximum comes from the CSI spec on max bytes allowed in the various CSI ID fields // This maximum comes from the CSI spec on max bytes allowed in the various CSI ID fields
const maxVolIDLen = 128 const maxVolIDLen = 128
const (
knownFieldSize = 64
uuidSize = 36
)
/* /*
ComposeCSIID composes a CSI ID from passed in parameters. ComposeCSIID composes a CSI ID from passed in parameters.
Version 1 of the encoding scheme is as follows, Version 1 of the encoding scheme is as follows,
@ -64,11 +69,6 @@ Version 1 of the encoding scheme is as follows,
Total of constant field lengths, including '-' field separators would hence be, Total of constant field lengths, including '-' field separators would hence be,
4+1+4+1+1+16+1+36 = 64 4+1+4+1+1+16+1+36 = 64
*/ */
const (
knownFieldSize = 64
uuidSize = 36
)
func (ci CSIIdentifier) ComposeCSIID() (string, error) { func (ci CSIIdentifier) ComposeCSIID() (string, error) {
buf16 := make([]byte, 2) buf16 := make([]byte, 2)
buf64 := make([]byte, 8) buf64 := make([]byte, 8)