From 49c6784c5c9664e36468db0d6223d1dcfcfb2f9c Mon Sep 17 00:00:00 2001
From: Niels de Vos <ndevos@redhat.com>
Date: Wed, 4 Nov 2020 10:47:22 +0100
Subject: [PATCH] ci: deploy/jjb.sh should fail on wrong arguments

In case the '--cmd' option is missing, usage() will be called and the
script exits with 0. A missing option is a failure, so make usage()
return and handle the exit status when usage() got called instead.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
---
 deploy/jjb.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/deploy/jjb.sh b/deploy/jjb.sh
index 36ba36d21..ebd0189ea 100755
--- a/deploy/jjb.sh
+++ b/deploy/jjb.sh
@@ -24,7 +24,6 @@ function usage() {
     echo "--GIT_REPO    specify the repo to build from (default: ${GIT_REPO})"
     echo "--help        specify the flags"
     echo " "
-    exit 0
 }
 
 ARGUMENT_LIST=(
@@ -62,7 +61,8 @@ while true; do
                         shift 2 ;;
         --GIT_REPO)     GIT_REPO=${2}
                         shift 2 ;;
-        --help)         usage ;;
+        --help)         usage
+                        exit 0 ;;
         --)             shift 1
                         break ;;
     esac
@@ -71,7 +71,7 @@ done
 if [ -z "${CMD}" ]
 then
 	echo "missing --cmd <command>."
-	usage
+	exit 1
 fi
 
 get_pod_status() {