From 49d094e3d5abf8c5c4c64c2796ace44e16fd382c Mon Sep 17 00:00:00 2001
From: Niels de Vos <ndevos@ibm.com>
Date: Thu, 3 Apr 2025 17:01:24 +0200
Subject: [PATCH] e2e: `Skip()` inside a test case causes other cases to be
 skipped

The Ginkgo `Skip()` function does not only skip the current `By()`, but
it's parent `It()` function. That means other `By()` tests will not be
run after a `Skip()` was called.

Replacing the `Skip()` with an early return of the function makes sure
that all `By()` tests are executed.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
---
 e2e/rbd.go | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/e2e/rbd.go b/e2e/rbd.go
index 797f31fa4..281c171dd 100644
--- a/e2e/rbd.go
+++ b/e2e/rbd.go
@@ -5219,7 +5219,8 @@ var _ = Describe("RBD", func() {
 					framework.Failf("failed to check for VolumeGroupSnapshot support: %v", err)
 				}
 				if !supported {
-					Skip("librbd does not support required VolumeGroupSnapshot function(s)")
+					framework.Logf("SKIPPING: librbd does not support required VolumeGroupSnapshot function(s)")
+					return
 				}
 
 				scName := "csi-rbd-sc"