mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2024-11-09 16:00:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

ci: pass GITHUB_BASE_REF when running commitlint

Browse Source 
GitHub Actions include a merge commit for the PR, which will defeat the
commitlint checking of all the commits inside the PR (only the merge
commit is checked).

Signed-off-by: Niels de Vos <ndevos@redhat.com>
This commit is contained in:
Niels de Vos 2021-06-07 10:40:26 +02:00 committed by Madhu Rajanna
parent 4e2c4ef704
commit 538e36f7a7
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.github/workflows/commitlint.yaml vendored
View File

@ -11,5 +11,8 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- uses: actions/checkout@v2 - uses: actions/checkout@v2
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: commitlint - name: commitlint
run: CONTAINER_CMD=docker make containerized-test TARGET=commitlint # yamllint disable-line rule:line-length
run: make containerized-test CONTAINER_CMD=docker TARGET=commitlint GIT_SINCE="origin/${GITHUB_BASE_REF}"

2
Makefile
View File

@ -148,7 +148,7 @@ commitlint: REBASE ?= 0
commitlint: commitlint:
git fetch -v $(shell cut -d/ -f1 <<< "$(GIT_SINCE)") $(shell cut -d/ -f2- <<< "$(GIT_SINCE)") git fetch -v $(shell cut -d/ -f1 <<< "$(GIT_SINCE)") $(shell cut -d/ -f2- <<< "$(GIT_SINCE)")
@test $(REBASE) -eq 0 || git -c user.name=commitlint -c user.email=commitline@localhost rebase FETCH_HEAD @test $(REBASE) -eq 0 || git -c user.name=commitlint -c user.email=commitline@localhost rebase FETCH_HEAD
commitlint --from FETCH_HEAD commitlint --verbose --from $(GIT_SINCE)
.PHONY: cephcsi .PHONY: cephcsi
cephcsi: check-env cephcsi: check-env