mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2025-06-13 02:33:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

ci: non-constant format string (govet)

Browse Source 
Signed-off-by: Praveen M <m.praveen@ibm.com>
This commit is contained in:
Praveen M
2024-12-20 18:23:59 +05:30
committed by mergify[bot]
parent 96408c01c8
commit 54a8b50957
14 changed files with 63 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
internal/rbd/controllerserver.go
View File

@ -1122,9 +1122,9 @@ func (cs *ControllerServer) CreateSnapshot(
err = status.Errorf(codes.NotFound, "source Volume ID %s not found", req.GetSourceVolumeId())
case errors.Is(err, util.ErrPoolNotFound):
log.ErrorLog(ctx, "failed to get backend volume for %s: %v", req.GetSourceVolumeId(), err)
err = status.Errorf(codes.NotFound, err.Error())
err = status.Error(codes.NotFound, err.Error())
default:
err = status.Errorf(codes.Internal, err.Error())
err = status.Error(codes.Internal, err.Error())
}
return nil, err
@ -1171,7 +1171,7 @@ func (cs *ControllerServer) CreateSnapshot(
return nil, status.Error(codes.AlreadyExists, err.Error())
}
return nil, status.Errorf(codes.Internal, err.Error())
return nil, status.Error(codes.Internal, err.Error())
}
if found {
return cloneFromSnapshot(ctx, rbdVol, rbdSnap, cr, req.GetParameters())
@ -1253,7 +1253,7 @@ func cloneFromSnapshot(
log.WarningLog(ctx, "failed undoing reservation of snapshot: %s %v", rbdSnap.RequestName, uErr)
}
return nil, status.Errorf(codes.Internal, err.Error())
return nil, status.Error(codes.Internal, err.Error())
}
defer vol.Destroy(ctx)
@ -1265,14 +1265,14 @@ func cloneFromSnapshot(
err = vol.flattenRbdImage(ctx, false, rbdHardMaxCloneDepth, rbdSoftMaxCloneDepth)
if errors.Is(err, ErrFlattenInProgress) {
// if flattening is in progress, return error and do not cleanup
return nil, status.Errorf(codes.Internal, err.Error())
return nil, status.Error(codes.Internal, err.Error())
} else if err != nil {
uErr := undoSnapshotCloning(ctx, rbdVol, rbdSnap, vol, cr)
if uErr != nil {
log.WarningLog(ctx, "failed undoing reservation of snapshot: %s %v", rbdSnap.RequestName, uErr)
}
return nil, status.Errorf(codes.Internal, err.Error())
return nil, status.Error(codes.Internal, err.Error())
}
// Update snapshot-name/snapshot-namespace/snapshotcontent-name details on
@ -1566,9 +1566,9 @@ func (cs *ControllerServer) ControllerExpandVolume(
err = status.Errorf(codes.NotFound, "volume ID %s not found", volID)
case errors.Is(err, util.ErrPoolNotFound):
log.ErrorLog(ctx, "failed to get backend volume for %s: %v", volID, err)
err = status.Errorf(codes.NotFound, err.Error())
err = status.Error(codes.NotFound, err.Error())
default:
err = status.Errorf(codes.Internal, err.Error())
err = status.Error(codes.Internal, err.Error())
}
return nil, err

10
internal/rbd/driver/driver.go
View File

@ -143,7 +143,7 @@ func (r *Driver) Run(conf *util.Config) {
if k8s.RunsOnKubernetes() && conf.IsNodeServer {
nodeLabels, err = k8s.GetNodeLabels(conf.NodeID)
if err != nil {
log.FatalLogMsg(err.Error())
log.FatalLogMsg("%v", err.Error())
}
}
@ -157,19 +157,19 @@ func (r *Driver) Run(conf *util.Config) {
if conf.IsNodeServer {
topology, err = util.GetTopologyFromDomainLabels(conf.DomainLabels, conf.NodeID, conf.DriverName)
if err != nil {
log.FatalLogMsg(err.Error())
log.FatalLogMsg("%v", err.Error())
}
r.ns = NewNodeServer(r.cd, conf.Vtype, nodeLabels, topology, crushLocationMap)
var attr string
attr, err = rbd.GetKrbdSupportedFeatures()
if err != nil && !errors.Is(err, os.ErrNotExist) {
log.FatalLogMsg(err.Error())
log.FatalLogMsg("%v", err.Error())
}
var krbdFeatures uint
krbdFeatures, err = rbd.HexStringToInteger(attr)
if err != nil {
log.FatalLogMsg(err.Error())
log.FatalLogMsg("%v", err.Error())
}
rbd.SetGlobalInt("krbdFeatures", krbdFeatures)
@ -185,7 +185,7 @@ func (r *Driver) Run(conf *util.Config) {
// configure CSI-Addons server and components
err = r.setupCSIAddonsServer(conf)
if err != nil {
log.FatalLogMsg(err.Error())
log.FatalLogMsg("%v", err.Error())
}
s := csicommon.NewNonBlockingGRPCServer()