mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2025-06-13 10:33:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

rbd: change the configmap of HPCS/KP key names to reflect the IBM string

Browse Source 
considering IBM has different crypto services (ex: SKLM) in place, its
good to keep the configmap key names with below format

`IBM_KP_...` instead of `KP_..`

so that in future, if we add more crypto services from IBM we can keep
similar schema specific to that specific service from IBM.

Ex: `IBM_SKLM_...`

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
This commit is contained in:
Humble Chirammal
2022-01-04 14:53:21 +05:30
committed by mergify[bot]
parent 180f0f660f
commit 5aa1e4d225
4 changed files with 20 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
internal/kms/keyprotect.go
View File

@ -33,7 +33,7 @@ const (
// keyProtectMetadataDefaultSecretsName is the default name of the Kubernetes Secret
// that contains the credentials to access the Key Protect KMS. The name of
// the Secret can be configured by setting the `KMS_SECRET_NAME`
// the Secret can be configured by setting the `IBM_KP_SECRET_NAME`
// option.
//
// #nosec:G101, value not credential, just references token.
@ -43,17 +43,16 @@ const (
// the credentials to access the Key ProtectKMS.
//
// #nosec:G101, no hardcoded secret, this is a configuration key.
keyProtectSecretNameKey = "KMS_SECRET_NAME"
keyProtectRegionKey = "KP_REGION"
keyProtectSecretNameKey = "IBM_KP_SECRET_NAME"
keyProtectRegionKey = "IBM_KP_REGION"
keyProtectServiceInstanceID = "KP_SERVICE_INSTANCE_ID"
keyProtectServiceInstanceID = "IBM_KP_SERVICE_INSTANCE_ID"
// The following options are part of the Kubernetes Secrets.
// #nosec:G101, no hardcoded secrets, only configuration keys.
keyProtectServiceAPIKey = "KP_SERVICE_API_KEY"
KeyProtectCustomerRootKey = "KP_CUSTOMER_ROOT_KEY"
keyProtectSessionToken = "KP_SESSION_TOKEN"
keyProtectCRK = "KP_CRK_ARN"
keyProtectServiceAPIKey = "IBM_KP_SERVICE_API_KEY"
KeyProtectCustomerRootKey = "IBM_KP_CUSTOMER_ROOT_KEY"
keyProtectSessionToken = "IBM_KP_SESSION_TOKEN" //nolint:gosec // only configuration key
keyProtectCRK = "IBM_KP_CRK_ARN"
)
var _ = RegisterProvider(Provider{