rbd: fail DisableVolumeReplication() if image is not mirror disabled

This commit modifies DisableVolumeReplication() to fail
if the image is not in mirror disabled state

Signed-off-by: Rakshith R <rar@redhat.com>
This commit is contained in:
Rakshith R 2024-09-11 14:46:19 +05:30 committed by mergify[bot]
parent 49926446f9
commit 61c23dd4d2

View File

@ -90,8 +90,10 @@ func DisableVolumeReplication(mirror types.Mirror,
return fmt.Errorf("failed to get mirroring info of image: %w", err) return fmt.Errorf("failed to get mirroring info of image: %w", err)
} }
if info.GetState() == librbd.MirrorImageDisabling.String() { // error out if the image is not in disabled state.
return fmt.Errorf("%w: image is in disabling state", ErrAborted) if info.GetState() != librbd.MirrorImageDisabled.String() {
return fmt.Errorf("%w: image is in %q state, expected state %q", ErrAborted,
info.GetState(), librbd.MirrorImageDisabled.String())
} }
return nil return nil