mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2025-06-14 02:43:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

rbd: use go-ceph for getImageMirroringStatus

Browse Source 
Currently, getImageMirroringStatus() is using RBD CLI.
This commit converts RBD CLI to go-ceph API.

Fixes: #2120

Signed-off-by: Yati Padia <ypadia@redhat.com>
This commit is contained in:
Yati Padia
2021-06-23 18:44:48 +05:30
committed by mergify[bot]
parent 4e6d9be826
commit 6691951453
2 changed files with 50 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
internal/rbd/mirror.go
View File

@ -16,12 +16,7 @@ limitations under the License.
package rbd
import (
"context"
"encoding/json"
"fmt"
"strings"
"github.com/ceph/ceph-csi/internal/util"
librbd "github.com/ceph/go-ceph/rbd"
)
@ -119,51 +114,17 @@ func (ri *rbdImage) resyncImage() error {
return nil
}
type imageMirrorStatus struct {
Name string `json:"name"` // name of the rbd image
State string `json:"state"` // rbd image state
Description string `json:"description"`
LastUpdate string `json:"last_update"`
PeerSites []struct {
SiteName string `json:"site_name"`
State string `json:"state"`
Description string `json:"description"`
LastUpdate string `json:"last_update"`
} `json:"peer_sites"`
}
// FIXME: once https://github.com/ceph/go-ceph/issues/460 is fixed use go-ceph.
// getImageMirroringStatus get the mirroring status of an image.
func (ri *rbdImage) getImageMirroringStatus() (*imageMirrorStatus, error) {
// rbd mirror image status --format=json info [image-spec | snap-spec]
var imgStatus imageMirrorStatus
stdout, stderr, err := util.ExecCommand(
context.TODO(),
"rbd",
"-m", ri.Monitors,
"--id", ri.conn.Creds.ID,
"--keyfile="+ri.conn.Creds.KeyFile,
"-c", util.CephConfigPath,
"--format="+"json",
"mirror",
"image",
"status",
ri.String())
// getImageMirroingStatus get the mirroring status of an image.
func (ri *rbdImage) getImageMirroringStatus() (*librbd.GlobalMirrorImageStatus, error) {
image, err := ri.open()
if err != nil {
if strings.Contains(stderr, "rbd: error opening image "+ri.RbdImageName+
": (2) No such file or directory") {
return nil, util.JoinErrors(ErrImageNotFound, err)
}
return nil, err
return nil, fmt.Errorf("failed to open image %q with error: %w", ri, err)
}
defer image.Close()
statusInfo, err := image.GetGlobalMirrorStatus()
if err != nil {
return nil, fmt.Errorf("failed to get image mirroring status %q with error: %w", ri, err)
}
if stdout != "" {
err = json.Unmarshal([]byte(stdout), &imgStatus)
if err != nil {
return nil, fmt.Errorf("unmarshal failed (%w), raw buffer response: %s", err, stdout)
}
}
return &imgStatus, nil
return &statusInfo, nil
}