From 2192d40937bd86286e37829e66097c074042e55f Mon Sep 17 00:00:00 2001 From: Niels de Vos Date: Mon, 2 Sep 2019 13:45:21 +0200 Subject: [PATCH] mergify: Remove approved review when a PR changes When people have reviewed a PR, and the contributor updates it, the reviews are staying valid. This is unfortunate as the PR might need new corrections. Ideally a positive review (Approved) needs to be given again. And there needs to be a confirmation that a negative review (Changes requested) has been addressed. Closes: #505 Signed-off-by: Niels de Vos --- .mergify.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.mergify.yml b/.mergify.yml index 544e2391f..262235c83 100644 --- a/.mergify.yml +++ b/.mergify.yml @@ -1,5 +1,12 @@ --- pull_request_rules: + - name: remove outdated approvals + conditions: + - base=master + actions: + dismiss_reviews: + approved: true + changes_requested: false - name: automatic merge conditions: - label!=DNM