mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2024-11-12 17:30:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

rbd: discard not found error from GetMetadata

Browse Source 
During ResyncVolume call, discard not found
error from GetMetadata API. If the image gets
resynced the local image creation time will be
lost, if the key is not present in the image
metadata then we can assume that the image is
already resynced.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
This commit is contained in:
Madhu Rajanna 2023-09-02 09:21:35 +02:00 committed by mergify[bot]
parent 561e0bc04a
commit 683821c407
1 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
internal/csi-addons/rbd/replication.go
View File

@ -513,6 +513,7 @@ func (rs *ReplicationServer) DemoteVolume(ctx context.Context,
// store the image creation time for resync // store the image creation time for resync
_, err = rbdVol.GetMetadata(imageCreationTimeKey) _, err = rbdVol.GetMetadata(imageCreationTimeKey)
if err != nil && errors.Is(err, librbd.ErrNotFound) { if err != nil && errors.Is(err, librbd.ErrNotFound) {
log.DebugLog(ctx, "setting image creation time %s for %s", creationTime, rbdVol)
err = rbdVol.SetMetadata(imageCreationTimeKey, timestampToString(creationTime)) err = rbdVol.SetMetadata(imageCreationTimeKey, timestampToString(creationTime))
} }
if err != nil { if err != nil {
@ -670,8 +671,11 @@ func (rs *ReplicationServer) ResyncVolume(ctx context.Context,
// image creation time is stored in the image metadata. it looks like // image creation time is stored in the image metadata. it looks like
// `"seconds:1692879841 nanos:631526669"` // `"seconds:1692879841 nanos:631526669"`
// If the image gets resynced the local image creation time will be
// lost, if the keys is not present in the image metadata then we can
// assume that the image is already resynced.
savedImageTime, err := rbdVol.GetMetadata(imageCreationTimeKey) savedImageTime, err := rbdVol.GetMetadata(imageCreationTimeKey)
if err != nil { if err != nil && !errors.Is(err, librbd.ErrNotFound) {
return nil, status.Errorf(codes.Internal, return nil, status.Errorf(codes.Internal,
"failed to get %s key from image metadata for %s: %s", "failed to get %s key from image metadata for %s: %s",
imageCreationTimeKey, imageCreationTimeKey,
@ -679,16 +683,17 @@ func (rs *ReplicationServer) ResyncVolume(ctx context.Context,
err.Error()) err.Error())
} }
st, err := timestampFromString(savedImageTime) if savedImageTime != "" {
if err != nil { st, sErr := timestampFromString(savedImageTime)
return nil, status.Errorf(codes.Internal, "failed to parse image creation time: %s", err.Error()) if sErr != nil {
} return nil, status.Errorf(codes.Internal, "failed to parse image creation time: %s", sErr.Error())
log.DebugLog(ctx, "image %s, savedImageTime=%v, currentImageTime=%v", rbdVol, st, creationTime.AsTime()) }
log.DebugLog(ctx, "image %s, savedImageTime=%v, currentImageTime=%v", rbdVol, st, creationTime.AsTime())
if req.Force && st.Equal(creationTime.AsTime()) { if req.Force && st.Equal(creationTime.AsTime()) {
err = rbdVol.ResyncVol(localStatus) err = rbdVol.ResyncVol(localStatus)
if err != nil { if err != nil {
return nil, getGRPCError(err) return nil, getGRPCError(err)
}
} }
} }