From 6cea9e264944595ebbab8287563c05e298836f9b Mon Sep 17 00:00:00 2001 From: Niels de Vos Date: Thu, 14 May 2020 15:42:19 +0200 Subject: [PATCH] util: remove unused getPools() Signed-off-by: Niels de Vos --- internal/util/cephcmds.go | 35 ----------------------------------- 1 file changed, 35 deletions(-) diff --git a/internal/util/cephcmds.go b/internal/util/cephcmds.go index 3dd33a77d..bc5694178 100644 --- a/internal/util/cephcmds.go +++ b/internal/util/cephcmds.go @@ -19,7 +19,6 @@ package util import ( "bytes" "context" - "encoding/json" "fmt" "io/ioutil" "os" @@ -53,40 +52,6 @@ func ExecCommand(program string, args ...string) (stdout, stderr []byte, err err return stdoutBuf.Bytes(), nil, nil } -// cephStoragePoolSummary strongly typed JSON spec for osd ls pools output -type cephStoragePoolSummary struct { - Name string `json:"poolname"` - Number int64 `json:"poolnum"` -} - -// GetPools fetches a list of pools from a cluster -func getPools(ctx context.Context, monitors string, cr *Credentials) ([]cephStoragePoolSummary, error) { - // ceph -f json osd lspools - // JSON out: [{"poolnum":,"poolname":}] - - stdout, _, err := ExecCommand( - "ceph", - "-m", monitors, - "--id", cr.ID, - "--keyfile="+cr.KeyFile, - "-c", CephConfigPath, - "-f", "json", - "osd", "lspools") - if err != nil { - klog.Errorf(Log(ctx, "failed getting pool list from cluster (%s)"), err) - return nil, err - } - - var pools []cephStoragePoolSummary - err = json.Unmarshal(stdout, &pools) - if err != nil { - klog.Errorf(Log(ctx, "failed to parse JSON output of pool list from cluster (%s)"), err) - return nil, fmt.Errorf("unmarshal of pool list failed: %+v. raw buffer response: %s", err, string(stdout)) - } - - return pools, nil -} - // GetPoolID fetches the ID of the pool that matches the passed in poolName // parameter func GetPoolID(monitors string, cr *Credentials, poolName string) (int64, error) {