mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2024-12-18 11:00:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: address gosec warning "Implicit memory aliasing in for loop"

Browse Source 
gosec warns about it like this:

    G601: Implicit memory aliasing in for loop. (gosec)

Signed-off-by: Niels de Vos <ndevos@ibm.com>
This commit is contained in:
Niels de Vos 2024-04-29 10:35:48 +02:00 committed by mergify[bot]
parent e85914fc0d
commit 6db7138ca0
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
internal/csi-addons/rbd/replication_test.go
View File

@ -261,12 +261,12 @@ func TestCheckRemoteSiteStatus(t *testing.T) {
t.Parallel() t.Parallel()
tests := []struct { tests := []struct {
name string name string
args librbd.GlobalMirrorImageStatus args *librbd.GlobalMirrorImageStatus
wantReady bool wantReady bool
}{ }{
{ {
name: "Test a single peer in sync", name: "Test a single peer in sync",
args: librbd.GlobalMirrorImageStatus{ args: &librbd.GlobalMirrorImageStatus{
SiteStatuses: []librbd.SiteMirrorImageStatus{ SiteStatuses: []librbd.SiteMirrorImageStatus{
{ {
MirrorUUID: "remote", MirrorUUID: "remote",
@ -279,7 +279,7 @@ func TestCheckRemoteSiteStatus(t *testing.T) {
}, },
{ {
name: "Test a single peer in sync, including a local instance", name: "Test a single peer in sync, including a local instance",
args: librbd.GlobalMirrorImageStatus{ args: &librbd.GlobalMirrorImageStatus{
SiteStatuses: []librbd.SiteMirrorImageStatus{ SiteStatuses: []librbd.SiteMirrorImageStatus{
{ {
MirrorUUID: "remote", MirrorUUID: "remote",
@ -297,7 +297,7 @@ func TestCheckRemoteSiteStatus(t *testing.T) {
}, },
{ {
name: "Test a multiple peers in sync", name: "Test a multiple peers in sync",
args: librbd.GlobalMirrorImageStatus{ args: &librbd.GlobalMirrorImageStatus{
SiteStatuses: []librbd.SiteMirrorImageStatus{ SiteStatuses: []librbd.SiteMirrorImageStatus{
{ {
MirrorUUID: "remote1", MirrorUUID: "remote1",
@ -315,14 +315,14 @@ func TestCheckRemoteSiteStatus(t *testing.T) {
}, },
{ {
name: "Test no remote peers", name: "Test no remote peers",
args: librbd.GlobalMirrorImageStatus{ args: &librbd.GlobalMirrorImageStatus{
SiteStatuses: []librbd.SiteMirrorImageStatus{}, SiteStatuses: []librbd.SiteMirrorImageStatus{},
}, },
wantReady: false, wantReady: false,
}, },
{ {
name: "Test single peer not in sync", name: "Test single peer not in sync",
args: librbd.GlobalMirrorImageStatus{ args: &librbd.GlobalMirrorImageStatus{
SiteStatuses: []librbd.SiteMirrorImageStatus{ SiteStatuses: []librbd.SiteMirrorImageStatus{
{ {
MirrorUUID: "remote", MirrorUUID: "remote",
@ -335,7 +335,7 @@ func TestCheckRemoteSiteStatus(t *testing.T) {
}, },
{ {
name: "Test single peer not up", name: "Test single peer not up",
args: librbd.GlobalMirrorImageStatus{ args: &librbd.GlobalMirrorImageStatus{
SiteStatuses: []librbd.SiteMirrorImageStatus{ SiteStatuses: []librbd.SiteMirrorImageStatus{
{ {
MirrorUUID: "remote", MirrorUUID: "remote",
@ -348,7 +348,7 @@ func TestCheckRemoteSiteStatus(t *testing.T) {
}, },
{ {
name: "Test multiple peers, when first peer is not in sync", name: "Test multiple peers, when first peer is not in sync",
args: librbd.GlobalMirrorImageStatus{ args: &librbd.GlobalMirrorImageStatus{
SiteStatuses: []librbd.SiteMirrorImageStatus{ SiteStatuses: []librbd.SiteMirrorImageStatus{
{ {
MirrorUUID: "remote1", MirrorUUID: "remote1",
@ -366,7 +366,7 @@ func TestCheckRemoteSiteStatus(t *testing.T) {
}, },
{ {
name: "Test multiple peers, when second peer is not up", name: "Test multiple peers, when second peer is not up",
args: librbd.GlobalMirrorImageStatus{ args: &librbd.GlobalMirrorImageStatus{
SiteStatuses: []librbd.SiteMirrorImageStatus{ SiteStatuses: []librbd.SiteMirrorImageStatus{
{ {
MirrorUUID: "remote1", MirrorUUID: "remote1",
@ -386,7 +386,7 @@ func TestCheckRemoteSiteStatus(t *testing.T) {
for _, tt := range tests { for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) { t.Run(tt.name, func(t *testing.T) {
t.Parallel() t.Parallel()
if ready := checkRemoteSiteStatus(context.TODO(), &tt.args); ready != tt.wantReady { if ready := checkRemoteSiteStatus(context.TODO(), tt.args); ready != tt.wantReady {
t.Errorf("checkRemoteSiteStatus() ready = %v, expect ready = %v", ready, tt.wantReady) t.Errorf("checkRemoteSiteStatus() ready = %v, expect ready = %v", ready, tt.wantReady)
} }
}) })