Fix markdown style issue

Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>

README.md

@@ -1,12 +1,22 @@
 # Ceph CSI 1.0.0
 
-[Container Storage Interface (CSI)](https://github.com/container-storage-interface/) driver, provisioner, and attacher for Ceph RBD and CephFS.
+[Container Storage Interface
+(CSI)](https://github.com/container-storage-interface/) driver, provisioner,
+and attacher for Ceph RBD and CephFS.
 
 ## Overview
 
-Ceph CSI plugins implement an interface between CSI enabled Container Orchestrator (CO) and CEPH cluster. It allows dynamically provisioning CEPH volumes and attaching them to workloads. Current implementation of Ceph CSI plugins was tested in Kubernetes environment (requires Kubernetes 1.11+), but the code does not rely on any Kubernetes specific calls (WIP to make it k8s agnostic) and should be able to run with any CSI enabled CO.
+Ceph CSI plugins implement an interface between CSI enabled Container
+Orchestrator (CO) and CEPH cluster.
+It allows dynamically provisioning CEPH volumes and attaching them to
+workloads.
+Current implementation of Ceph CSI plugins was tested in Kubernetes
+environment (requires Kubernetes 1.13+), but the code does not rely on
+any Kubernetes specific calls (WIP to make it k8s agnostic) and
+should be able to run with any CSI enabled CO.
 
-For details about configuration and deployment of RBD and CephFS CSI plugins, see documentation in `docs/`.
+For details about configuration and deployment of RBD and
+CephFS CSI plugins, see documentation in `docs/`.
 
 For example usage of RBD and CephFS CSI plugins, see examples in `examples/`.
 

docs/deploy-cephfs.md

@@ -1,10 +1,15 @@
 # CSI CephFS plugin
 
-The CSI CephFS plugin is able to both provision new CephFS volumes and attach and mount existing ones to workloads.
+The CSI CephFS plugin is able to both provision new CephFS volumes
+and attach and mount existing ones to workloads.
 
 ## Building
 
-CSI CephFS plugin can be compiled in a form of a binary file or in a form of a Docker image. When compiled as a binary file, the result is stored in `_output/` directory with the name `cephfsplugin`. When compiled as an image, it's stored in the local Docker image store.
+CSI CephFS plugin can be compiled in a form of a binary file or in a form of a
+Docker image.
+When compiled as a binary file, the result is stored in `_output/`
+directory with the name `cephfsplugin`.
+When compiled as an image, it's stored in the local Docker image store.
 
 Building binary:
 
@@ -30,10 +35,13 @@ Option              | Default value         | Description
 `--volumemounter`   | _empty_               | default volume mounter. Available options are `kernel` and `fuse`. This is the mount method used if volume parameters don't specify otherwise. If left unspecified, the driver will first probe for `ceph-fuse` in system's path and will choose Ceph kernel client if probing failed.
 `--metadatastorage` | _empty_               | Whether should metadata be kept on node as file or in a k8s configmap (`node` or `k8s_configmap`)
 
-**Available environmental variables:**
+**Available environmental variables:** `KUBERNETES_CONFIG_PATH`: if you use
-`KUBERNETES_CONFIG_PATH`: if you use `k8s_configmap` as metadata store, specify the path of your k8s config file (if not specified, the plugin will assume you're running it inside a k8s cluster and find the config itself).
+`k8s_configmap` as metadata store, specify the path of your k8s config file (if
+not specified, the plugin will assume you're running it inside a k8s cluster and
+find the config itself).
 
-`POD_NAMESPACE`: if you use `k8s_configmap` as metadata store, `POD_NAMESPACE` is used to define in which namespace you want the configmaps to be stored
+`POD_NAMESPACE`: if you use `k8s_configmap` as metadata store, `POD_NAMESPACE`
+is used to define in which namespace you want the configmaps to be stored
 
 **Available volume parameters:**
 
@@ -48,25 +56,32 @@ Parameter
 `csi.storage.k8s.io/provisioner-secret-name`, `csi.storage.k8s.io/node-stage-secret-name`           | for Kubernetes                                         | name of the Kubernetes Secret object containing Ceph client credentials. Both parameters should have the same value
 `csi.storage.k8s.io/provisioner-secret-namespace`, `csi.storage.k8s.io/node-stage-secret-namespace` | for Kubernetes                                         | namespaces of the above Secret objects
 
-**Required secrets for `provisionVolume=true`:**  
+**Required secrets for `provisionVolume=true`:**
 Admin credentials are required for provisioning new volumes
 
 * `adminID`: ID of an admin client
 * `adminKey`: key of the admin client
 
-**Required secrets for `provisionVolume=false`:**  
+**Required secrets for `provisionVolume=false`:**
 User credentials with access to an existing volume
 
 * `userID`: ID of a user client
 * `userKey`: key of a user client
 
-Notes on volume size: when provisioning a new volume, `max_bytes` quota attribute for this volume will be set to the requested volume size (see [Ceph quota documentation](http://docs.ceph.com/docs/mimic/cephfs/quota/)). A request for a zero-sized volume means no quota attribute will be set.
+Notes on volume size: when provisioning a new volume, `max_bytes` quota
+attribute for this volume will be set to the requested volume size (see [Ceph
+quota documentation](http://docs.ceph.com/docs/mimic/cephfs/quota/)). A request
+for a zero-sized volume means no quota attribute will be set.
 
 ## Deployment with Kubernetes
 
 Requires Kubernetes 1.13
 
-Your Kubernetes cluster must allow privileged pods (i.e. `--allow-privileged` flag must be set to true for both the API server and the kubelet). Moreover, as stated in the [mount propagation docs](https://kubernetes.io/docs/concepts/storage/volumes/#mount-propagation), the Docker daemon of the cluster nodes must allow shared mounts.
+Your Kubernetes cluster must allow privileged pods (i.e. `--allow-privileged`
+flag must be set to true for both the API server and the kubelet). Moreover, as
+stated in the [mount propagation
+docs](https://kubernetes.io/docs/concepts/storage/volumes/#mount-propagation),
+the Docker daemon of the cluster nodes must allow shared mounts.
 
 YAML manifests are located in `deploy/cephfs/kubernetes`.
 
@@ -78,7 +93,9 @@ kubectl create -f csi-provisioner-rbac.yaml
 kubectl create -f csi-nodeplugin-rbac.yaml
 ```
 
-Those manifests deploy service accounts, cluster roles and cluster role bindings. These are shared for both RBD and CephFS CSI plugins, as they require the same permissions.
+Those manifests deploy service accounts, cluster roles and cluster role
+bindings. These are shared for both RBD and CephFS CSI plugins, as they require
+the same permissions.
 
 **Deploy CSI sidecar containers:**
 
@@ -87,7 +104,8 @@ kubectl create -f csi-cephfsplugin-attacher.yaml
 kubectl create -f csi-cephfsplugin-provisioner.yaml
 ```
 
-Deploys stateful sets for external-attacher and external-provisioner sidecar containers for CSI CephFS.
+Deploys stateful sets for external-attacher and external-provisioner
+sidecar containers for CSI CephFS.
 
 **Deploy CSI CephFS driver:**
 
@@ -95,7 +113,8 @@ Deploys stateful sets for external-attacher and external-provisioner sidecar con
 kubectl create -f csi-cephfsplugin.yaml
 ```
 
-Deploys a daemon set with two containers: CSI driver-registrar and the CSI CephFS driver.
+Deploys a daemon set with two containers: CSI driver-registrar and
+the CSI CephFS driver.
 
 ## Verifying the deployment in Kubernetes
 
@@ -119,4 +138,7 @@ You can try deploying a demo pod from `examples/cephfs` to test the deployment f
 
 ### Notes on volume deletion
 
-Volumes that were provisioned dynamically (i.e. `provisionVolume=true`) are allowed to be deleted by the driver as well, if the user chooses to do so. Otherwise, the driver is forbidden to delete such volumes - attempting to delete them is a no-op.
+Volumes that were provisioned dynamically (i.e. `provisionVolume=true`) are
+allowed to be deleted by the driver as well, if the user chooses to do
+so.Otherwise, the driver is forbidden to delete such volumes - attempting to
+delete them is a no-op.

docs/deploy-rbd.md

@@ -1,19 +1,25 @@
 # CSI RBD Plugin
 
-The RBD CSI plugin is able to provision new RBD images and attach and mount those to worlkoads.
+The RBD CSI plugin is able to provision new RBD images and
+attach and mount those to worlkoads.
 
 ## Building
 
-CSI RBD plugin can be compiled in a form of a binary file or in a form of a Docker image. When compiled as a binary file, the result is stored in `_output/` directory with the name `rbdplugin`. When compiled as an image, it's stored in the local Docker image store.
+CSI RBD plugin can be compiled in a form of a binary file or in a form of a
+Docker image. When compiled as a binary file, the result is stored in
+`_output/` directory with the name `rbdplugin`. When compiled as an image, it's
+stored in the local Docker image store.
 
 Building binary:
+
 ```bash
-$ make rbdplugin
+make rbdplugin
 ```
 
 Building Docker image:
+
 ```bash
-$ make image-rbdplugin
+make image-rbdplugin
 ```
 
 ## Configuration
@@ -31,9 +37,13 @@ Option | Default value | Description
 **Available environmental variables:**
 `HOST_ROOTFS`: rbdplugin searches `/proc` directory under the directory set by `HOST_ROOTFS`.
 
-`KUBERNETES_CONFIG_PATH`: if you use `k8s_configmap` as metadata store, specify the path of your k8s config file (if not specified, the plugin will assume you're running it inside a k8s cluster and find the config itself).
+`KUBERNETES_CONFIG_PATH`: if you use `k8s_configmap` as metadata store, specify
+the path of your k8s config file (if not specified, the plugin will assume
+you're running it inside a k8s cluster and find the config itself).
 
-`POD_NAMESPACE`: if you use `k8s_configmap` as metadata store, `POD_NAMESPACE` is used to define in which namespace you want the configmaps to be stored
+`POD_NAMESPACE`: if you use `k8s_configmap` as metadata store,
+`POD_NAMESPACE` is used to define in which namespace you want
+the configmaps to be stored
 
 **Available volume parameters:**
 
@@ -48,9 +58,11 @@ Parameter | Required | Description
 `csi.storage.k8s.io/provisioner-secret-namespace`, `csi.storage.k8s.io/node-publish-secret-namespace` | for Kubernetes | namespaces of the above Secret objects
 `mounter`| no | if set to `rbd-nbd`, use `rbd-nbd` on nodes that have `rbd-nbd` and `nbd` kernel modules to map rbd images
 
-**Required secrets:**  
+**Required secrets:**
-Admin credentials are required for provisioning new RBD images
+
-`ADMIN_NAME`: `ADMIN_PASSWORD` - note that the key of the key-value pair is the name of the client with admin privileges, and the value is its password
+Admin credentials are required for provisioning new RBD images `ADMIN_NAME`:
+`ADMIN_PASSWORD` - note that the key of the key-value pair is the name of the
+client with admin privileges, and the value is its password
 
 Also note that CSI RBD expects admin keyring and Ceph config file in `/etc/ceph`.
 
@@ -58,33 +70,40 @@ Also note that CSI RBD expects admin keyring and Ceph config file in `/etc/ceph`
 
 Requires Kubernetes 1.11
 
-Your Kubernetes cluster must allow privileged pods (i.e. `--allow-privileged` flag must be set to true for both the API server and the kubelet). Moreover, as stated in the [mount propagation docs](https://kubernetes.io/docs/concepts/storage/volumes/#mount-propagation), the Docker daemon of the cluster nodes must allow shared mounts.
+Your Kubernetes cluster must allow privileged pods (i.e. `--allow-privileged`
+flag must be set to true for both the API server and the kubelet). Moreover, as
+stated in the [mount propagation
+docs](https://kubernetes.io/docs/concepts/storage/volumes/#mount-propagation),
+the Docker daemon of the cluster nodes must allow shared mounts.
 
 YAML manifests are located in `deploy/rbd/kubernetes`.
 
 **Deploy RBACs for sidecar containers and node plugins:**
 
 ```bash
-$ kubectl create -f csi-attacher-rbac.yaml
+kubectl create -f csi-attacher-rbac.yaml
-$ kubectl create -f csi-provisioner-rbac.yaml
+kubectl create -f csi-provisioner-rbac.yaml
-$ kubectl create -f csi-nodeplugin-rbac.yaml
+kubectl create -f csi-nodeplugin-rbac.yaml
 ```
 
-Those manifests deploy service accounts, cluster roles and cluster role bindings. These are shared for both RBD and CephFS CSI plugins, as they require the same permissions.
+Those manifests deploy service accounts, cluster roles and cluster role
+bindings. These are shared for both RBD and CephFS CSI plugins, as they require
+the same permissions.
 
 **Deploy CSI sidecar containers:**
 
 ```bash
-$ kubectl create -f csi-rbdplugin-attacher.yaml
+kubectl create -f csi-rbdplugin-attacher.yaml
-$ kubectl create -f csi-rbdplugin-provisioner.yaml
+kubectl create -f csi-rbdplugin-provisioner.yaml
 ```
 
-Deploys stateful sets for external-attacher and external-provisioner sidecar containers for CSI RBD.
+Deploys stateful sets for external-attacher and external-provisioner
+sidecar containers for CSI RBD.
 
 **Deploy RBD CSI driver:**
 
 ```bash
-$ kubectl create -f csi-rbdplugin.yaml
+kubectl create -f csi-rbdplugin.yaml
 ```
 
 Deploys a daemon set with two containers: CSI driver-registrar and the CSI RBD driver.
@@ -119,7 +138,7 @@ The Helm chart is located in `deploy/rbd/helm`.
 **Deploy Helm Chart:**
 
 ```bash
-$ helm install ./deploy/rbd/helm
+helm install ./deploy/rbd/helm
 ```
 
 The Helm chart deploys all of the required resources to use the CSI RBD driver.

examples/README.md

@@ -1,10 +1,20 @@
-## How to test RBD and CephFS plugins with Kubernetes 1.13
+# How to test RBD and CephFS plugins with Kubernetes 1.13
 
-Both `rbd` and `cephfs` directories contain `plugin-deploy.sh` and `plugin-teardown.sh` helper scripts. You can use those to help you deploy/tear down RBACs, sidecar containers and the plugin in one go. By default, they look for the YAML manifests in `../../deploy/{rbd,cephfs}/kubernetes`. You can override this path by running `$ ./plugin-deploy.sh /path/to/my/manifests`.
+Both `rbd` and `cephfs` directories contain `plugin-deploy.sh` and
+`plugin-teardown.sh` helper scripts.  You can use those to help you
+deploy/teardown RBACs, sidecar containers and the plugin in one go.
+By default, they look for the YAML manifests in
+`../../deploy/{rbd,cephfs}/kubernetes`.
+You can override this path by running `$ ./plugin-deploy.sh /path/to/my/manifests`.
 
-Once the plugin is successfuly deployed, you'll need to customize `storageclass.yaml` and `secret.yaml` manifests to reflect your Ceph cluster setup. Please consult the documentation for info about available parameters.
+Once the plugin is successfuly deployed, you'll need to customize
+`storageclass.yaml` and `secret.yaml` manifests to reflect your Ceph cluster
+setup.
+Please consult the documentation for info about available parameters.
+
+After configuring the secrets, monitors, etc. you can deploy a
+testing Pod mounting a RBD image / CephFS volume:
 
-After configuring the secrets, monitors, etc. you can deploy a testing Pod mounting a RBD image / CephFS volume:
 ```bash
 kubectl create -f secret.yaml
 kubectl create -f storageclass.yaml
@@ -13,16 +23,24 @@ kubectl create -f pod.yaml
 ```
 
 Other helper scripts:
+
 * `logs.sh` output of the plugin
 * `exec-bash.sh` logs into the plugin's container and runs bash
 
 ## How to test RBD Snapshot feature
 
-Before continuing, make sure you enabled the required feature gate `VolumeSnapshotDataSource=true` in your Kubernetes cluster.
+Before continuing, make sure you enabled the required
+feature gate `VolumeSnapshotDataSource=true` in your Kubernetes cluster.
 
-In the `examples/rbd` directory you will find two files related to snapshots: [snapshotclass.yaml](./rbd/snapshotclass.yaml) and [snapshot.yaml](./rbd/snapshot.yaml).
+In the `examples/rbd` directory you will find two files related to snapshots:
+[snapshotclass.yaml](./rbd/snapshotclass.yaml) and
+[snapshot.yaml](./rbd/snapshot.yaml).
 
-Once you created your RBD volume, you'll need to customize at least `snapshotclass.yaml` and make sure the `monitors` and `pool` parameters match your Ceph cluster setup. If you followed the documentation to create the rbdplugin, you shouldn't have to edit any other file.
+Once you created your RBD volume, you'll need to customize at least
+`snapshotclass.yaml` and make sure the `monitors` and `pool` parameters match
+your Ceph cluster setup.
+If you followed the documentation to create the rbdplugin, you shouldn't
+have to edit any other file.
 
 After configuring everything you needed, deploy the snapshot class:
 
@@ -44,7 +62,6 @@ Create a snapshot from the existing PVC:
 kubectl create -f snapshot.yaml
 ```
 
-
 To verify if your volume snapshot has successfully been created, run the following:
 
 ```console
@@ -86,9 +103,12 @@ Status:
 Events:           <none>
 ```
 
-To be sure everything is OK you can run `rbd snap ls [your-pvc-name]` inside one of your Ceph pod.
+To be sure everything is OK you can run `rbd snap ls [your-pvc-name]` inside
+one of your Ceph pod.
 
-To restore the snapshot to a new PVC, deploy [pvc-restore.yaml](./rbd/pvc-restore.yaml) and a testing pod [pod-restore.yaml](./rbd/pvc-restore.yaml):
+To restore the snapshot to a new PVC, deploy
+[pvc-restore.yaml](./rbd/pvc-restore.yaml) and a testing pod
+[pod-restore.yaml](./rbd/pvc-restore.yaml):
 
 ```bash
 kubectl create -f pvc-restore.yaml