mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2024-11-12 17:30:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup: use errors.As() in rbd.rbdStatus()

Browse Source 
See-also: https://github.com/golang/go/wiki/ErrorValueFAQ#how-should-i-change-my-error-handling-code-to-work-with-the-new-features
Signed-off-by: Niels de Vos <ndevos@redhat.com>
This commit is contained in:
Niels de Vos 2020-06-25 10:23:32 +02:00 committed by mergify[bot]
parent f93730dee7
commit 7126e92b4f
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/rbd/rbd_util.go
View File

@ -288,8 +288,9 @@ func rbdStatus(ctx context.Context, pOpts *rbdVolume, cr *util.Credentials) (boo
cmd, err := execCommand("rbd", args) cmd, err := execCommand("rbd", args)
output = string(cmd) output = string(cmd)
if err, ok := err.(*exec.Error); ok { var ee *exec.Error
if errors.Is(err.Err, exec.ErrNotFound) { if errors.As(err, &ee) {
if errors.Is(ee, exec.ErrNotFound) {
klog.Errorf(util.Log(ctx, "rbd cmd not found")) klog.Errorf(util.Log(ctx, "rbd cmd not found"))
// fail fast if command not found // fail fast if command not found
return false, output, err return false, output, err