From 74965fef41d8e08f18b99b02372d370cccc3b22a Mon Sep 17 00:00:00 2001 From: Niels de Vos Date: Wed, 22 Dec 2021 08:46:53 +0100 Subject: [PATCH] deploy: fix default URL for --csi-addons-endpoint option The --csi-addons-endpoint= option has been added recently, but was not configured in the deployment files yet. The socket was incorrectly created as `/csi-addons.sock`, by correcting the URL to the socket, the socket now gets created as `/tmp/csi-addons.sock` in the same directory as other sockets. If an endpoint is a UNIX Domain Socket, the format needs to be `unix:///path/to/socket`. The `unix://` URL format allows an authentication provider to be added directly after the `//`. If there is no authentication provider needed, the field can remain empty. After the authetication provider, the full path needs to be specified, starting with a `/`. This means that URLs to a UDS should start with `unix:///` in normal cases. Signed-off-by: Niels de Vos --- cmd/cephcsi.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/cephcsi.go b/cmd/cephcsi.go index 3bbd67770..f419790b0 100644 --- a/cmd/cephcsi.go +++ b/cmd/cephcsi.go @@ -59,7 +59,7 @@ var conf util.Config func init() { // common flags flag.StringVar(&conf.Vtype, "type", "", "driver type [rbd|cephfs|liveness|controller]") - flag.StringVar(&conf.Endpoint, "endpoint", "unix://tmp/csi.sock", "CSI endpoint") + flag.StringVar(&conf.Endpoint, "endpoint", "unix:///tmp/csi.sock", "CSI endpoint") flag.StringVar(&conf.DriverName, "drivername", "", "name of the driver") flag.StringVar(&conf.DriverNamespace, "drivernamespace", defaultNS, "namespace in which driver is deployed") flag.StringVar(&conf.NodeID, "nodeid", "", "node id") @@ -129,7 +129,7 @@ func init() { flag.BoolVar(&conf.EnableProfiling, "enableprofiling", false, "enable go profiling") // CSI-Addons configuration - flag.StringVar(&conf.CSIAddonsEndpoint, "csi-addons-endpoint", "unix://tmp/csi-addons.sock", "CSI-Addons endpoint") + flag.StringVar(&conf.CSIAddonsEndpoint, "csi-addons-endpoint", "unix:///tmp/csi-addons.sock", "CSI-Addons endpoint") klog.InitFlags(nil) if err := flag.Set("logtostderr", "true"); err != nil {