mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2024-12-18 11:00:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

examples: rbd/storageclass.yaml causes Python excetion with yamllint

Browse Source 
While running the 'make test' target and have 'yamllint' available, the
test fails with the following exception:

yamllint -s -d {extends: default, rules: {line-length: {allow-non-breakable-inline-mappings: true}},ignore: charts/*/templates/*.yaml} ./examples/rbd/storageclass.yaml
Traceback (most recent call last):
  File "/usr/local/bin/yamllint", line 11, in <module>
    sys.exit(run())
  File "/usr/local/lib/python3.6/site-packages/yamllint/cli.py", line 181, in run
    problems = linter.run(f, conf, filepath)
  File "/usr/local/lib/python3.6/site-packages/yamllint/linter.py", line 237, in run
    content = input.read()
  File "/usr/lib64/python3.6/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 1947: ordinal not in range(128)

The quotes used in the comments seem to be non-ascii characters.
Replacing these with standard " makes the test pass again.

This problem occurred while running tests in a container based on the
Ceph image (CentOS-7) with Python 3. Travis CI might still use Python 2
for yamllint, and hide the problem.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
This commit is contained in:
Niels de Vos 2020-03-24 08:48:27 +01:00 committed by mergify[bot]
parent ad0b8897bf
commit 825448825c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
examples/rbd/storageclass.yaml
View File

@ -40,8 +40,8 @@ parameters:
# mounter: rbd-nbd # mounter: rbd-nbd
# Instruct the plugin it has to encrypt the volume # Instruct the plugin it has to encrypt the volume
# By default it is disabled. Valid values are “true” or “false”. # By default it is disabled. Valid values are "true" or "false".
# A string is expected here, i.e. “true”, not true. # A string is expected here, i.e. "true", not true.
# encrypted: "true" # encrypted: "true"
# Use external key management system for encryption passphrases by specifying # Use external key management system for encryption passphrases by specifying