mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2024-12-18 02:50:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

rbd: prevent re-use of destroyed resources

Browse Source 
When an `.Destroy()` is called on an rbdImage (or rbdVolume or
rbdSnapshot), the IOContext, Connection and other attributes are
invalid. When using a destroyed resource that points to an object that
was allocated through librbd, the process most likely ends with a panic.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
This commit is contained in:
Niels de Vos 2024-09-25 11:36:32 +02:00 committed by mergify[bot]
parent f1379e4cc4
commit 8c252d58ea
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/rbd/rbd_util.go
View File

@ -390,15 +390,19 @@ func (ri *rbdImage) Connect(cr *util.Credentials) error {
func (ri *rbdImage) Destroy(ctx context.Context) { func (ri *rbdImage) Destroy(ctx context.Context) {
if ri.ioctx != nil { if ri.ioctx != nil {
ri.ioctx.Destroy() ri.ioctx.Destroy()
ri.ioctx = nil
} }
if ri.conn != nil { if ri.conn != nil {
ri.conn.Destroy() ri.conn.Destroy()
ri.conn = nil
} }
if ri.isBlockEncrypted() { if ri.isBlockEncrypted() {
ri.blockEncryption.Destroy() ri.blockEncryption.Destroy()
ri.blockEncryption = nil
} }
if ri.isFileEncrypted() { if ri.isFileEncrypted() {
ri.fileEncryption.Destroy() ri.fileEncryption.Destroy()
ri.fileEncryption = nil
} }
} }