From 98471b27fc7feb159bb1085255c3d8b6b033dc6d Mon Sep 17 00:00:00 2001
From: Madhu Rajanna <madhupr007@gmail.com>
Date: Mon, 28 Oct 2024 10:21:47 +0100
Subject: [PATCH] e2e: add a test case of ROX PVC-PVC clone

adding a test case to test below case for RBD

* Create PVC and application
* Scale down application pod
* Create PVC-PVC ROX clone
* Try to create many pods that use the ROX PVC
* Try to write the data and verify only read
access.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
---
 e2e/rbd.go | 113 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 112 insertions(+), 1 deletion(-)

diff --git a/e2e/rbd.go b/e2e/rbd.go
index c44a6441a..a29c1f5c9 100644
--- a/e2e/rbd.go
+++ b/e2e/rbd.go
@@ -3235,7 +3235,7 @@ var _ = Describe("RBD", func() {
 				}
 			})
 
-			By("create ROX PVC clone and mount it to multiple pods", func() {
+			By("create ROX PVC clone from snapshot and mount it to multiple pods", func() {
 				err := createRBDSnapshotClass(f)
 				if err != nil {
 					framework.Failf("failed to create storageclass: %v", err)
@@ -3375,6 +3375,117 @@ var _ = Describe("RBD", func() {
 				validateOmapCount(f, 0, rbdType, defaultRBDPool, volumesType)
 			})
 
+			By("create ROX PVC-PVC clone and mount it to multiple pods", func() {
+				// create PVC and bind it to an app
+				pvc, err := loadPVC(pvcPath)
+				if err != nil {
+					framework.Failf("failed to load PVC: %v", err)
+				}
+
+				pvc.Namespace = f.UniqueName
+				app, err := loadApp(appPath)
+				if err != nil {
+					framework.Failf("failed to load application: %v", err)
+				}
+				app.Namespace = f.UniqueName
+				err = createPVCAndApp("", f, pvc, app, deployTimeout)
+				if err != nil {
+					framework.Failf("failed to create PVC and application: %v", err)
+				}
+				// validate created backend rbd images
+				validateRBDImageCount(f, 1, defaultRBDPool)
+				validateOmapCount(f, 1, rbdType, defaultRBDPool, volumesType)
+
+				// delete pod as we should not create PVC clone for in-use pvc
+				err = deletePod(app.Name, app.Namespace, f.ClientSet, deployTimeout)
+				if err != nil {
+					framework.Failf("failed to delete application: %v", err)
+				}
+
+				// create ROX clone PVC from parent PVC
+				smartClonePVC, err := loadPVC(pvcSmartClonePath)
+				if err != nil {
+					framework.Failf("failed to load smart clone PVC: %v", err)
+				}
+
+				smartClonePVC.Namespace = f.UniqueName
+				smartClonePVC.Spec.DataSource.Name = pvc.Name
+				smartClonePVC.Spec.AccessModes = []v1.PersistentVolumeAccessMode{v1.ReadOnlyMany}
+				err = createPVCAndvalidatePV(f.ClientSet, smartClonePVC, deployTimeout)
+				if err != nil {
+					framework.Failf("failed to create PVC: %v", err)
+				}
+
+				// validate created backend rbd images
+				// parent pvc + tempClone + clone
+				validateRBDImageCount(f, 3, defaultRBDPool)
+				validateOmapCount(f, 2, rbdType, defaultRBDPool, volumesType)
+
+				appClone, err := loadApp(appClonePath)
+				if err != nil {
+					framework.Failf("failed to load application: %v", err)
+				}
+
+				totalCount := 3
+				appClone.Namespace = f.UniqueName
+				appClone.Spec.Volumes[0].PersistentVolumeClaim.ClaimName = smartClonePVC.Name
+				for i := range totalCount {
+					name := fmt.Sprintf("%s%d", f.UniqueName, i)
+					label := map[string]string{
+						"app": name,
+					}
+					appClone.Labels = label
+					appClone.Name = name
+					err = createApp(f.ClientSet, appClone, deployTimeout)
+					if err != nil {
+						framework.Failf("failed to create application: %v", err)
+					}
+				}
+
+				for i := range totalCount {
+					name := fmt.Sprintf("%s%d", f.UniqueName, i)
+					opt := metav1.ListOptions{
+						LabelSelector: "app=" + name,
+					}
+
+					filePath := appClone.Spec.Containers[0].VolumeMounts[0].MountPath + "/test"
+					_, stdErr := execCommandInPodAndAllowFail(
+						f,
+						"echo 'Hello World' > "+filePath,
+						appClone.Namespace,
+						&opt)
+					readOnlyErr := fmt.Sprintf("cannot create %s: Read-only file system", filePath)
+					if !strings.Contains(stdErr, readOnlyErr) {
+						framework.Failf(stdErr)
+					}
+				}
+
+				// delete app
+				for i := range totalCount {
+					name := fmt.Sprintf("%s%d", f.UniqueName, i)
+					appClone.Name = name
+					err = deletePod(appClone.Name, appClone.Namespace, f.ClientSet, deployTimeout)
+					if err != nil {
+						framework.Failf("failed to delete application: %v", err)
+					}
+				}
+
+				// delete PVC clone
+				err = deletePVCAndValidatePV(f.ClientSet, smartClonePVC, deployTimeout)
+				if err != nil {
+					framework.Failf("failed to delete PVC: %v", err)
+				}
+
+				// delete parent pvc
+				err = deletePVCAndValidatePV(f.ClientSet, pvc, deployTimeout)
+				if err != nil {
+					framework.Failf("failed to delete PVC: %v", err)
+				}
+				// validate created backend rbd images
+				validateRBDImageCount(f, 0, defaultRBDPool)
+				validateOmapCount(f, 0, rbdType, defaultRBDPool, volumesType)
+			})
+
 			By("validate PVC mounting if snapshot and parent PVC are deleted", func() {
 				err := createRBDSnapshotClass(f)
 				if err != nil {