Merge pull request #156 from Madhu-1/update-meta

Fix issues found in static check

.travis.yml

@@ -9,14 +9,22 @@ branches:
 
 go: 1.11.x
 
+env:
+  global:
+    - GO_METALINTER_VERSION="v3.0.0"
+
 install:
-  - curl -L https://git.io/vp6lP | sh
+  # install gometalinter
+  - >
+    curl -L
+    'https://github.com/alecthomas/gometalinter/blob/v3.0.0/scripts/install.sh'
+    | bash -s -- -b $GOPATH/bin "${GO_METALINTER_VERSION}"
 
 before_script:
   - GO_FILES=$(find . -iname '*.go' -type f | grep -v /vendor/)
 
 script:
-  - gometalinter --deadline=10m -j 4  --enable=megacheck --enable=misspell  --vendor ./...
+  - gometalinter --deadline=10m -j 4 --enable=misspell --enable=staticcheck --vendor ./...
   - test -z $(gofmt -s -l $GO_FILES)
   - make rbdplugin
   - make cephfsplugin

pkg/cephfs/volumeoptions.go

@@ -34,7 +34,7 @@ type volumeOptions struct {
 
 func validateNonEmptyField(field, fieldName string) error {
 	if field == "" {
-		return fmt.Errorf("Parameter '%s' cannot be empty", fieldName)
+		return fmt.Errorf("parameter '%s' cannot be empty", fieldName)
 	}
 
 	return nil
@@ -53,7 +53,7 @@ func (o *volumeOptions) validate() error {
 		}
 	} else {
 		if o.ProvisionVolume {
-			return fmt.Errorf("Non-empty field rootPath is in conflict with provisionVolume=true")
+			return fmt.Errorf("non-empty field rootPath is in conflict with provisionVolume=true")
 		}
 	}
 
@@ -75,7 +75,7 @@ func (o *volumeOptions) validate() error {
 func extractOption(dest *string, optionLabel string, options map[string]string) error {
 	opt, ok := options[optionLabel]
 	if !ok {
-		return fmt.Errorf("Missing required field %s", optionLabel)
+		return fmt.Errorf("missing required field %s", optionLabel)
 	}
 
 	*dest = opt
@@ -87,7 +87,7 @@ func validateMounter(m string) error {
 	case volumeMounterFuse:
 	case volumeMounterKernel:
 	default:
-		return fmt.Errorf("Unknown mounter '%s'. Valid options are 'fuse' and 'kernel'", m)
+		return fmt.Errorf("unknown mounter '%s'. Valid options are 'fuse' and 'kernel'", m)
 	}
 
 	return nil
@@ -134,7 +134,7 @@ func extractNewVolOpt(opts *volumeOptions, volOpt map[string]string) error {
 	}
 
 	if opts.ProvisionVolume, err = strconv.ParseBool(provisionVolumeBool); err != nil {
-		return fmt.Errorf("Failed to parse provisionVolume: %v", err)
+		return fmt.Errorf("failed to parse provisionVolume: %v", err)
 	}
 
 	if opts.ProvisionVolume {

pkg/rbd/controllerserver.go

@@ -338,7 +338,7 @@ func (cs *ControllerServer) CreateSnapshot(ctx context.Context, req *csi.CreateS
 		return nil, status.Errorf(codes.NotFound, "Source Volume ID %s cannot found", req.GetSourceVolumeId())
 	}
 	if !hasSnapshotFeature(rbdVolume.ImageFeatures) {
-		return nil, fmt.Errorf("Volume(%s) has not snapshot feature(layering)", req.GetSourceVolumeId())
+		return nil, fmt.Errorf("volume(%s) has not snapshot feature(layering)", req.GetSourceVolumeId())
 	}
 
 	rbdSnap.VolName = rbdVolume.VolName
@@ -437,7 +437,7 @@ func (cs *ControllerServer) doSnapshot(rbdSnap *rbdSnapshot, secret map[string]s
 			if err != nil {
 				return fmt.Errorf("snapshot is created but failed to protect and delete snapshot: %v", err)
 			}
-			return fmt.Errorf("Snapshot is created but failed to protect snapshot")
+			return fmt.Errorf("snapshot is created but failed to protect snapshot")
 		}
 	}
 	return nil

pkg/rbd/rbd_attach.go

@@ -299,7 +299,7 @@ func createPath(volOpt *rbdVolume, userID string, creds map[string]string) (stri
 	}
 	devicePath, found := waitForPath(volOpt.Pool, image, 10, useNBD)
 	if !found {
-		return "", fmt.Errorf("Could not map image %s, Timeout after 10s", imagePath)
+		return "", fmt.Errorf("could not map image %s, Timeout after 10s", imagePath)
 	}
 	return devicePath, nil
 }

pkg/rbd/rbd_util.go

@@ -231,13 +231,13 @@ func getRBDVolumeOptions(volOptions map[string]string) (*rbdVolume, error) {
 	rbdVol := &rbdVolume{}
 	rbdVol.Pool, ok = volOptions["pool"]
 	if !ok {
-		return nil, fmt.Errorf("Missing required parameter pool")
+		return nil, fmt.Errorf("missing required parameter pool")
 	}
 	rbdVol.Monitors, ok = volOptions["monitors"]
 	if !ok {
 		// if mons are not set in options, check if they are set in secret
 		if rbdVol.MonValueFromSecret, ok = volOptions["monValueFromSecret"]; !ok {
-			return nil, fmt.Errorf("Either monitors or monValueFromSecret must be set")
+			return nil, fmt.Errorf("either monitors or monValueFromSecret must be set")
 		}
 	}
 	rbdVol.ImageFormat, ok = volOptions["imageFormat"]
@@ -283,13 +283,13 @@ func getRBDSnapshotOptions(snapOptions map[string]string) (*rbdSnapshot, error)
 	rbdSnap := &rbdSnapshot{}
 	rbdSnap.Pool, ok = snapOptions["pool"]
 	if !ok {
-		return nil, fmt.Errorf("Missing required parameter pool")
+		return nil, fmt.Errorf("missing required parameter pool")
 	}
 	rbdSnap.Monitors, ok = snapOptions["monitors"]
 	if !ok {
 		// if mons are not set in options, check if they are set in secret
 		if rbdSnap.MonValueFromSecret, ok = snapOptions["monValueFromSecret"]; !ok {
-			return nil, fmt.Errorf("Either monitors or monValueFromSecret must be set")
+			return nil, fmt.Errorf("either monitors or monValueFromSecret must be set")
 		}
 	}
 	rbdSnap.AdminID, ok = snapOptions["adminid"]