cephfs: No-Op Unprotect call if "snapshot-autoprotect" feature present

The subvolume features consists the list of features, which if includes
"snapshot-autoprotect", result in query based approach to
detecting the need for protect/unprotect.
If "snapshot-autoprotect" feature is present, The UnprotectSnapshot
call should be treated as a no-op

Signed-off-by: Yug <yuggupta27@gmail.com>
This commit is contained in:
Yug 2020-09-16 19:15:28 +05:30 committed by mergify[bot]
parent 43a4c100ec
commit 9e959c45a3

View File

@ -27,7 +27,9 @@ import (
// autoProtect points to the snapshot auto-protect feature of // autoProtect points to the snapshot auto-protect feature of
// the subvolume. // the subvolume.
const autoProtect = "snapshot-autoprotect" const (
autoProtect = "snapshot-autoprotect"
)
// cephfsSnapshot represents a CSI snapshot and its cluster information. // cephfsSnapshot represents a CSI snapshot and its cluster information.
type cephfsSnapshot struct { type cephfsSnapshot struct {
@ -177,6 +179,11 @@ func protectSnapshot(ctx context.Context, volOptions *volumeOptions, cr *util.Cr
} }
func unprotectSnapshot(ctx context.Context, volOptions *volumeOptions, cr *util.Credentials, snapID, volID volumeID) error { func unprotectSnapshot(ctx context.Context, volOptions *volumeOptions, cr *util.Credentials, snapID, volID volumeID) error {
// If "snapshot-autoprotect" feature is present, The UnprotectSnapshot
// call should be treated as a no-op.
if checkSubvolumeHasFeature(autoProtect, volOptions.Features) {
return nil
}
args := []string{ args := []string{
"fs", "fs",
"subvolume", "subvolume",