added volumeNamePrefix and snapshotNamePrefix as parameters for storageClass

this allows administrators to override the naming prefix for both volumes and snapshots
created by the rbd plugin.

Signed-off-by: Reinier Schoof <reinier@skoef.nl>

pkg/rbd/nodeserver_test.go

@@ -0,0 +1,76 @@
+/*
+Copyright 2020 The Ceph-CSI Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package rbd
+
+import (
+	"testing"
+
+	"github.com/container-storage-interface/spec/lib/go/csi"
+)
+
+func TestGetLegacyVolumeName(t *testing.T) {
+	tests := []struct {
+		mountPath string
+		volName   string
+	}{
+		{"csi/vol/56a0cc34-a5c9-44ab-ad33-ed53dd2bd5ea/globalmount", "56a0cc34-a5c9-44ab-ad33-ed53dd2bd5ea"},
+		{"csi/vol/9fdb7491-3469-4414-8fe2-ea96be6f7f72/mount", "9fdb7491-3469-4414-8fe2-ea96be6f7f72"},
+		{"csi/vol/82cd91c4-4582-47b3-bb08-a84f8c5716d6", "82cd91c4-4582-47b3-bb08-a84f8c5716d6"},
+	}
+
+	for _, test := range tests {
+		if got, err := getLegacyVolumeName(test.mountPath); err != nil {
+			t.Errorf("getLegacyVolumeName(%s) returned error when it shouldn't: %s", test.mountPath, err.Error())
+		} else if got != test.volName {
+			t.Errorf("getLegacyVolumeName(%s) = %s, want %s", test.mountPath, got, test.volName)
+		}
+	}
+}
+
+func TestGetStagingPath(t *testing.T) {
+	var stagingPath string
+	// test with nodestagevolumerequest
+	nsvr := &csi.NodeStageVolumeRequest{
+		VolumeId:          "758978be-6331-4925-b25e-e490fe99c9eb",
+		StagingTargetPath: "/path/to/stage",
+	}
+
+	expect := "/path/to/stage/758978be-6331-4925-b25e-e490fe99c9eb"
+	stagingPath = getStagingTargetPath(nsvr)
+	if stagingPath != expect {
+		t.Errorf("getStagingTargetPath() = %s, got %s", stagingPath, expect)
+	}
+
+	// test with nodestagevolumerequest
+	nuvr := &csi.NodeUnstageVolumeRequest{
+		VolumeId:          "622cfdeb-69bf-4de6-9bd7-5fa0b71a603e",
+		StagingTargetPath: "/path/to/unstage",
+	}
+
+	expect = "/path/to/unstage/622cfdeb-69bf-4de6-9bd7-5fa0b71a603e"
+	stagingPath = getStagingTargetPath(nuvr)
+	if stagingPath != expect {
+		t.Errorf("getStagingTargetPath() = %s, got %s", stagingPath, expect)
+	}
+
+	// test with non-handled interface
+	expect = ""
+	stagingPath = getStagingTargetPath("")
+	if stagingPath != expect {
+		t.Errorf("getStagingTargetPath() = %s, got %s", stagingPath, expect)
+	}
+}