From bbfe06b3b937e35c5f793071917decede9f514c8 Mon Sep 17 00:00:00 2001 From: Praveen M Date: Tue, 20 Aug 2024 18:14:00 +0530 Subject: [PATCH] deploy: add immediate-topology flag to external-provisioner In csi-external-provisioner: v5.0.1, topology-aware provisioning is enabled by default. As a result provisioner now expects toologyKeys to be present in CSINode object which must be passed by user via `--domainlabels` flag in RBD nodeplugin. Issue: Users upgrading to v3.12.0 who were not previously using topology-aware provisioning may encounter issues when provisionining RBD PVCs, as the `--domainlabels` flag might not be set. Fix: To address this, add `--immediate-topology=false` to disable topology-aware provisioning. User requiring topology-aware provisioning should provided the volumeBindingMode as `WaitForFirstConsumer` and `TopologyConstrainedPools` as required in the StorageClass and configure `--domainlabels` flag in RBD nodeplugin. Signed-off-by: Praveen M (cherry picked from commit 55f221ff5099c5e2b21dd5be6fa593daf7d7d81c) --- deploy/rbd/kubernetes/csi-rbdplugin-provisioner.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/deploy/rbd/kubernetes/csi-rbdplugin-provisioner.yaml b/deploy/rbd/kubernetes/csi-rbdplugin-provisioner.yaml index 95f765889..0751ad379 100644 --- a/deploy/rbd/kubernetes/csi-rbdplugin-provisioner.yaml +++ b/deploy/rbd/kubernetes/csi-rbdplugin-provisioner.yaml @@ -115,6 +115,7 @@ spec: # if fstype is not specified in storageclass, ext4 is default - "--default-fstype=ext4" - "--extra-create-metadata=true" + - "--immediate-topology=false" env: - name: ADDRESS value: unix:///csi/csi-provisioner.sock