From c905dd863c0aa6efedc8296a23176cefc1c829f7 Mon Sep 17 00:00:00 2001 From: Niels de Vos Date: Thu, 30 Jan 2025 10:13:36 +0100 Subject: [PATCH] rbd: format log message correctly When a `dataPool` is passed while creating a volume, there is a `%!s(MISSING)` piece added to a debug log message. When concatinating strings, the `%s` formatter is not needed. Updates: #5103 Signed-off-by: Niels de Vos --- internal/rbd/rbd_util.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/rbd/rbd_util.go b/internal/rbd/rbd_util.go index 274981bfe..964a90f4b 100644 --- a/internal/rbd/rbd_util.go +++ b/internal/rbd/rbd_util.go @@ -1586,7 +1586,7 @@ func (rv *rbdVolume) constructImageOptions(ctx context.Context) (*librbd.ImageOp logMsg := fmt.Sprintf("setting image options on %s", rv) if rv.DataPool != "" { - logMsg += ", data pool %s" + rv.DataPool + logMsg += ", data pool " + rv.DataPool err = options.SetString(librbd.RbdImageOptionDataPool, rv.DataPool) if err != nil { return nil, fmt.Errorf("failed to set data pool: %w", err)