mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2025-06-13 02:33:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

journal: Add additional operation based locking

Browse Source 
As we are adding new functionalities like Create/Delete
snapshot,Clone from Snapshot and Clone from Volume.
with the current implementation, there are only serial
operations allowed for this functionalities, for some
function we can allow parallel operations like
Clone from snapshot and Clone from Volume and Create
`N` snapshots on a single volume.

Delete Volume: Need to ensure that there is no clone,
Snapshot create and  Expand volume in progress.

Expand Volume: Need to ensure that there is no clone,
snapshot create and cloning in progress

Delete Snapshot: Need to ensure that there is no
cloning in progress

Restore Volume/Snapshot: Need to ensure that there is
no Expand or delete operation in progress.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
This commit is contained in:
Madhu Rajanna
2020-07-13 08:07:33 +05:30
committed by mergify[bot]
parent 71ddf51544
commit d6348545ab
2 changed files with 279 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

81
internal/util/idlocker_test.go
View File

@ -50,3 +50,84 @@ func TestIDLocker(t *testing.T) {
true, ok)
}
}
func TestOperationLocks(t *testing.T) {
volumeID := "test-vol"
lock := NewOperationLock()
err := lock.GetCloneLock(volumeID)
if err != nil {
t.Errorf("failed to acquire clone lock for %s %s", volumeID, err)
}
err = lock.GetDeleteLock(volumeID)
if err == nil {
t.Errorf("expected to fail for GetDeleteLock for %s", volumeID)
}
err = lock.GetExpandLock(volumeID)
if err == nil {
t.Errorf("expected to fail for GetExpandLock for %s", volumeID)
}
lock.ReleaseCloneLock(volumeID)
// Get multiple clone operation
err = lock.GetCloneLock(volumeID)
if err != nil {
t.Errorf("failed to acquire clone lock for %s %s", volumeID, err)
}
err = lock.GetCloneLock(volumeID)
if err != nil {
t.Errorf("failed to acquire clone lock for %s %s", volumeID, err)
}
err = lock.GetCloneLock(volumeID)
if err != nil {
t.Errorf("failed to acquire clone lock for %s %s", volumeID, err)
}
// release all clone locks
lock.ReleaseCloneLock(volumeID)
lock.ReleaseCloneLock(volumeID)
lock.ReleaseCloneLock(volumeID)
// release extra lock it should not cause any issue as the key is already
// deleted from the map
lock.ReleaseCloneLock(volumeID)
// get multiple restore lock
err = lock.GetRestoreLock(volumeID)
if err != nil {
t.Errorf("failed to acquire restore lock for %s %s", volumeID, err)
}
err = lock.GetRestoreLock(volumeID)
if err != nil {
t.Errorf("failed to acquire restore lock for %s %s", volumeID, err)
}
err = lock.GetRestoreLock(volumeID)
if err != nil {
t.Errorf("failed to acquire restore lock for %s %s", volumeID, err)
}
// try for snapshot delete lock
err = lock.GetDeleteLock(volumeID)
if err == nil {
t.Errorf("expected to fail for GetDeleteLock for %s", volumeID)
}
// release all restore locks
lock.ReleaseRestoreLock(volumeID)
lock.ReleaseRestoreLock(volumeID)
lock.ReleaseRestoreLock(volumeID)
err = lock.GetSnapshotCreateLock(volumeID)
if err != nil {
t.Errorf("failed to acquire createSnapshot lock for %s %s", volumeID, err)
}
err = lock.GetDeleteLock(volumeID)
if err == nil {
t.Errorf("expected to fail for GetDeleteLock for %s", volumeID)
}
lock.ReleaseSnapshotCreateLock(volumeID)
err = lock.GetDeleteLock(volumeID)
if err != nil {
t.Errorf("failed to get GetDeleteLock for %s %v", volumeID, err)
}
lock.ReleaseDeleteLock(volumeID)
}