From d95b07e39bca3fa5eb016cd8a69cd6d16af7e379 Mon Sep 17 00:00:00 2001
From: Madhu Rajanna <madhupr007@gmail.com>
Date: Wed, 24 Jun 2020 12:47:21 +0530
Subject: [PATCH] rbd: implement rbd clone with go-ceph

moved the implementation of clone
from CLI to go-ceph

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
---
 internal/rbd/rbd_util.go | 33 ++++++++++++++++++++++++---------
 1 file changed, 24 insertions(+), 9 deletions(-)

diff --git a/internal/rbd/rbd_util.go b/internal/rbd/rbd_util.go
index 4ef4a0906..c2459d93c 100644
--- a/internal/rbd/rbd_util.go
+++ b/internal/rbd/rbd_util.go
@@ -757,18 +757,33 @@ func (rv *rbdVolume) deleteSnapshot(ctx context.Context, pOpts *rbdSnapshot) err
 	return err
 }
 
-// nolint: interfacer
-func restoreSnapshot(ctx context.Context, pVolOpts *rbdVolume, pSnapOpts *rbdSnapshot, cr *util.Credentials) error {
-	var output []byte
+func (rv *rbdVolume) cloneRbdImageFromSnapshot(ctx context.Context, pSnapOpts *rbdSnapshot) error {
+	image := rv.RbdImageName
+	var err error
+	klog.V(4).Infof(util.Log(ctx, "rbd: clone %s %s using mon %s"), pSnapOpts, image, rv.Monitors)
 
-	klog.V(4).Infof(util.Log(ctx, "rbd: clone %s using mon %s"), pVolOpts, pVolOpts.Monitors)
-	args := []string{"clone", pSnapOpts.String(), pVolOpts.String(),
-		"--id", cr.ID, "-m", pVolOpts.Monitors, "--keyfile=" + cr.KeyFile}
-
-	output, err := execCommand("rbd", args)
+	options := librbd.NewRbdImageOptions()
+	defer options.Destroy()
+	if rv.imageFeatureSet != 0 {
+		err = options.SetUint64(librbd.RbdImageOptionFeatures, uint64(rv.imageFeatureSet))
+		if err != nil {
+			return errors.Wrapf(err, "failed to set image features")
+		}
+	}
 
+	err = options.SetUint64(imageOptionCloneFormat, 2)
 	if err != nil {
-		return errors.Wrapf(err, "failed to restore snapshot, command output: %s", string(output))
+		return errors.Wrapf(err, "failed to set image features")
+	}
+
+	err = rv.openIoctx()
+	if err != nil {
+		return errors.Wrapf(err, "failed to get IOContext")
+	}
+
+	err = librbd.CloneImage(rv.ioctx, pSnapOpts.RbdImageName, pSnapOpts.RbdSnapName, rv.ioctx, rv.RbdImageName, options)
+	if err != nil {
+		return errors.Wrapf(err, "failed to create rbd clone")
 	}
 
 	return nil