mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2024-11-22 22:30:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

e2e: pass non-empty Namespace/Name in deletePVCAndPV()

Browse Source 
When getting the PVC or PV failed, the returned object may contain empty
values. If that happens, a retry uses the empty values for Namespace and
Name, which will never be successful.

Instead, use the Namespace and Name attributes from the original object,
and not from the object returned by the Get() call.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
This commit is contained in:
Niels de Vos 2022-06-24 18:25:20 +02:00 committed by mergify[bot]
parent 2df55a55a3
commit dbbda5473b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
e2e/pvc.go
View File

@ -138,8 +138,8 @@ func deletePVCAndPV(c kubernetes.Interface, pvc *v1.PersistentVolumeClaim, pv *v
pvcToDelete.Status.String(), pvcToDelete.Status.String(),
int(time.Since(start).Seconds())) int(time.Since(start).Seconds()))
pvcToDelete, err = c.CoreV1(). pvcToDelete, err = c.CoreV1().
PersistentVolumeClaims(pvcToDelete.Namespace). PersistentVolumeClaims(pvc.Namespace).
Get(context.TODO(), pvcToDelete.Name, metav1.GetOptions{}) Get(context.TODO(), pvc.Name, metav1.GetOptions{})
if err == nil { if err == nil {
if pvcToDelete.Status.Phase == "" { if pvcToDelete.Status.Phase == "" {
// this is unexpected, an empty Phase is not defined // this is unexpected, an empty Phase is not defined
@ -176,7 +176,7 @@ func deletePVCAndPV(c kubernetes.Interface, pvc *v1.PersistentVolumeClaim, pv *v
pvToDelete.Status.String(), pvToDelete.Status.String(),
int(time.Since(start).Seconds())) int(time.Since(start).Seconds()))
pvToDelete, err = c.CoreV1().PersistentVolumes().Get(context.TODO(), pvToDelete.Name, metav1.GetOptions{}) pvToDelete, err = c.CoreV1().PersistentVolumes().Get(context.TODO(), pv.Name, metav1.GetOptions{})
if err == nil { if err == nil {
return false, nil return false, nil
} }