mirror of
https://github.com/ceph/ceph-csi.git
synced 2025-06-03 04:16:42 +00:00
util: pass Servers by reference to Start()
This commit modifies nonBlockingGRPCServer.Start() to accept Servers parameter by reference rather than value to prevent copy of a large struct. Signed-off-by: Rakshith R <rar@redhat.com>
This commit is contained in:
parent
2217e5cc35
commit
dd93de0bfc
@ -193,7 +193,7 @@ func (fs *Driver) Run(conf *util.Config) {
|
||||
}
|
||||
|
||||
server := csicommon.NewNonBlockingGRPCServer()
|
||||
srv := csicommon.Servers{
|
||||
srv := &csicommon.Servers{
|
||||
IS: fs.is,
|
||||
CS: fs.cs,
|
||||
NS: fs.ns,
|
||||
|
@ -31,7 +31,7 @@ import (
|
||||
// NonBlockingGRPCServer defines Non blocking GRPC server interfaces.
|
||||
type NonBlockingGRPCServer interface {
|
||||
// Start services at the endpoint
|
||||
Start(endpoint string, srv Servers, middlewareConfig MiddlewareServerOptionConfig)
|
||||
Start(endpoint string, srv *Servers, middlewareConfig MiddlewareServerOptionConfig)
|
||||
// Waits for the service to stop
|
||||
Wait()
|
||||
// Stops the service gracefully
|
||||
@ -62,11 +62,11 @@ type nonBlockingGRPCServer struct {
|
||||
// Start start service on endpoint.
|
||||
func (s *nonBlockingGRPCServer) Start(
|
||||
endpoint string,
|
||||
srv Servers,
|
||||
srv *Servers,
|
||||
middlewareConfig MiddlewareServerOptionConfig,
|
||||
) {
|
||||
s.wg.Add(1)
|
||||
go s.serve(endpoint, srv, middlewareConfig)
|
||||
go s.serve(endpoint, *srv, middlewareConfig)
|
||||
}
|
||||
|
||||
// Wait blocks until the WaitGroup counter.
|
||||
|
@ -63,7 +63,7 @@ func (fs *Driver) Run(conf *util.Config) {
|
||||
|
||||
// Create gRPC servers
|
||||
server := csicommon.NewNonBlockingGRPCServer()
|
||||
srv := csicommon.Servers{
|
||||
srv := &csicommon.Servers{
|
||||
IS: identity.NewIdentityServer(cd),
|
||||
}
|
||||
|
||||
|
@ -189,7 +189,7 @@ func (r *Driver) Run(conf *util.Config) {
|
||||
}
|
||||
|
||||
s := csicommon.NewNonBlockingGRPCServer()
|
||||
srv := csicommon.Servers{
|
||||
srv := &csicommon.Servers{
|
||||
IS: r.ids,
|
||||
CS: r.cs,
|
||||
NS: r.ns,
|
||||
|
Loading…
x
Reference in New Issue
Block a user