mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2024-11-26 00:00:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

cephfs: no need to check for zero volume size

Browse Source 
At present there is a 'todo' to check for zero volume size
in the createVolume request which in unwanted, ie the pvc
creation with size 0 fail from the kubernetes api validation itself:

For ex:

```
..spec.resources[storage]: Invalid value: "0": must be greater than zero```
```
so we dont need any extra check in the controller server

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
This commit is contained in:
Humble Chirammal 2021-09-01 12:00:12 +05:30 committed by mergify[bot]
parent 9e55f015de
commit df2d9548ae
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
internal/cephfs/controllerserver.go
View File

@ -188,7 +188,6 @@ func (cs *ControllerServer) CreateVolume(
if req.GetCapacityRange() != nil { if req.GetCapacityRange() != nil {
volOptions.Size = util.RoundOffBytes(req.GetCapacityRange().GetRequiredBytes()) volOptions.Size = util.RoundOffBytes(req.GetCapacityRange().GetRequiredBytes())
} }
// TODO need to add check for 0 volume size
parentVol, pvID, sID, err := checkContentSource(ctx, req, cr) parentVol, pvID, sID, err := checkContentSource(ctx, req, cr)
if err != nil { if err != nil {