mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2025-01-11 22:39:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

ci: address shadowing of predeclared identifier

Browse Source 
- Comparing integers makes more sense than comparing the strings.

Signed-off-by: Praveen M <m.praveen@ibm.com>
This commit is contained in:
Praveen M 2024-12-20 11:14:51 +05:30 committed by mergify[bot]
parent d46029ca1f
commit dfc9bdaf03
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
e2e/utils.go
View File

@ -1580,10 +1580,17 @@ func k8sVersionGreaterEquals(c kubernetes.Interface, major, minor int) bool {
// return value.
}
maj := strconv.Itoa(major)
min := strconv.Itoa(minor)
vMajor, err := strconv.Atoi(v.Major)
if err != nil {
framework.Failf("failed to convert Kubernetes major version %q to int: %v", v.Major, err)
}
return (v.Major > maj) || (v.Major == maj && v.Minor >= min)
vMinor, err := strconv.Atoi(v.Minor)
if err != nil {
framework.Failf("failed to convert Kubernetes minor version %q to int: %v", v.Minor, err)
}
return (vMajor > major) || (vMajor == major && vMinor >= minor)
}
// waitForJobCompletion polls the status of the given job and waits until the