cleanup: run codespell on containerized testing

This commit adds a new target codespell to the
make containerized-test.

Fixes: #2229

Signed-off-by: Yati Padia <ypadia@redhat.com>
This commit is contained in:
Yati Padia 2021-08-11 10:33:37 +05:30 committed by Madhu Rajanna
parent 7fba62dd47
commit e077c1fdf5
4 changed files with 10 additions and 8 deletions

View File

@ -14,9 +14,4 @@ jobs:
steps: steps:
- uses: actions/checkout@v2 - uses: actions/checkout@v2
- name: codespell - name: codespell
uses: codespell-project/actions-codespell@master run: CONTAINER_CMD=docker make containerized-test TARGET=codespell
with:
skip: .git,./vendor,./docs/design/proposals/images
check_filenames: true
ignore_words_list: ExtraVersion,extraversion,ba
check_hidden: true

View File

@ -87,7 +87,7 @@ endif
all: cephcsi all: cephcsi
.PHONY: go-test static-check mod-check go-lint lint-extras gosec commitlint .PHONY: go-test static-check mod-check go-lint lint-extras gosec commitlint codespell
ifeq ($(CONTAINERIZED),no) ifeq ($(CONTAINERIZED),no)
# include mod-check in non-containerized runs # include mod-check in non-containerized runs
test: go-test static-check mod-check test: go-test static-check mod-check
@ -95,7 +95,7 @@ else
# exclude mod-check for containerized runs (CI runs it separately) # exclude mod-check for containerized runs (CI runs it separately)
test: go-test static-check test: go-test static-check
endif endif
static-check: check-env go-lint lint-extras gosec static-check: check-env codespell go-lint lint-extras gosec
go-test: TEST_COVERAGE ?= $(shell . $(CURDIR)/build.env ; echo $${TEST_COVERAGE}) go-test: TEST_COVERAGE ?= $(shell . $(CURDIR)/build.env ; echo $${TEST_COVERAGE})
go-test: GO_COVER_DIR ?= $(shell . $(CURDIR)/build.env ; echo $${GO_COVER_DIR}) go-test: GO_COVER_DIR ?= $(shell . $(CURDIR)/build.env ; echo $${GO_COVER_DIR})
@ -139,6 +139,8 @@ func-test:
check-env: check-env:
@./scripts/check-env.sh @./scripts/check-env.sh
codespell:
codespell --config scripts/codespell.conf
# #
# commitlint will do a rebase on top of GIT_SINCE when REBASE=1 is passed. # commitlint will do a rebase on top of GIT_SINCE when REBASE=1 is passed.
# #

View File

@ -29,6 +29,7 @@ RUN source /build.env \
librbd-devel \ librbd-devel \
rubygems \ rubygems \
ShellCheck \ ShellCheck \
codespell \
yamllint \ yamllint \
npm \ npm \
diffutils \ diffutils \

4
scripts/codespell.conf Normal file
View File

@ -0,0 +1,4 @@
[codespell]
skip = .git,./vendor,./docs/design/proposals/images
ignore-words-list = ExtraVersion,extraversion,ba
check-filenames = true