From e154eae73223911272877dc30ac13a0dbeeee0b3 Mon Sep 17 00:00:00 2001 From: Niels de Vos Date: Wed, 2 Oct 2024 17:11:43 +0200 Subject: [PATCH] cleanup: use `err` and `target` in recommended order to `errors.Is()` The documentation has `error.Is(err, target)`, so use this as the order of the parameters. Signed-off-by: Niels de Vos --- internal/rbd/group/volume_group.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/rbd/group/volume_group.go b/internal/rbd/group/volume_group.go index d23b26d99..bb1247e4c 100644 --- a/internal/rbd/group/volume_group.go +++ b/internal/rbd/group/volume_group.go @@ -187,7 +187,7 @@ func (vg *volumeGroup) Delete(ctx context.Context) error { } err = librbd.GroupRemove(ioctx, name) - if err != nil && !errors.Is(rados.ErrNotFound, err) { + if err != nil && !errors.Is(err, rados.ErrNotFound) { return fmt.Errorf("failed to remove volume group %q: %w", vg, err) } @@ -245,7 +245,7 @@ func (vg *volumeGroup) RemoveVolume(ctx context.Context, vol types.Volume) error err := vol.RemoveFromGroup(ctx, vg) if err != nil { - if errors.Is(librbd.ErrNotExist, err) { + if errors.Is(err, librbd.ErrNotExist) { return nil }