From e3fb20de216e7630030eaa2789e2fd4202e894c6 Mon Sep 17 00:00:00 2001 From: Yug Date: Fri, 21 Aug 2020 15:02:45 +0530 Subject: [PATCH] doc: Correct minor nits Correct development-guide doc with minor nit picks. Signed-off-by: Yug --- docs/development-guide.md | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/docs/development-guide.md b/docs/development-guide.md index 7436247d7..776a4be7d 100644 --- a/docs/development-guide.md +++ b/docs/development-guide.md @@ -201,22 +201,21 @@ and/or create an initial design doc PR. Once the design has been agreed upon one or more PRs implementing the plan can be made. **Review Process:** -Once your PR has been submitted for review the following critieria will +Once your PR has been submitted for review the following criteria will need to be met before it will be merged: -* Each PR needs reviews accepting the change from at least two developers -* for merging - * It is common to request reviews from those reviewers automatically suggested - * by github +* Each PR needs reviews accepting the change from at least two developers for merging. +* It is common to request reviews from those reviewers automatically suggested + by GitHub. * Each PR needs to have been open for at least 24 working hours to allow for -* community feedback - * The 24 working hours counts hours occuring Mon-Fri in the local timezone - * of the submitter + community feedback. +* The 24 working hours counts hours occurring Mon-Fri in the local timezone + of the submitter. * Each PR must be fully updated to master and tests must have passed * If the PR is having trivial changes or the reviewer is confident enough that PR doesn't need a second review, the reviewer can set `ready-to-merge` label on the PR. The bot will merge the PR if it's having one approval and the - label `ready-to-merge` + label `ready-to-merge`. When the criteria are met, a project maintainer can merge your changes into the project's master branch.