mirror of
https://github.com/ceph/ceph-csi.git
synced 2024-11-09 16:00:22 +00:00
cephfs: Set object lock for volumes for cephfs encryption
The way fscrypt client handles metadata and policy creation causing errors when multiple instances start simultaneously. This commit adds a lock to ensure the initial setup completes correctly, preventing race conditions and mismatches. Signed-off-by: Sunnatillo <sunnat.samadov@est.tech>
This commit is contained in:
parent
e71a95fece
commit
e7762ac1af
@ -23,6 +23,8 @@ import (
|
|||||||
"os"
|
"os"
|
||||||
"path"
|
"path"
|
||||||
"strings"
|
"strings"
|
||||||
|
"syscall"
|
||||||
|
"time"
|
||||||
|
|
||||||
cerrors "github.com/ceph/ceph-csi/internal/cephfs/errors"
|
cerrors "github.com/ceph/ceph-csi/internal/cephfs/errors"
|
||||||
"github.com/ceph/ceph-csi/internal/cephfs/mounter"
|
"github.com/ceph/ceph-csi/internal/cephfs/mounter"
|
||||||
@ -127,15 +129,72 @@ func maybeUnlockFileEncryption(
|
|||||||
stagingTargetPath string,
|
stagingTargetPath string,
|
||||||
volID fsutil.VolumeID,
|
volID fsutil.VolumeID,
|
||||||
) error {
|
) error {
|
||||||
if volOptions.IsEncrypted() {
|
if !volOptions.IsEncrypted() {
|
||||||
log.DebugLog(ctx, "cephfs: unlocking fscrypt on volume %q path %s", volID, stagingTargetPath)
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
return fscrypt.Unlock(ctx, volOptions.Encryption, stagingTargetPath, string(volID))
|
// Define Mutex Lock variables
|
||||||
|
lockName := string(volID) + "-mutexLock"
|
||||||
|
lockDesc := "Lock for " + string(volID)
|
||||||
|
lockDuration := 150 * time.Second
|
||||||
|
// Generate a consistent lock cookie for the client using hostname and process ID
|
||||||
|
lockCookie := generateLockCookie()
|
||||||
|
var flags byte = 0
|
||||||
|
|
||||||
|
log.DebugLog(ctx, "Creating lock for the following volume ID %s", volID)
|
||||||
|
|
||||||
|
ioctx, err := volOptions.GetConnection().GetIoctx(volOptions.MetadataPool)
|
||||||
|
if err != nil {
|
||||||
|
log.ErrorLog(ctx, "Failed to create ioctx: %s", err)
|
||||||
|
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
defer ioctx.Destroy()
|
||||||
|
|
||||||
|
res, err := ioctx.LockExclusive(volOptions.VolID, lockName, lockCookie, lockDesc, lockDuration, &flags)
|
||||||
|
if res != 0 {
|
||||||
|
switch res {
|
||||||
|
case -int(syscall.EBUSY):
|
||||||
|
return fmt.Errorf("Lock is already held by another client and cookie pair for %v volume", volID)
|
||||||
|
case -int(syscall.EEXIST):
|
||||||
|
return fmt.Errorf("Lock is already held by the same client and cookie pair for %v volume", volID)
|
||||||
|
default:
|
||||||
|
return fmt.Errorf("Failed to lock volume ID %v: %w", volID, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
log.DebugLog(ctx, "Lock successfully created for volume ID %s", volID)
|
||||||
|
|
||||||
|
log.DebugLog(ctx, "cephfs: unlocking fscrypt on volume %q path %s", volID, stagingTargetPath)
|
||||||
|
err = fscrypt.Unlock(ctx, volOptions.Encryption, stagingTargetPath, string(volID))
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
|
||||||
|
ret, err := ioctx.Unlock(string(volID), lockName, lockCookie)
|
||||||
|
switch ret {
|
||||||
|
case 0:
|
||||||
|
log.DebugLog(ctx, "Lock %s successfully released ", lockName)
|
||||||
|
case -int(syscall.ENOENT):
|
||||||
|
log.DebugLog(ctx, "Lock is not held by the specified %s, %s pair", lockCookie, lockName)
|
||||||
|
default:
|
||||||
|
log.ErrorLog(ctx, "Failed to release following lock, this will lead to orphan lock %s: %v",
|
||||||
|
lockName, err)
|
||||||
}
|
}
|
||||||
|
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// generateLockCookie generates a consistent lock cookie for the client.
|
||||||
|
func generateLockCookie() string {
|
||||||
|
hostname, err := os.Hostname()
|
||||||
|
if err != nil {
|
||||||
|
hostname = "unknown-host"
|
||||||
|
}
|
||||||
|
pid := os.Getpid()
|
||||||
|
|
||||||
|
return fmt.Sprintf("%s-%d", hostname, pid)
|
||||||
|
}
|
||||||
|
|
||||||
// maybeInitializeFileEncryption initializes KMS and node specifics, if volContext enables encryption.
|
// maybeInitializeFileEncryption initializes KMS and node specifics, if volContext enables encryption.
|
||||||
func maybeInitializeFileEncryption(
|
func maybeInitializeFileEncryption(
|
||||||
ctx context.Context,
|
ctx context.Context,
|
||||||
|
Loading…
Reference in New Issue
Block a user