mirrors/ceph-csi
1
0
Fork 0
mirror of https://github.com/ceph/ceph-csi.git synced 2025-03-06 07:29:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

e2e: validate RBD snapshot under temporary clone image is present

Browse Source 
Signed-off-by: Praveen M <m.praveen@ibm.com>
This commit is contained in:
Praveen M 2025-02-20 19:12:04 +05:30
parent c0de0a08c8
commit ebd3b128da
3 changed files with 48 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
e2e/rbd.go
View File

@ -184,6 +184,18 @@ func createORDeleteRbdResources(action kubectlAction) {
} }
} }
func validateRBDSnapshotCount(f *framework.Framework, count int, pool, image string) error{
snapshotList, err := listRBDSnapshots(f, pool, image)
if err != nil {
return fmt.Errorf("failed to list RBD snapshots: %v", err)
}
if len(snapshotList) != count {
return fmt.Errorf("RBD snapshots count not mactching, snapshot count for image %s/%s %d, expected %d", pool, image, len(snapshotList), count)
}
return nil
}
func validateRBDImageCount(f *framework.Framework, count int, pool string) { func validateRBDImageCount(f *framework.Framework, count int, pool string) {
imageList, err := listRBDImages(f, pool) imageList, err := listRBDImages(f, pool)
if err != nil { if err != nil {

26
e2e/rbd_helper.go
View File

@ -248,6 +248,13 @@ type imageInfoFromPVC struct {
pvName string pvName string
} }
type SnapInfo struct {
ID int `json:"id"`
Name string `json:"name"`
Size int64 `json:"size"`
Protected string `json:"protected"`
}
// getImageInfoFromPVC reads volume handle of the bound PV to the passed in PVC, // getImageInfoFromPVC reads volume handle of the bound PV to the passed in PVC,
// and returns imageInfoFromPVC or error. // and returns imageInfoFromPVC or error.
func getImageInfoFromPVC(pvcNamespace, pvcName string, f *framework.Framework) (imageInfoFromPVC, error) { func getImageInfoFromPVC(pvcNamespace, pvcName string, f *framework.Framework) (imageInfoFromPVC, error) {
@ -715,6 +722,25 @@ func librbdSupportsVolumeGroupSnapshot(f *framework.Framework) (bool, error) {
return strings.TrimSpace(stdout) == "0", nil return strings.TrimSpace(stdout) == "0", nil
} }
func listRBDSnapshots(f *framework.Framework, pool, image string) ([]SnapInfo, error) {
var snapInfos []SnapInfo
command := fmt.Sprintf("rbd snap ls --format=json %s %s", rbdOptions(pool), image)
stdout, stdErr, err := execCommandInToolBoxPod(f, command, rookNamespace)
if err != nil {
return snapInfos, err
}
if stdErr != "" {
return snapInfos, fmt.Errorf("failed to list RBD snapshots %v", stdErr)
}
err = json.Unmarshal([]byte(stdout), &snapInfos)
if err != nil {
return snapInfos, err
}
return snapInfos, nil
}
func listRBDImages(f *framework.Framework, pool string) ([]string, error) { func listRBDImages(f *framework.Framework, pool string) ([]string, error) {
var imgInfos []string var imgInfos []string

10
e2e/utils.go
View File

@ -1003,6 +1003,16 @@ func validatePVCClone(
if wgErrs[n] == nil && validatePVC != nil && kms != noKMS { if wgErrs[n] == nil && validatePVC != nil && kms != noKMS {
wgErrs[n] = validatePVC(f, &p, &a) wgErrs[n] = validatePVC(f, &p, &a)
} }
if wgErrs[n] == nil {
// validate RBD snapshot under temporary clone is not deleted.
imageData, err := getImageInfoFromPVC(p.Namespace, name, f)
if err != nil {
wgErrs[n] = err
} else {
cloneRBDImageName := fmt.Sprintf("%s-temp", imageData.imageName)
wgErrs[n] = validateRBDSnapshotCount(f, 1, defaultRBDPool, cloneRBDImageName)
}
}
wg.Done() wg.Done()
}(i, *pvcClone, *appClone) }(i, *pvcClone, *appClone)
} }