mirror of
https://github.com/ceph/ceph-csi.git
synced 2024-11-10 00:10:20 +00:00
discard umount error if directory is not mounted
if the directory is not mounted return nil
during umount of mountPoint
Discard error if error is os.IsNotExist
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit dcafdb519e
)
This commit is contained in:
parent
7912ec0040
commit
eddfc123e5
@ -267,7 +267,8 @@ func (ns *NodeServer) NodeUnpublishVolume(ctx context.Context, req *csi.NodeUnpu
|
|||||||
return nil, status.Error(codes.Internal, err.Error())
|
return nil, status.Error(codes.Internal, err.Error())
|
||||||
}
|
}
|
||||||
|
|
||||||
if err = os.Remove(targetPath); err != nil {
|
err = os.Remove(targetPath)
|
||||||
|
if err != nil && !os.IsNotExist(err) {
|
||||||
return nil, status.Error(codes.Internal, err.Error())
|
return nil, status.Error(codes.Internal, err.Error())
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -321,6 +321,10 @@ func bindMount(ctx context.Context, from, to string, readOnly bool, mntOptions [
|
|||||||
|
|
||||||
func unmountVolume(ctx context.Context, mountPoint string) error {
|
func unmountVolume(ctx context.Context, mountPoint string) error {
|
||||||
if err := execCommandErr(ctx, "umount", mountPoint); err != nil {
|
if err := execCommandErr(ctx, "umount", mountPoint); err != nil {
|
||||||
|
if strings.Contains(err.Error(), fmt.Sprintf("exit status 32: umount: %s: not mounted", mountPoint)) ||
|
||||||
|
strings.Contains(err.Error(), "No such file or directory") {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -155,7 +155,7 @@ func (nc *NodeCache) Delete(identifier string) error {
|
|||||||
file := path.Join(nc.BasePath, nc.CacheDir, identifier+".json")
|
file := path.Join(nc.BasePath, nc.CacheDir, identifier+".json")
|
||||||
err := os.Remove(file)
|
err := os.Remove(file)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
if err == os.ErrNotExist {
|
if os.IsNotExist(err) {
|
||||||
klog.V(4).Infof("node-cache: cannot delete missing metadata storage file %s, assuming it's already deleted", file)
|
klog.V(4).Infof("node-cache: cannot delete missing metadata storage file %s, assuming it's already deleted", file)
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user