journal: remove SetNamespace setter function

The SetNamespace setter function was called only once, immediately after
the creation of a volume journal object in cephfs only.
Remove this function so that it is no longer implied that this field can
be mutated after the journal is created. In it's place, use an extended
"constructor" NewCSIVolumeJournalWithNamespace that takes a namespace
value at create-time only.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

internal/cephfs/driver.go

@@ -110,11 +110,8 @@ func (fs *Driver) Run(conf *util.Config, cachePersister util.CachePersister) {
 		CSIInstanceID = conf.InstanceID
 	}
 	// Create an instance of the volume journal
-	volJournal = journal.NewCSIVolumeJournal(CSIInstanceID)
+	volJournal = journal.NewCSIVolumeJournalWithNamespace(CSIInstanceID, radosNamespace)
 
-	// Update namespace for storing keys into a specific namespace on RADOS, in the CephFS
-	// metadata pool
-	volJournal.SetNamespace(radosNamespace)
 	// Initialize default library driver
 
 	fs.cd = csicommon.NewCSIDriver(conf.DriverName, util.DriverVersion, conf.NodeID)

internal/journal/voljournal.go

@@ -176,6 +176,14 @@ func NewCSISnapshotJournal(suffix string) *CSIJournal {
 	}
 }
 
+// NewCSIVolumeJournalWithNamespace returns an instance of CSIJournal for
+// volumes using a predetermined namespace value.
+func NewCSIVolumeJournalWithNamespace(suffix, ns string) *CSIJournal {
+	j := NewCSIVolumeJournal(suffix)
+	j.namespace = ns
+	return j
+}
+
 // GetNameForUUID returns volume name
 func (cj *CSIJournal) GetNameForUUID(prefix, uid string, isSnapshot bool) string {
 	if prefix == "" {
@@ -188,11 +196,6 @@ func (cj *CSIJournal) GetNameForUUID(prefix, uid string, isSnapshot bool) string
 	return prefix + uid
 }
 
-// SetNamespace sets the namespace in which all RADOS objects would be created
-func (cj *CSIJournal) SetNamespace(ns string) {
-	cj.namespace = ns
-}
-
 // ImageData contains image name and stored CSI properties
 type ImageData struct {
 	ImageUUID       string