From fe947eccce63944571153b853841c7367b79e7f8 Mon Sep 17 00:00:00 2001 From: Madhu Rajanna Date: Thu, 29 Jul 2021 16:17:52 +0530 Subject: [PATCH] build: install specific commitlint version commitlint 13.1.0 is causing issues when PR is backported from devel branch to release branch https://github.com/ceph/ceph-csi/pull/2332#issuecomment-888325775 Lets revert back to commitlint 12.1.4 where we have not seen any issue with backports to release branch. Signed-off-by: Madhu Rajanna --- build.env | 3 +++ scripts/Dockerfile.test | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/build.env b/build.env index f113a323c..a5ed3056a 100644 --- a/build.env +++ b/build.env @@ -19,6 +19,9 @@ CEPH_VERSION=octopus GOLANG_VERSION=1.16.4 GO111MODULE=on +# commitlint version +COMMITLINT_VERSION=12.1.4 + # static checks and linters GOLANGCI_VERSION=v1.39.0 GOSEC_VERSION=v2.7.0 diff --git a/scripts/Dockerfile.test b/scripts/Dockerfile.test index e1bc3dad7..0178594a6 100644 --- a/scripts/Dockerfile.test +++ b/scripts/Dockerfile.test @@ -44,7 +44,7 @@ RUN source /build.env \ && curl -L https://git.io/get_helm.sh | bash -s -- --version "${HELM_VERSION}" \ && mkdir /opt/commitlint && pushd /opt/commitlint \ && npm init -y \ - && npm install @commitlint/cli \ + && npm install @commitlint/cli@"${COMMITLINT_VERSION}" \ && popd \ && true