The new 'funcorder' linter expects all public functions to be placed
before private functions of a struct. Many private functions needed
moving further down into their files.
Some files had many issues reported. To reduce the churn in those files,
they have been annotated with a `//nolint:funcorder` comment.
Signed-off-by: Niels de Vos <ndevos@ibm.com>
The golangci 'gosec' linter complains about permissions that could be
more secure. These have been modified or annotated on.
Signed-off-by: Niels de Vos <ndevos@ibm.com>
This commit fixes a bug in health checker that
caused shared checker to get keyed with volumeID+volumepath
instead of just volumeID and the other way around
for non-shared checkers.
Signed-off-by: Rakshith R <rar@redhat.com>
