360df61eb0
ci: github.event.pull_request.merged is a boolean, not a string
...
With the updates to the pull-request-commenter, all strings were placed
within `'` to prevent syntax issues. It seems that
`github.event.pull_request.merged` really is a boolean (or `null`), and
not a string.
Doc: https://docs.github.com/en/webhooks-and-events/ ("payloads" section)
Signed-off-by: Niels de Vos <ndevos@ibm.com >
2023-05-31 09:44:25 +00:00
b804181a3d
ci: remove \ from GitHub Workflow if condition
...
Backslashes (`\`) cause issues in the `if` statment with GitHub
Workflows.
Unexpected symbol: '\'. Located at position 53 within expression:
(github.event.pull_request.label == 'ok-to-test' && \
Using the `>` YAML syntax to replace linebreaks with spaces should
address this problem.
Signed-off-by: Niels de Vos <ndevos@ibm.com >
2023-05-31 07:44:13 +00:00
27dc4f0fde
ci: fix syntax error in pull-request-commenter GitHub Workflow
...
The `ok-to-test` label does not work anymore, and the GitHub Workflow
contains the following error:
The workflow is not valid.
.github/workflows/pull-request-commentor.yaml (Line: 15, Col: 9):
Unrecognized named-value: 'ok-to-test'.
Signed-off-by: Niels de Vos <ndevos@ibm.com >
2023-05-30 14:00:27 +00:00
cf0fd2bfeb
ci: fix pull-request-commentor workflow
...
Fix if condition in workflow to account
for ok-to-test label on newly created prs.
Signed-off-by: Rakshith R <rar@redhat.com >
2023-05-26 12:15:07 +00:00
b157b1a7c2
ci: trigger Add comment workflow for "opened" prs
...
The `Add comment` workflow was triggered only
when labels were added to the pr and failed
to be run on prs which were created with the
required label.
This commit makes sure the workflow is triggered
on pr creation too.
Signed-off-by: Rakshith R <rar@redhat.com >
2023-05-26 09:22:16 +00:00
c63af2108e
ci: switch back to official label copier & always add ok-to-test label
...
Signed-off-by: Rakshith R <rar@redhat.com >
2023-05-19 07:40:10 +00:00
6547868611
ci: checkout the local mergify-merge-queue-labels-copier
...
Without checking out the repository, it is not possible to run the local
action.
Signed-off-by: Niels de Vos <ndevos@ibm.com >
2023-05-15 16:37:11 +00:00
e46f65640c
ci: rename gha-mergify-merge-queue-labels-copier.yaml to action.yaml
...
It seems to be required to have the GitHub Action called `action.yaml`.
Signed-off-by: Niels de Vos <ndevos@ibm.com >
2023-05-15 15:22:12 +00:00
b371337287
ci: use modified gha-mergify-merge-queue-labels-copier Action
...
The original Mergifyio/gha-mergify-merge-queue-labels-copier@main
contains `startsWith()` that has the arguments reversed. This prevents
the action from working as intended.
See-also: https://docs.github.com/en/actions/learn-github-actions/expressions
Signed-off-by: Niels de Vos <ndevos@ibm.com >
2023-05-15 14:47:53 +00:00
52ebfa6b97
ci: include ci/skip/.. labels for copying into merge queue PRs
...
Setting an empty `labels:` fails to work as intended, no labels get
copied ad all. Now setting the `ci/skip/..` labels, as those are most
important for speeding up merging.
Signed-off-by: Niels de Vos <ndevos@ibm.com >
2023-05-15 12:47:40 +00:00
745d2ace92
ci: Mergify copy-labels requires empty string for labels:
...
Instead of leaving the `labels:` empty, pass an empty string `""`.
Signed-off-by: Niels de Vos <ndevos@ibm.com >
2023-05-15 08:03:28 +00:00
40eff59d45
ci: Mergify copy-labels requires empty labels: value
...
See-also: Mergifyio/mergify#5088
Signed-off-by: Niels de Vos <ndevos@ibm.com >
2023-05-15 07:24:04 +00:00
c37ac53cbb
ci: add GitHub Workflow to copy labels in Mergify created PRs
...
When Mergify creates a PR, the `ok-to-test` label needs to be added
before CI runs. Not all PRs need complete testing, and they may have
some `ci/skip/..` labels too. With this new GitHub Workflow, the labels
get copied from the original PR into the newly created PR.
See-also: https://github.com/Mergifyio/mergify/discussions/5088
Signed-off-by: Niels de Vos <ndevos@ibm.com >
2023-05-11 11:05:46 +00:00
c702264708
rebase: bump peter-evans/create-or-update-comment from 2 to 3
...
Bumps [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment ) from 2 to 3.
- [Release notes](https://github.com/peter-evans/create-or-update-comment/releases )
- [Commits](https://github.com/peter-evans/create-or-update-comment/compare/v2...v3 )
---
updated-dependencies:
- dependency-name: peter-evans/create-or-update-comment
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-25 11:34:17 +00:00
1bc090d975
ci: update github actions for k8s 1.27
...
Signed-off-by: riya-singhal31 <rsinghal@redhat.com >
2023-04-21 08:18:33 +00:00
60248ce811
ci: remove kubernetes 1.23 from github action
...
Removed kubernetes 1.23 from github action
as 1.23 is not supported anymore.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2023-04-21 06:46:30 +00:00
cb05525d4f
rebase: Bump peter-evans/create-or-update-comment from 2 to 3
...
Bumps [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment ) from 2 to 3.
- [Release notes](https://github.com/peter-evans/create-or-update-comment/releases )
- [Commits](https://github.com/peter-evans/create-or-update-comment/compare/v2...v3 )
---
updated-dependencies:
- dependency-name: peter-evans/create-or-update-comment
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-13 08:46:07 +00:00
ac5d58f30e
rebase: Bump actions/stale from 7 to 8
...
Bumps [actions/stale](https://github.com/actions/stale ) from 7 to 8.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/stale/compare/v7...v8 )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-28 07:10:20 +00:00
c84b4a15ba
ci: only run test-retest-action if the PR modifies the action
...
There is no need to run the `test-retest-action` GitHub Workflow if
there are no changes under the `actions/retest` directory.
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2023-02-21 10:58:52 +00:00
3325e5045e
ci: do not run commitlint GitHub Action on dependabot PRs
...
Currently commitlint is only skipped for PR at the time dependabot
creates them. Once Mergify rebases them, commitlint is started anyway.
This causes failed CI runs, which then need to be ignored. It is cleaner
to not run commitlint on any PR that dependabot owns.
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2023-02-21 10:58:52 +00:00
48822d942d
ci: use context.issue.number for removing ok-to-test
...
`github.event.pull_request.number` does not seem to be valid as a script
object/variable.
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2023-02-20 12:34:15 +00:00
3252c1e782
ci: remove ok-to-test label after commenting
...
Once the comments have been added, the `ok-to-test` label can be
removed. This makes it possible to simplify the Mergify configuration.
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2023-02-20 11:10:23 +01:00
c3bc1f720b
ci: add Kubernetes 1.26 as default version to test
...
Kubernetes 1.26 has been released at the end of 2022 and should be
tested frequently.
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2023-01-31 08:30:38 +00:00
911bc6eabc
rebase: bump actions/stale from 6 to 7
...
Bumps [actions/stale](https://github.com/actions/stale ) from 6 to 7.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/stale/compare/v6...v7 )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-04 09:45:15 +00:00
f0cc5a0ef8
rebase: bump actions/dependency-review-action from 2 to 3
...
Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action ) from 2 to 3.
- [Release notes](https://github.com/actions/dependency-review-action/releases )
- [Commits](https://github.com/actions/dependency-review-action/compare/v2...v3 )
---
updated-dependencies:
- dependency-name: actions/dependency-review-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-11-17 13:00:22 +00:00
38c4832665
ci: do not leave testing comments on merged PRs
...
A PR with status `github.event.pull_request.merged == true` does not
need to be tested again.
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2022-11-11 11:35:05 +00:00
f19805a40b
ci: consider kubernetes 1.25 for tests
...
As we have successful runs with kubernetes
1.25 Marking is as default for CI jobs and
required for merging PR.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2022-10-28 15:57:05 +02:00
4039bf5063
ci: remove kubernetes 1.22 tests
...
As we need to test with last 3 Kubernetes
releases removing Kubernetes 1.22
as we have 1.23, 1.24 and 1.25
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2022-10-28 15:57:05 +02:00
659567cfdc
ci: add github action to trigger E2E
...
based on the discussion on the slack
channel. we are adding a github action
to trigger the CI jobs when a ok-to-test
label is added on the PR.
This action is based on below github action
https://github.com/peter-evans/create-or-update-comment
Sample Demo avaiable at
https://github.com/Madhu-1/
\label-commentor-action-testing/pull/4
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2022-10-26 06:59:22 +00:00
5c8564c69d
rebase: bump actions/stale from 5 to 6
...
Bumps [actions/stale](https://github.com/actions/stale ) from 5 to 6.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/stale/compare/v5...v6 )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-04 06:40:14 +00:00
842279b811
ci: use ubuntu-latest for stale job
...
Currently, we use the Ubuntu 18.04 actions runner
for stale job. This runner will be deprecated
and removed in the beginning of Dec.
So should change the runner to use latest ubuntu.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2022-08-16 07:00:44 +00:00
05ccb31a45
rebase: bump actions/dependency-review-action from 1 to 2
...
Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action ) from 1 to 2.
- [Release notes](https://github.com/actions/dependency-review-action/releases )
- [Commits](https://github.com/actions/dependency-review-action/compare/v1...v2 )
---
updated-dependencies:
- dependency-name: actions/dependency-review-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-06-24 08:17:57 +00:00
60281fab40
ci: included dependency review
...
Dependency Review GitHub Action in your repository to enforce dependency
reviews on your pull requests.
Signed-off-by: Naveen <172697+naveensrinivasan@users.noreply.github.com >
2022-05-24 06:48:22 +00:00
bbecb81d4f
ci: add ci/skip/multi-arch-build label
...
If the `ci/skip/multi-arch-build` label is set on a PR, the GitHub
Workflow only builds for the local architecture. This makes it possible
to merge PRs faster.
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2022-05-10 06:08:22 +00:00
6d23e750be
rebase: bump docker/login-action from 1 to 2
...
Bumps [docker/login-action](https://github.com/docker/login-action ) from 1 to 2.
- [Release notes](https://github.com/docker/login-action/releases )
- [Commits](https://github.com/docker/login-action/compare/v1...v2 )
---
updated-dependencies:
- dependency-name: docker/login-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-05-10 05:02:33 +00:00
b4ff3884f1
ci: remove set-safe-directory from commitlint
...
Removed set-safe-directory option from the
commitlint.yaml as its not working as expected.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2022-05-09 05:57:14 +00:00
9533889b64
ci: do not set safe.directory for commitlint checkout
...
Commitlint fails with errors like:
```
git fetch -v origin devel
fatal: unsafe repository ('/go/src/github.com/ceph/ceph-csi' is owned by
someone else)
To add an exception for this directory, call:
git config --global --add safe.directory /go/src/github.com/ceph/ceph-csi
make: *** [Makefile:153: commitlint] Error 128
```
By not setting the option with actions/checkout@v3, the error should not
happen anymore.
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2022-05-09 03:10:04 +00:00
2672fad90a
ci: Set permissions for GitHub actions
...
Restrict the GitHub token permissions only to the required ones; this way,
even if the attackers will succeed in compromising your workflow,
they won’t be able to do much.
- Included permissions for the action.
https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions
https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com >
naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com >
2022-05-05 20:21:15 +05:30
b1a0f42b31
rebase: bump actions/checkout from 2 to 3
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v2...v3 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-05-05 12:47:46 +00:00
194db3edd5
rebase: bump actions/stale from 3 to 5
...
Bumps [actions/stale](https://github.com/actions/stale ) from 3 to 5.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/stale/compare/v3...v5 )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-05-05 10:29:39 +00:00
6dd5fe9360
ci: use CEPH_CSI_BOT token for retest action
...
For retest action's comment `@Mergifyio refresh`
to be accepted by mergifyio,
the bot should have write permissions to the repo.
Therefore, use Ceph-csi-bot instead of github actions
bot.
Signed-off-by: Rakshith R <rar@redhat.com >
2022-03-18 05:27:49 +00:00
73ecf06f97
ci: rename golangci linter github action file to proper name
...
Signed-off-by: Humble Chirammal <hchiramm@redhat.com >
2021-12-07 09:12:10 +00:00
8488d6bec2
ci: fix helm chart push for release branches
...
Currently BRANCH_NAME for release branches is not set causing
the source in helm chart to be set as
sources:
- https://github.com/ceph/ceph-csi/tree//charts/ceph-csi-cephfs
Current change fixes it.
Signed-off-by: Rakshith R <rar@redhat.com >
2021-11-22 07:55:59 +00:00
0a5bd09a61
ci: fix branch name in retest action
...
updated the branch name from main to
devel in retest action workflow.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2021-11-17 05:50:43 +00:00
b62de1376d
ci: update github workflow to test docker build
...
updated github action to test a retest action
docker build workflow.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2021-11-17 05:50:43 +00:00
f9f465073f
ci: add github action to build retest
...
added basic github action for
retest building.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2021-11-16 12:03:36 +00:00
ed6d28a1fc
ci: add action to retest failed approved PR's
...
Adding github action to retest the failed
approved PR's. sample output is available
at https://github.com/Madhu-1/retest-action/pull/3
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com >
2021-11-16 12:03:36 +00:00
191b603974
ci: remove gh action gosec linter,since it is already part of golangci
...
This commit removes gosec standalone linter and related parts,
since golangci linter runs gosec linter too.
Signed-off-by: Rakshith R <rar@redhat.com >
2021-11-16 12:29:56 +01:00
97525f5e74
ci: add make go-test-api to GitHub Action
...
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2021-10-05 11:26:50 +00:00
28899a36c8
ci: do not run commitlint GitHub Action for dependabot
...
The commit messages that Dependabot (@app/dependabot) creates are not
always accepted by the commitlint check. The configuration for
dependabot does not give a lot of options to customize the message, so
instead of adjusting the message to pass commitlint, just skip the check
(Mergify does not require commitlint status either).
See-also: #2460
Signed-off-by: Niels de Vos <ndevos@redhat.com >
2021-09-01 15:02:18 +02:00
