f670c62526
Remove userID and key logging from rbd
...
Fixes : #171
2019-02-08 12:40:48 +05:30
cb77ff5d87
Migrate rbd package to klog from glog
...
Signed-off-by: Humble Chirammal <hchiramm@redhat.com >
2019-02-05 12:09:04 +00:00
5983fedddb
Fix issues found in gometalinter static check
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-02-04 10:44:37 +05:30
74796bd57b
Fix review comment
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-29 18:29:07 +05:30
03d93219d7
Fix metalinter issue
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-29 11:37:03 +05:30
50ba8ed446
Fix gometalinter issues
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-29 11:24:36 +05:30
ca2e475296
Fix gometalinter issues
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-29 11:23:50 +05:30
7a0c233c27
Fix issues found in gometalinter
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-29 11:20:35 +05:30
25642fe404
Add method comments
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-29 11:20:35 +05:30
b71a9bfe40
Fix issue with error handling in metadata store
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-28 10:26:57 +05:30
aa4fce2c8b
Merge pull request #133 from Madhu-1/fix-golint
...
Fix golint
2019-01-27 10:04:42 -05:00
48ca11336e
Fix snapshot time during snapshot create
...
Fixes : #146
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-25 19:09:35 +05:30
7fcbdfb945
Fix template to add userID
...
Fix Node server
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-25 14:20:32 +05:30
284c5801c3
Fix golint issue
...
pkg/rbd/rbd.go:67:65⚠️ exported func NewNodeServer
returns unexported type *rbd.nodeServer, which can be
annoying to use (golint)
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-25 14:16:03 +05:30
1d11d0acc3
Fix lint issues
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-25 14:15:25 +05:30
5eb1974e38
Fix vetshadow issues
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-25 14:15:25 +05:30
49c8fe5d50
Remove conversion which is not required
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-25 14:14:48 +05:30
1c03334a90
Add constant for rbd and ndb
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-25 14:14:48 +05:30
fa78c00535
update struct names and struct fiels
...
it wont be meaningful to call cephfs.NewcephfsDriver()
to get a new driver, it will be better if we call
cephfs.GetNewDriver() which returns the cephfs driver
object.
same goes for rbd also
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-25 14:14:48 +05:30
15b5b0112e
rename Id to ID to fix lint issue
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-25 14:14:48 +05:30
8f2941dd47
Remove code complexity
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-25 14:13:04 +05:30
de1f099680
Remove unused struct fields
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-25 14:10:52 +05:30
9f76f6bd59
Remove dead code
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-25 14:10:52 +05:30
c6c496ff59
switch to node registrar
2019-01-22 14:46:41 -05:00
48407e2484
add csi volume device mount path to csi plugin
...
Signed-off-by: Huamin Chen <hchen@redhat.com >
2019-01-17 08:57:18 -05:00
263c45bb45
enable csi block; use canary external-provisioner image to pick up block volume provisioning
...
Signed-off-by: Huamin Chen <hchen@redhat.com >
2019-01-16 13:52:45 -05:00
0e60dabca3
Move resolving bind mount logic from k8s
2019-01-16 13:00:48 -05:00
ea75a9d162
Fix pv deletion issue caused by not dettaching due to wrong mount count
2019-01-16 12:51:13 -05:00
5867d495fd
Change csi rbd to create/delete targetPath for publish/unpublish
2019-01-16 12:50:17 -05:00
165b82a44c
Add block supports to rbd driver
2019-01-16 12:49:02 -05:00
e42e66ff30
user errors.New if error formatting is not required
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-16 18:54:13 +05:30
17f5c0a7ce
use Errorf is error formatting is required
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-16 18:54:06 +05:30
20af5afcab
Fix golint issues
...
Signed-off-by: Madhu Rajanna <mrajanna@redhat.com >
2019-01-16 18:33:38 +05:30
aed7506d88
fix merge leftovers; use canary driver-registrar image, as v1.0.0 is not hosted in quay.io
...
Signed-off-by: Huamin Chen <hchen@redhat.com >
2019-01-15 13:31:06 -05:00
e46099a504
reconcile merge
...
Signed-off-by: Huamin Chen <hchen@redhat.com >
2019-01-15 16:20:41 +00:00
85b8415024
Merge branch 'master' into master-to-1.0
2019-01-15 16:15:30 +00:00
62d65ad0cb
cm metadata persist for rbd and cephfs
2019-01-14 20:15:09 +00:00
51d6ac6f55
rbd: refuse to create block volumes
...
Without this check, the driver fails one of the E2E storage tests in
Kubernetes 1.13: provisioning a block volume is expected to fail in
e689d515f7/test/e2e/storage/testsuites/volumemode.go (L329-L330)
2019-01-14 20:15:09 +00:00
403cad682c
rbd: protect against concurrent gRPC calls
...
The timeout value in external-provisioner is fairly low. It's not
uncommon that it times out and retries before the rbdplugin is done
with CreateVolume. rbdplugin has to serialize calls and ensure that
they are idempotent to deal with this.
2019-01-14 20:15:09 +00:00
2c3961b960
pkg/rbd/rbd.go: Fix "go vet" errors
2018-12-04 21:54:00 -05:00
23a4126aed
pkg/rbd/controllerserver.go: gofmt
2018-12-04 21:44:04 -05:00
22e23640a4
pkg/rbd/rbd.go: Updated PluginFolder to use new CSI 1.x directory
2018-12-04 15:38:09 -05:00
af3083f717
pkg: Updated "version" variables from 0.3.0 to 1.0.0
2018-11-29 13:15:52 -05:00
93cb8a04d7
pkg/rbd: Updated for new versions of CSI/Kubernetes dependencies
2018-11-24 14:18:24 -05:00
720ad4afeb
rbd: protect against concurrent gRPC calls
...
The timeout value in external-provisioner is fairly low. It's not
uncommon that it times out and retries before the rbdplugin is done
with CreateVolume. rbdplugin has to serialize calls and ensure that
they are idempotent to deal with this.
2018-10-26 15:29:48 +02:00
188cdd1d68
Merge pull request #89 from rootfs/containerized
...
support nsmounter when running in containerized mode
2018-10-15 20:25:40 -04:00
3436a094f7
support nsmounter when running in containerized mode
...
Signed-off-by: Huamin Chen <hchen@redhat.com >
2018-10-15 14:59:41 +00:00
25e3a961c3
rbdplugin: idempotent DeleteVolume
...
When the initial DeleteVolume times out (as it does on slow clusters
due to the low 10 second limit), the external-provisioner calls it
again. The CSI standard requires the second call to succeed if the
volume has been deleted in the meantime. This didn't work because
DeleteVolume returned an error when failing to find the volume info
file:
rbdplugin: E1008 08:05:35.631783 1 utils.go:100] GRPC error: rbd: open err /var/lib/kubelet/plugins/csi-rbdplugin/controller/csi-rbd-622a252c-cad0-11e8-9112-deadbeef0101.json/open /var/lib/kubelet/plugins/csi-rbdplugin/controller/csi-rbd-622a252c-cad0-11e8-9112-deadbeef0101.json: no such file or directory
The fix is to treat a missing volume info file as "volume already
deleted" and return success. To detect this, the original os error
must be wrapped, otherwise the caller of loadVolInfo cannot determine
the root cause.
Note that further work may be needed to make the driver really
resilient, for example there are probably concurrency issues.
But for now this fixes : #82
2018-10-09 12:08:56 +02:00
239f295dd1
Merge pull request #79 from rootfs/rbd-nbd
...
allow monitors be embedded in credential secret
2018-09-24 08:58:09 -04:00
d5b7543565
allow monitors be embedded in credential secret
...
Signed-off-by: Huamin Chen <hchen@redhat.com >
2018-09-21 14:43:01 +00:00
